All of lore.kernel.org
 help / color / mirror / Atom feed
From: David.Wu <david.wu@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v4, 6/7] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii
Date: Fri, 31 Aug 2018 19:57:05 +0800	[thread overview]
Message-ID: <67207cc4-5d2a-573c-62c2-a940280bde70@rock-chips.com> (raw)
In-Reply-To: <1535437505-32297-7-git-send-email-j.hagemann@phytec.de>

Hi Janine,

Thank you for the fix.

在 2018/8/28 14:25, Janine Hagemann 写道:
> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of
> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii()
> to enable the RX delay.
> The MASK was used in a wrong way.
> 
> Signed-off-by: Janine Hagemann<j.hagemann@phytec.de>
> Reviewed-by: Philipp Tomisch<philipp.tomisch@theobroma-systems.com>
> Acked-by: Joe Hershberger<joe.hershberger@ni.com>

  reply	other threads:[~2018-08-31 11:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28  6:24 [U-Boot] [PATCH v4 0/7] Add ethernet support for phyCORE-RK3288 Janine Hagemann
2018-08-28  6:24 ` [U-Boot] [PATCH v4 1/7] arch: arm: mach-rockchip: rk3288: Enable regulators in board_init Janine Hagemann
2018-08-28  6:25 ` [U-Boot] [PATCH v4 2/7] config: phycore-rk3288_defconfig: add PHY_TI Janine Hagemann
2018-08-28  6:25 ` [U-Boot] [PATCH v4 3/7] drivers: net: designware: Add reading of DT phy-handle node Janine Hagemann
2018-08-28 23:53   ` Grygorii Strashko
2018-08-28  6:25 ` [U-Boot] [PATCH v4 4/7] ARM: dts: rockchip: ADD dp83867 CLK_OUT muxing Janine Hagemann
2018-08-28  6:25 ` [U-Boot] [PATCH v4 5/7] rockchip: rk3288-phycore: set flash1 iodomain to 1.8V Janine Hagemann
2018-08-28  6:25 ` [U-Boot] [PATCH v4 6/7] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii Janine Hagemann
2018-08-31 11:57   ` David.Wu [this message]
2018-10-04 20:08   ` [U-Boot] [U-Boot, v4, " Philipp Tomsich
2018-08-28  6:25 ` [U-Boot] [PATCH v4 7/7] net: gmac_rockchip: Add handeling for RGMII_ID/RXID/TXID Janine Hagemann
2018-08-31 11:54   ` [U-Boot] [U-Boot, v4, " David.Wu
2018-08-31 12:24     ` [U-Boot] [Resend] " David.Wu
2018-10-04 20:08   ` [U-Boot] " Philipp Tomsich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67207cc4-5d2a-573c-62c2-a940280bde70@rock-chips.com \
    --to=david.wu@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.