From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2 3/3] ARM: dts: meson: switch the clock controller to the HHI register area References: <20181028120859.5735-1-martin.blumenstingl@googlemail.com> <20181028120859.5735-4-martin.blumenstingl@googlemail.com> From: Neil Armstrong Message-ID: <6720a94f-ee87-937c-e360-87c2e37d29aa@baylibre.com> Date: Fri, 30 Nov 2018 11:18:05 +0100 MIME-Version: 1.0 In-Reply-To: <20181028120859.5735-4-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Martin Blumenstingl , jbrunet@baylibre.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org Cc: mturquette@baylibre.com, sboyd@kernel.org, carlo@caione.org, khilman@baylibre.com, linux-clk@vger.kernel.org List-ID: On 28/10/2018 13:08, Martin Blumenstingl wrote: > The clock controller on Meson8/Meson8m2 and Meson8b is part of a > register region called "HHI". This register area contains more > functionality than just a clock controller: > - the clock controller > - some reset controller bits > - temperature sensor calibration data (on Meson8b and Meson8m2 only) > - HDMI controller > > Allow access to this HHI register area as "system controller". Also > migrate the Meson8 and Meson8b clock controllers to this new node. > > Signed-off-by: Martin Blumenstingl > Acked-by: Neil Armstrong > --- > arch/arm/boot/dts/meson.dtsi | 7 +++++++ > arch/arm/boot/dts/meson8.dtsi | 15 ++++++++------- > arch/arm/boot/dts/meson8b.dtsi | 15 ++++++++------- > 3 files changed, 23 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/boot/dts/meson.dtsi b/arch/arm/boot/dts/meson.dtsi > index 0d9faf1a51ea..ad903d1a2cb6 100644 > --- a/arch/arm/boot/dts/meson.dtsi > +++ b/arch/arm/boot/dts/meson.dtsi [...] > > +&hhi { > + clkc: clock-controller { > + compatible = "amlogic,meson8-clkc"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > +}; > + > &hwrng { > compatible = "amlogic,meson8b-rng", "amlogic,meson-rng"; > clocks = <&clkc CLKID_RNG0>; > Kevin, I didn't apply this one, but it can wait another cycle I think. Neil From mboxrd@z Thu Jan 1 00:00:00 1970 From: narmstrong@baylibre.com (Neil Armstrong) Date: Fri, 30 Nov 2018 11:18:05 +0100 Subject: [PATCH v2 3/3] ARM: dts: meson: switch the clock controller to the HHI register area In-Reply-To: <20181028120859.5735-4-martin.blumenstingl@googlemail.com> References: <20181028120859.5735-1-martin.blumenstingl@googlemail.com> <20181028120859.5735-4-martin.blumenstingl@googlemail.com> Message-ID: <6720a94f-ee87-937c-e360-87c2e37d29aa@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 28/10/2018 13:08, Martin Blumenstingl wrote: > The clock controller on Meson8/Meson8m2 and Meson8b is part of a > register region called "HHI". This register area contains more > functionality than just a clock controller: > - the clock controller > - some reset controller bits > - temperature sensor calibration data (on Meson8b and Meson8m2 only) > - HDMI controller > > Allow access to this HHI register area as "system controller". Also > migrate the Meson8 and Meson8b clock controllers to this new node. > > Signed-off-by: Martin Blumenstingl > Acked-by: Neil Armstrong > --- > arch/arm/boot/dts/meson.dtsi | 7 +++++++ > arch/arm/boot/dts/meson8.dtsi | 15 ++++++++------- > arch/arm/boot/dts/meson8b.dtsi | 15 ++++++++------- > 3 files changed, 23 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/boot/dts/meson.dtsi b/arch/arm/boot/dts/meson.dtsi > index 0d9faf1a51ea..ad903d1a2cb6 100644 > --- a/arch/arm/boot/dts/meson.dtsi > +++ b/arch/arm/boot/dts/meson.dtsi [...] > > +&hhi { > + clkc: clock-controller { > + compatible = "amlogic,meson8-clkc"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > +}; > + > &hwrng { > compatible = "amlogic,meson8b-rng", "amlogic,meson-rng"; > clocks = <&clkc CLKID_RNG0>; > Kevin, I didn't apply this one, but it can wait another cycle I think. Neil