From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbcHHRt6 (ORCPT ); Mon, 8 Aug 2016 13:49:58 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:29499 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbcHHRt4 (ORCPT ); Mon, 8 Aug 2016 13:49:56 -0400 Subject: Re: [PATCH v13 3/6] CPM/QE: use genalloc to manage CPM/QE muram To: Qiang Zhao , Zhao Qiang , "lauraa@codeaurora.org" References: <1448851737-33125-1-git-send-email-qiang.zhao@freescale.com> <1448851737-33125-3-git-send-email-qiang.zhao@freescale.com> <7730792c-db7f-c644-55dc-0cea5ee65c0b@c-s.fr> Cc: "catalin.marinas@arm.com" , "linux-kernel@vger.kernel.org" , Scott Wood , "olof@lixom.net" , "akpm@linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "X.xie@freescale.com" From: christophe leroy Message-ID: <6724af54-92ef-8d8f-8c2b-c2b4ebfc240c@c-s.fr> Date: Mon, 8 Aug 2016 19:49:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 160807-0, 07/08/2016), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 08/08/2016 à 05:00, Qiang Zhao a écrit : > On 6/8/2016 03:48AM, Christophe Leroy wrote : > >> -----Original Message----- >> From: Christophe Leroy [mailto:christophe.leroy@c-s.fr] >> Sent: Saturday, August 06, 2016 12:59 AM >> To: Zhao Qiang ; lauraa@codeaurora.org >> Cc: catalin.marinas@arm.com; linux-kernel@vger.kernel.org; Scott Wood >> ; olof@lixom.net; akpm@linux-foundation.org; linuxppc- >> dev@lists.ozlabs.org; X.xie@freescale.com >> Subject: Re: [PATCH v13 3/6] CPM/QE: use genalloc to manage CPM/QE muram >> >> >> >> Le 30/11/2015 à 03:48, Zhao Qiang a écrit : >>> Use genalloc to manage CPM/QE muram instead of rheap. >>> >>> Signed-off-by: Zhao Qiang >>> --- >>> Changes for v9: >>> - splitted from patch 3/5, modify cpm muram management functions. >>> Changes for v10: >>> - modify cpm muram first, then move to qe_common >>> - modify commit. >>> Changes for v11: >>> - factor out the common alloc code >>> - modify min_alloc_order to zero for cpm_muram_alloc_fixed. >>> Changes for v12: >>> - Nil >>> Changes for v13: >>> - rebase >>> >>> arch/powerpc/include/asm/cpm.h | 3 + >>> arch/powerpc/platforms/Kconfig | 4 +- >>> arch/powerpc/sysdev/cpm_common.c | 126 >> +++++++++++++++++++++++++++------------ >>> lib/genalloc.c | 2 +- >>> 4 files changed, 94 insertions(+), 41 deletions(-) >>> >> >> With that patch applied, I get the following Oops on a 8xx (Which has a CPM1). >> >> cpm_muram_init() is called from setup_arch() >> >> It seems that gen_pool_add() tries to kmalloc() memory but the SLAB is not >> available yet. >> > > Thank you for your comments, I can't find a 8xx board, would you like to test the patch > Attached on your board? Thanks for your support (indeed I only received your mail a few minutes, that is after I proposed another patch). Your patch will not work, because initcalls are called too late. The 8xx needs the SMCs from the CPM for console, that is long before initcalls are called. I sent a proposed patch approximatly 2 hours ago, it is called "[PATCH] soc: fsl/qe: fix Oops on CPM1 (and likely CPM2)" That one works. Could you have a look ? Christophe --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus