From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fL1Hp-00008D-Bl for qemu-devel@nongnu.org; Tue, 22 May 2018 03:00:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fL1Hl-0000AV-2a for qemu-devel@nongnu.org; Tue, 22 May 2018 03:00:45 -0400 Received: from goliath.siemens.de ([192.35.17.28]:39521) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fL1Hk-0000A6-Nr for qemu-devel@nongnu.org; Tue, 22 May 2018 03:00:40 -0400 References: <267f42a5-b7ce-379e-ffd1-f2611393d2ff@web.de> From: Jan Kiszka Message-ID: <6730e270-9906-a43c-68b0-7a09a0743fa5@siemens.com> Date: Tue, 22 May 2018 09:00:35 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Dmitry Fleytman , qemu-devel On 2018-04-16 17:29, Peter Maydell wrote: > On 16 April 2018 at 16:25, Jan Kiszka wrote: >> On 2018-04-01 23:17, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when >>> E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the >>> issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e: Avoid >>> receiver overrun interrupt bursts") and was worked around by >>> 745d0bd3af99 ("e1000e: Remove Other from EIAC"). >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> This resolves the issue I reported on February 18 ("e1000e: MSI-X >>> problem with recent Linux drivers"). >>> >>> hw/net/e1000e_core.c | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c >>> index ecf9b15555..d38f025c0f 100644 >>> --- a/hw/net/e1000e_core.c >>> +++ b/hw/net/e1000e_core.c >>> @@ -2022,10 +2022,6 @@ e1000e_msix_notify_one(E1000ECore *core, uint32_t cause, uint32_t int_cfg) >>> >>> effective_eiac = core->mac[EIAC] & cause; >>> >>> - if (effective_eiac == E1000_ICR_OTHER) { >>> - effective_eiac |= E1000_ICR_OTHER_CAUSES; >>> - } >>> - >>> core->mac[ICR] &= ~effective_eiac; >>> >>> if (!(core->mac[CTRL_EXT] & E1000_CTRL_EXT_IAME)) { >>> >> >> Ping for this - as well as https://patchwork.ozlabs.org/patch/895476. >> >> Given that q35 uses e1000e by default and many Linux kernel versions no >> longer work, this should likely go into upcoming and stable versions > > I'd rather not put it into 2.12 at this point in the release > cycle unless it's a regression from 2.11, I think. Second ping - nothing hit the repo so far, nor did I receive feedback. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux