All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Kurbjun <kkurbjun@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
	stable@vger.kernel.org
Subject: Re: [PATCH] HID: Ignore battery for Elan touchscreen on HP Envy X360 15t-dr100
Date: Tue, 11 Jan 2022 19:54:16 -0700	[thread overview]
Message-ID: <6735bf4f-b5e1-a982-6502-bd62c7715443@gmail.com> (raw)
In-Reply-To: <YdvYVQub0+pu5ahg@kroah.com>

On 1/9/22 23:55, Greg KH wrote:
> On Sun, Jan 09, 2022 at 08:49:35PM -0700, Karl Kurbjun wrote:
>> Battery status on Elan tablet driver is reported for the HP ENVY x360
>> 15t-dr100. There is no separate battery for the Elan controller resulting
>> in a battery level report of 0% or 1% depending on whether a stylus has
>> interacted with the screen. These low battery level reports causes a
>> variety of bad behavior in desktop environments. This patch adds the
>> appropriate quirk to indicate that the batery status is unused for this
>> target.
>>
>> Signed-off-by: Karl Kurbjun <kkurbjun@gmail.com>
>> ---
>>   drivers/hid/hid-ids.h   | 1 +
>>   drivers/hid/hid-input.c | 2 ++
>>   2 files changed, 3 insertions(+)
> 
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> </formletter>

Thanks Greg,

Sorry for the mix-up on my side.  I read that page before I submitted 
the patch but I went back and reread it.  I was trying to follow "option 
1" but I am guessing what I messed up was the cc in the signed-off area 
rather than the cc through email?

I was looking for an example of that - I found these threads:
https://lore.kernel.org/lkml/20130618161238.626277186@linuxfoundation.org/
and this one was what I was originally modeling my submission off of:
https://lore.kernel.org/lkml/20210125183218.373193047@linuxfoundation.org/

Is there an example of how I should add the cc to the sign-off area.  As 
I read those threads the stable list was added to the email cc?  Should 
I resubmit it to the linux-input with the appropriate change or follow a 
different flow now that the first email went out?

If I were going to resubmit I think I would need to to like so:

...
 > target.
 >
Cc: stable@vger.kernel.org
 > Signed-off-by: Karl Kurbjun <kkurbjun@gmail.com>
 > ---
 >  drivers/hid/hid-ids.h   | 1 +
 >  drivers/hid/hid-input.c | 2 ++
 >  2 files changed, 3 insertions(+)
 >
 > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
 > index 19da07777d62..a5a5a64c7abc 100644
...

Is that correct?

Karl

  reply	other threads:[~2022-01-12  2:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10  3:49 [PATCH] HID: Ignore battery for Elan touchscreen on HP Envy X360 15t-dr100 Karl Kurbjun
2022-01-10  6:55 ` Greg KH
2022-01-12  2:54   ` Karl Kurbjun [this message]
2022-01-12  7:03     ` Greg KH
2022-01-12 10:13 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6735bf4f-b5e1-a982-6502-bd62c7715443@gmail.com \
    --to=kkurbjun@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.