From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756033AbdC2Kqy convert rfc822-to-8bit (ORCPT ); Wed, 29 Mar 2017 06:46:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49110 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753541AbdC2Kqc (ORCPT ); Wed, 29 Mar 2017 06:46:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2201161D01 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pagupta@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2201161D01 Date: Wed, 29 Mar 2017 06:46:27 -0400 (EDT) From: Pankaj Gupta To: Jason Wang Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <674632255.8752546.1490784387956.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1490069087-4783-1-git-send-email-jasowang@redhat.com> <1490069087-4783-8-git-send-email-jasowang@redhat.com> <20170322155111-mutt-send-email-mst@kernel.org> Subject: Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.65.193.72] Thread-Topic: vhost_net: try batch dequing from skb array Thread-Index: +Ouu4NanvWjZ2XO8jw0oGrijoOJPfg== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 29 Mar 2017 10:46:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jason, > > On 2017年03月23日 13:34, Jason Wang wrote: > > > > > >> > >>> +{ > >>> + if (rvq->rh != rvq->rt) > >>> + goto out; > >>> + > >>> + rvq->rh = rvq->rt = 0; > >>> + rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq, > >>> + VHOST_RX_BATCH); > >> A comment explaining why is is -bh would be helpful. > > > > Ok. > > > > Thanks > > Rethink about this. It looks like -bh is not needed in this case since > no consumer run in bh. In that case do we need other variants of "ptr_ring_consume_batched_*()" functions. Are we planning to use them in future? > > Thanks > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Gupta Subject: Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Date: Wed, 29 Mar 2017 06:46:27 -0400 (EDT) Message-ID: <674632255.8752546.1490784387956.JavaMail.zimbra@redhat.com> References: <1490069087-4783-1-git-send-email-jasowang@redhat.com> <1490069087-4783-8-git-send-email-jasowang@redhat.com> <20170322155111-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, "Michael S. Tsirkin" To: Jason Wang Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org SGkgSmFzb24sCgo+IAo+IE9uIDIwMTflubQwM+aciDIz5pelIDEzOjM0LCBKYXNvbiBXYW5nIHdy b3RlOgo+ID4KPiA+Cj4gPj4KPiA+Pj4gK3sKPiA+Pj4gKyAgICBpZiAocnZxLT5yaCAhPSBydnEt PnJ0KQo+ID4+PiArICAgICAgICBnb3RvIG91dDsKPiA+Pj4gKwo+ID4+PiArICAgIHJ2cS0+cmgg PSBydnEtPnJ0ID0gMDsKPiA+Pj4gKyAgICBydnEtPnJ0ID0gc2tiX2FycmF5X2NvbnN1bWVfYmF0 Y2hlZF9iaChydnEtPnJ4X2FycmF5LCBydnEtPnJ4cSwKPiA+Pj4gKyAgICAgICAgICAgICAgICAg ICAgICAgIFZIT1NUX1JYX0JBVENIKTsKPiA+PiBBIGNvbW1lbnQgZXhwbGFpbmluZyB3aHkgaXMg aXMgLWJoIHdvdWxkIGJlIGhlbHBmdWwuCj4gPgo+ID4gT2suCj4gPgo+ID4gVGhhbmtzCj4gCj4g UmV0aGluayBhYm91dCB0aGlzLiBJdCBsb29rcyBsaWtlIC1iaCBpcyBub3QgbmVlZGVkIGluIHRo aXMgY2FzZSBzaW5jZQo+IG5vIGNvbnN1bWVyIHJ1biBpbiBiaC4KCkluIHRoYXQgY2FzZSBkbyB3 ZSBuZWVkIG90aGVyIHZhcmlhbnRzIG9mICJwdHJfcmluZ19jb25zdW1lX2JhdGNoZWRfKigpIiBm dW5jdGlvbnMuCkFyZSB3ZSBwbGFubmluZyB0byB1c2UgdGhlbSBpbiBmdXR1cmU/IAoKPiAKPiBU aGFua3MKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K VmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZv dW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xp c3RpbmZvL3ZpcnR1YWxpemF0aW9u