From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48FE3C433F5 for ; Thu, 7 Apr 2022 18:52:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347021AbiDGSyl (ORCPT ); Thu, 7 Apr 2022 14:54:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347013AbiDGSyk (ORCPT ); Thu, 7 Apr 2022 14:54:40 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4D4E198525 for ; Thu, 7 Apr 2022 11:52:37 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id w18so7446423edi.13 for ; Thu, 07 Apr 2022 11:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LSrB5ZSufgqlnK9gL9ZTZVASbmrEu9CqOwd5kSfzetw=; b=QwSL3qZenEAdVWiG1sko9Mb/zJvDcltL7tVrGmYdyNBzY4zmOiDF5pCRBQxAiFNgY/ I2wF+7U1k3CadYD6N2m6hNjG3YXLKkLrJVReGJ4pZqJHSVDbf87lCIdE8w5Mq+ssVVWc Ab/AXwFf1W3oUYR4auM85S38gtywj97sf4TYNbt/jorXwXpfgUe82neOjQDruWPZZ61M zN/VlQbreHEbmqqoepv5PUEir92DMJ5UptgIBNfQi2+7lmPooscyL2lvvmTX98BTvrHw BTEmpomwoFPbC8vqb6ZWbBXIJhv0QFYb+dFQlOVIXLtCeuzHeVsc45nw4z4zQkfYlcAw EDlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LSrB5ZSufgqlnK9gL9ZTZVASbmrEu9CqOwd5kSfzetw=; b=hsSfuAFA44vawFhsKZsGCTBI31Fn+rwu56RMpk8P3WXleFhWKXMbFqEmdJgoTqAG7z BRFiklTWgRDzvWDQ7UrU646RGojLA36ZTknUFP5jDHFu4x93cz7GLcuE3MPIOc89kXo2 xb+6I0fb6Ro3Bnz2lVOTnsPHxB+Dm9rDq8JEkuBlmTOolVwak1b7U4EpLO4TLP5oNieu dRhQfnlsnpj7LUqrkHpR0G7tXdierUdUZJIcQRfx7uBGLFy81GV+cmu2BFtxm8Sdu4CF hFdKto0RPQOOHHZwvsPY/kghF+FlKa2UstQrX1RyV2bFDvZWlVVJgykx8wMQwUh4RRLU rY2w== X-Gm-Message-State: AOAM5317UuEn85xXy4z+lTgZzViKMCLTNr4SE8CmnZ9O6J6ZUufGiLF9 crSZSeDiQ7V9JKNXx1wJsntBHQ== X-Google-Smtp-Source: ABdhPJyjWS/xkSQpxE1xsWATTzEmh3/25DFKD05Tap4C5ZGjW/efdjvUqFCLVeqq72XdhY644iBIFg== X-Received: by 2002:a05:6402:218:b0:419:d804:9483 with SMTP id t24-20020a056402021800b00419d8049483mr16004209edv.396.1649357555980; Thu, 07 Apr 2022 11:52:35 -0700 (PDT) Received: from [192.168.0.187] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id kk13-20020a170907766d00b006e1442fcff8sm7961379ejc.175.2022.04.07.11.52.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 11:52:35 -0700 (PDT) Message-ID: <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org> Date: Thu, 7 Apr 2022 20:52:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-6-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: <20220406233648.21644-6-brad@pensando.io> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 07/04/2022 01:36, Brad Larson wrote: > The Pensando Elba SoC has integrated the DW APB SPI Controller > and requires the property pensando,syscon-spics for access > to the spics control register. > > Signed-off-by: Brad Larson > --- > Change from V3: > - Add required property pensando,syscon-spics to go with > pensando,elba-spi Thank you for your patch. There is something to discuss/improve. > .../bindings/spi/snps,dw-apb-ssi.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index d7e08b03e204..41c3bbf5a55c 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -37,6 +37,21 @@ allOf: > else: > required: > - interrupts > + - if: > + properties: > + compatible: > + contains: > + enum: > + - pensando,elba-spi > + then: > + properties: > + pensando,syscon-spics: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the system control device node which provides access to > + the spics control register It looks you only need to poke one register from spics, so it could be something like: items: - items: - description: Phandle to the system control device node - description: spics control register offset Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3460C433EF for ; Thu, 7 Apr 2022 18:53:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yJvDmOgHb8TKavhyttVIqL07hL6Xb4bcyRsO3Sl8MbU=; b=QstGqR8pmIxPFY xFHRo8ja3SwfFSVijiqaQJ65Ac8tGm10EbZZPpl6SRa6vDcaCBhdZHWKK7axJwE6npZ+h6hCS8Ano Anou7EZUK6o6DoKu3AcjsSxpyhOKjx7WG/kyBdA9CYyivAJxglQLlVdNfU086ktwGKrrOvg/pTeLt 59Di5/nLGK+QoKiPSoLcX6BLI9SreJ7TC2eCpNzqXo3UKRiqJyWED6Kk2IFonsNYJvv0jnKswhnD+ VzSyG9hKh2SEK0917ABeK12qrJnKUXUBrGfEM/5HN5TSKjggBJ9tM7wS6JJEWTeYbxjFhCtHVKO5U ZIbMVk2ECMXFeOxPV9yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncXFK-00DbeP-NS; Thu, 07 Apr 2022 18:52:42 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncXFH-00Dbcs-S5 for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 18:52:41 +0000 Received: by mail-ed1-x531.google.com with SMTP id c42so7496548edf.3 for ; Thu, 07 Apr 2022 11:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LSrB5ZSufgqlnK9gL9ZTZVASbmrEu9CqOwd5kSfzetw=; b=QwSL3qZenEAdVWiG1sko9Mb/zJvDcltL7tVrGmYdyNBzY4zmOiDF5pCRBQxAiFNgY/ I2wF+7U1k3CadYD6N2m6hNjG3YXLKkLrJVReGJ4pZqJHSVDbf87lCIdE8w5Mq+ssVVWc Ab/AXwFf1W3oUYR4auM85S38gtywj97sf4TYNbt/jorXwXpfgUe82neOjQDruWPZZ61M zN/VlQbreHEbmqqoepv5PUEir92DMJ5UptgIBNfQi2+7lmPooscyL2lvvmTX98BTvrHw BTEmpomwoFPbC8vqb6ZWbBXIJhv0QFYb+dFQlOVIXLtCeuzHeVsc45nw4z4zQkfYlcAw EDlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LSrB5ZSufgqlnK9gL9ZTZVASbmrEu9CqOwd5kSfzetw=; b=jWzopE1TAVpTWqpH1MaOKl0cFqRbjOLQgZEHbsodbkM+GqAvMHU5tUZX1Cqyn/WFA0 O/3IiofrVwFyv2HBX+Lm5bAmfjcqkv1pboT8SazXtGi9XT2qt1xIxWScj4DtKzjKimW8 vcbCdHv7wLmWnwJLaxJgMJsmzehE2wso4m9Ew0iRtE4qGqu2X1slkSP7sRjvXcut6tDN fZ+I8ESzCYmDGFloe0v2Udk2JCDaWlFsjJfclI4256XY9rcY/6AXi2LhF7LW4obJ+cpC IErg5g0wyXc5h0KlRrm03ZTJYAjAKDdJvM51oFSp3yOGA0c34z7jRsiRGJ8Ygzc4mJs9 om5Q== X-Gm-Message-State: AOAM531/Dbhk7tBzlcWE+amvBS9lm1JWHyZXC8xgJz48aAXES36pGrgb gUI0aLWRjcBB4xoswYwGsAkMFQ== X-Google-Smtp-Source: ABdhPJyjWS/xkSQpxE1xsWATTzEmh3/25DFKD05Tap4C5ZGjW/efdjvUqFCLVeqq72XdhY644iBIFg== X-Received: by 2002:a05:6402:218:b0:419:d804:9483 with SMTP id t24-20020a056402021800b00419d8049483mr16004209edv.396.1649357555980; Thu, 07 Apr 2022 11:52:35 -0700 (PDT) Received: from [192.168.0.187] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id kk13-20020a170907766d00b006e1442fcff8sm7961379ejc.175.2022.04.07.11.52.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 11:52:35 -0700 (PDT) Message-ID: <6769ea2d-9e6a-03b1-0e05-cb5b7379cb5e@linaro.org> Date: Thu, 7 Apr 2022 20:52:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-6-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: <20220406233648.21644-6-brad@pensando.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_115239_958281_4B11DF18 X-CRM114-Status: GOOD ( 16.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/04/2022 01:36, Brad Larson wrote: > The Pensando Elba SoC has integrated the DW APB SPI Controller > and requires the property pensando,syscon-spics for access > to the spics control register. > > Signed-off-by: Brad Larson > --- > Change from V3: > - Add required property pensando,syscon-spics to go with > pensando,elba-spi Thank you for your patch. There is something to discuss/improve. > .../bindings/spi/snps,dw-apb-ssi.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index d7e08b03e204..41c3bbf5a55c 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -37,6 +37,21 @@ allOf: > else: > required: > - interrupts > + - if: > + properties: > + compatible: > + contains: > + enum: > + - pensando,elba-spi > + then: > + properties: > + pensando,syscon-spics: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the system control device node which provides access to > + the spics control register It looks you only need to poke one register from spics, so it could be something like: items: - items: - description: Phandle to the system control device node - description: spics control register offset Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel