From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH V10 1/2] eal: add uevent monitor api and
	callback func
Date: Mon, 15 Jan 2018 00:16:26 +0100
Message-ID: <6774704.u5U2Uf1Nb3@xps>
References: <1515575544-2141-3-git-send-email-jia.guo@intel.com>
 <1515679534-22473-1-git-send-email-jia.guo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com,
 ferruh.yigit@intel.com, gaetan.rivet@6wind.com, konstantin.ananyev@intel.com,
 jblunck@infradead.org, shreyansh.jain@nxp.com, jingjing.wu@intel.com,
 helin.zhang@intel.com, motih@mellanox.com
To: Jeff Guo <jia.guo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B49652D13
 for <dev@dpdk.org>; Mon, 15 Jan 2018 00:16:58 +0100 (CET)
In-Reply-To: <1515679534-22473-1-git-send-email-jia.guo@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

11/01/2018 15:05, Jeff Guo:
> +/* A genaral callback for all registerd devices */

Typos: genaral, registerd

So the callback is only for registered devices?
What about hotplugged devices?

> +/**
> + * It registers the callback for the specific event. Multiple
> + * callbacks cal be registered at the same time.
> + * @param event
> + *  The device event type.
> + * @param cb_fn
> + *  callback address.
> + * @param cb_arg
> + *  address of parameter for callback.
> + *
> + * @return
> + *  - On success, zero.
> + *  - On failure, a negative value.
> + */
> +int rte_dev_callback_register(char *dev_name,
> +			rte_dev_event_cb_fn cb_fn, void *cb_arg);
> +
> +/**
> + * It unregisters the callback according to the specified event.
> + *
> + * @param event
> + *  The event type which corresponding to the callback.
> + * @param cb_fn
> + *  callback address.
> + *  address of parameter for callback, (void *)-1 means to remove all
> + *  registered which has the same callback address.
> + *
> + * @return
> + *  - On success, return the number of callback entities removed.
> + *  - On failure, a negative value.
> + */
> +int rte_dev_callback_unregister(char *dev_name,
> +			rte_dev_event_cb_fn cb_fn, void *cb_arg);

These new functions should be tagged as experimental.

> +/**
> + * Start the device event monitoring.
> + *
> + * @param none
> + * @return
> + *   - On success, zero.
> + *   - On failure, a negative value.
> + */
> +int
> +rte_dev_evt_mntr_start(void);

Should be experimental too, as every new public functions.

Please avoid shortening function name too much.
rte_dev_event_monitor_start is more pleasant to read.