From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h"
Date: Tue, 5 Feb 2019 10:42:26 +0100 [thread overview]
Message-ID: <67868e05-4481-707a-0311-617a388c8b50@redhat.com> (raw)
In-Reply-To: <20190204210433.26088-3-philmd@redhat.com>
On 2019-02-04 22:04, Philippe Mathieu-Daudé wrote:
> In 47973a2dbf we split the last generic chipset out of the PC
> board, but forgot to remove the include of "hw/i386/pc.h".
> Since it is now unused, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/unicore32/puv3.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c
> index 830fe3face..b42e600f74 100644
> --- a/hw/unicore32/puv3.c
> +++ b/hw/unicore32/puv3.c
> @@ -15,7 +15,6 @@
> #include "ui/console.h"
> #include "hw/boards.h"
> #include "hw/loader.h"
> -#include "hw/i386/pc.h"
> #include "sysemu/qtest.h"
>
> #undef DEBUG_PUV3
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-02-05 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 21:04 [Qemu-devel] [PATCH 0/3] hw: Drop useless inclusion of hw/i386/pc.h Philippe Mathieu-Daudé
2019-02-04 21:04 ` [Qemu-devel] [PATCH 1/3] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h" Philippe Mathieu-Daudé
2019-02-05 9:41 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-02-05 17:12 ` [Qemu-devel] " Mark Cave-Ayland
2019-02-06 14:53 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-04 21:04 ` [Qemu-devel] [PATCH 2/3] hw/unicore32/puv3: " Philippe Mathieu-Daudé
2019-02-05 9:42 ` Thomas Huth [this message]
2019-02-06 14:54 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-04 21:04 ` [Qemu-devel] [PATCH 3/3] hw/ppc/prep: " Philippe Mathieu-Daudé
2019-02-04 21:11 ` Hervé Poussineau
2019-02-05 2:25 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67868e05-4481-707a-0311-617a388c8b50@redhat.com \
--to=thuth@redhat.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.