From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51513C433EF for ; Wed, 23 Mar 2022 01:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240692AbiCWB7r (ORCPT ); Tue, 22 Mar 2022 21:59:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbiCWB7m (ORCPT ); Tue, 22 Mar 2022 21:59:42 -0400 Received: from mx1.cqplus1.com (unknown [113.204.237.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B0A5E167EB for ; Tue, 22 Mar 2022 18:58:05 -0700 (PDT) X-MailGates: (flag:1,DYNAMIC,RELAY,NOHOST,LAN:PASS)(compute_score:DELIVE R,40,3) Received: from 172.27.96.203 by mx1.cqplus1.com with MailGates ESMTP Server V5.0(7830:0:AUTH_RELAY) (envelope-from ); Wed, 23 Mar 2022 09:54:05 +0800 (CST) Received: from CQEXMAIL01.cqplus1.com (172.27.96.203) by CQEXMAIL01.cqplus1.com (172.27.96.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 23 Mar 2022 09:54:35 +0800 Received: from CQEXMAIL01.cqplus1.com ([::1]) by CQEXMAIL01.cqplus1.com ([::1]) with mapi id 15.01.2375.018; Wed, 23 Mar 2022 09:54:35 +0800 From: =?utf-8?B?cWluamlhblvopoPlgaVd?= To: Krzysztof Kozlowski CC: "robh+dt@kernel.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "tglx@linutronix.de" , "maz@kernel.org" , "p.zabel@pengutronix.de" , "linux@armlinux.org.uk" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Rob Herring Subject: RE: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Thread-Topic: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Thread-Index: AQHYPbVznEjGDkREfkyqc2C0ll94iqzKt7sAgAF7uwA= Date: Wed, 23 Mar 2022 01:54:35 +0000 Message-ID: <678d1f84d9d240b9983f9d3b82db17d4@cqplus1.com> References: <55db801055793f43678e902395913330ecb8fbbf.1647928316.git.qinjian@cqplus1.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.110.18] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiA+ICtleGFtcGxlczoNCj4gPiArICAtIHwNCj4gPiArICAgIHJzdGM6IHJlc2V0QDljMDAwMDU0 IHsNCj4gPiArICAgICAgY29tcGF0aWJsZSA9ICJzdW5wbHVzLHNwNzAyMS1yZXNldCI7DQo+ID4g KyAgICAgICNyZXNldC1jZWxscyA9IDwxPjsNCj4gPiArICAgICAgcmVnID0gPDB4OWMwMDAwNTQg MHgyOD47DQo+IA0KPiBJIGFza2VkIHlvdSB0byBwdXQgdGhlIHJlZyBhZnRlciBjb21wYXRpYmxl IGluIGFsbCBEVFMgY29kZSBhbmQNCj4gZXhhbXBsZXMuIElmIHlvdSBkbyBub3QgYWdyZWUgd2l0 aCBhIGNvbW1lbnQsIHBsZWFzZSByZXNwb25kLiBJZ25vcmluZw0KPiBpdCBpcyBub3QgY29vcGVy YXRpdmUuDQo+IA0KDQpZb3VyICByZXBseTogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsL2Qz YWMzZTJmLTcxZmQtYjJiNC03YzdlLWJiNDNjNjgxZDE0ZUBjYW5vbmljYWwuY29tLw0KPiA+ICsg IC0gfA0KPiA+ICsNCj4gPiArICAgIGNsa2M6IGNsb2NrLWNvbnRyb2xsZXJAOWMwMDAwMDAgew0K PiA+ICsgICAgICBjb21wYXRpYmxlID0gInN1bnBsdXMsc3A3MDIxLWNsa2MiOw0KPiA+ICsgICAg ICAjY2xvY2stY2VsbHMgPSA8MT47DQo+ID4gKyAgICAgIHJlZyA9IDwweDljMDAwMDAwIDB4Mjgw PjsNCj4NCj4gSW4gRFRTIGNvZGUsIHBsZWFzZSBwdXQgcmVnIGFmdGVyIGNvbXBhdGlibGUuIElu IGFsbCB5b3VyIGV4YW1wbGVzIGFuZA0KPiBEVFMgcGF0Y2hlcy4NCj4NCj4NCj4gUmV2aWV3ZWQt Ynk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAY2Fub25pY2FsLmNv bT4NCg0KSSBzZWUgeW91ciByZXZpZXctdGFnLiBTbywgSSBtaXN1bmRlcnN0YW5kIHlvdXIgY29t bWVudHMuDQpEaWQgeW91IG1lYW5zICdyZWcnIG11c3QgZGlyZWN0bHkgYWZ0ZXIgdGhlICdjb21w YXRpYmxlJywgbGlrZSB0aGlzPw0KICAgIGNsa2M6IGNsb2NrLWNvbnRyb2xsZXJAOWMwMDAwMDAg ew0KICAgICAgI2Nsb2NrLWNlbGxzID0gPDE+Ow0KICAgICAgY29tcGF0aWJsZSA9ICJzdW5wbHVz LHNwNzAyMS1jbGtjIjsNCiAgICAgIHJlZyA9IDwweDljMDAwMDAwIDB4MjgwPjsNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00472C433EF for ; Wed, 23 Mar 2022 01:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w2tmvU6MUKTEIZxr0wOhb4wYlDUt5fhkBg9BqowPiyM=; b=bpNHDfDKZyF4Wm z+N4DsEQS3MQYmp5vzxRpdK8t9usacuxHGBvdLSQHBAQhk5haxKVV0yEuQO+WCD56iRgYAPBLzygo NbHENpWCOPjUfLiRctSSRE1XFa5MCWzEOfnw4DmZR797TZoN7hpoIeZ1/+2EpUSIeUgzonCp06SNt VCvolrySFRyX7Fnp5GGUD3Bl9lSxnp7gMi96F5TPJgRCT0JPxKwS5Mli1SoeSg7jOnXWGfhxFhJuv pH8ILX9RWyqokUlZztDU/OWgpvxbPJNqL8Jl1ZkBN38IxPPrgHTHOY2R8WDT6Q0n7xwU7WZ1N4KK/ xR/cUDDA8jHTfA/mwZUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWqFi-00CbLo-7m; Wed, 23 Mar 2022 01:57:34 +0000 Received: from mx1.cqplus1.com ([113.204.237.245]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWqFd-00CbLS-Pz for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 01:57:32 +0000 X-MailGates: (flag:1,DYNAMIC,RELAY,NOHOST,LAN:PASS)(compute_score:DELIVE R,40,3) Received: from 172.27.96.203 by mx1.cqplus1.com with MailGates ESMTP Server V5.0(7830:0:AUTH_RELAY) (envelope-from ); Wed, 23 Mar 2022 09:54:05 +0800 (CST) Received: from CQEXMAIL01.cqplus1.com (172.27.96.203) by CQEXMAIL01.cqplus1.com (172.27.96.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 23 Mar 2022 09:54:35 +0800 Received: from CQEXMAIL01.cqplus1.com ([::1]) by CQEXMAIL01.cqplus1.com ([::1]) with mapi id 15.01.2375.018; Wed, 23 Mar 2022 09:54:35 +0800 From: =?utf-8?B?cWluamlhblvopoPlgaVd?= To: Krzysztof Kozlowski CC: "robh+dt@kernel.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "tglx@linutronix.de" , "maz@kernel.org" , "p.zabel@pengutronix.de" , "linux@armlinux.org.uk" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Rob Herring Subject: RE: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Thread-Topic: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Thread-Index: AQHYPbVznEjGDkREfkyqc2C0ll94iqzKt7sAgAF7uwA= Date: Wed, 23 Mar 2022 01:54:35 +0000 Message-ID: <678d1f84d9d240b9983f9d3b82db17d4@cqplus1.com> References: <55db801055793f43678e902395913330ecb8fbbf.1647928316.git.qinjian@cqplus1.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.110.18] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_185730_226531_68A2ABDD X-CRM114-Status: UNSURE ( 8.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > +examples: > > + - | > > + rstc: reset@9c000054 { > > + compatible = "sunplus,sp7021-reset"; > > + #reset-cells = <1>; > > + reg = <0x9c000054 0x28>; > > I asked you to put the reg after compatible in all DTS code and > examples. If you do not agree with a comment, please respond. Ignoring > it is not cooperative. > Your reply: https://lore.kernel.org/all/d3ac3e2f-71fd-b2b4-7c7e-bb43c681d14e@canonical.com/ > > + - | > > + > > + clkc: clock-controller@9c000000 { > > + compatible = "sunplus,sp7021-clkc"; > > + #clock-cells = <1>; > > + reg = <0x9c000000 0x280>; > > In DTS code, please put reg after compatible. In all your examples and > DTS patches. > > > Reviewed-by: Krzysztof Kozlowski I see your review-tag. So, I misunderstand your comments. Did you means 'reg' must directly after the 'compatible', like this? clkc: clock-controller@9c000000 { #clock-cells = <1>; compatible = "sunplus,sp7021-clkc"; reg = <0x9c000000 0x280>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel