All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v4 1/2] Gemalto: voicecall atom
Date: Wed, 17 Oct 2018 10:18:04 -0500	[thread overview]
Message-ID: <678e682a-6f85-6c42-e1eb-99923c9a6c4a@gmail.com> (raw)
In-Reply-To: <cae21e96-7824-6e1c-7bb8-0d73b5139528@southpole.se>

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

Hi Jonas,
>> +
>> +extern void gemalto_voicecall_init();
>> +extern void gemalto_voicecall_exit();
>> +
> 
> Why are these "extern"?
> 

Okay, I haven't had my coffee yet, but what is the actual problem?  All 
functions defined in the header are extern anyway, whether they're 
labeled extern or not.  So, dropping extern would have no actual effect 
besides style.

Regards,
-Denis

  parent reply	other threads:[~2018-10-17 15:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  4:52 [PATCH v4 0/2] Gemalto: support for voicecall Giacinto Cifelli
2018-10-17  4:52 ` [PATCH v4 1/2] Gemalto: voicecall atom Giacinto Cifelli
2018-10-17  6:28   ` Jonas Bonn
2018-10-17  7:30     ` Giacinto Cifelli
2018-10-17  8:33       ` Jonas Bonn
2018-10-17  8:52         ` Giacinto Cifelli
2018-10-17 10:29           ` Jonas Bonn
2018-10-17  8:01     ` Giacinto Cifelli
2018-10-17 15:18     ` Denis Kenzior [this message]
2018-10-17 16:30       ` Jonas Bonn
2018-10-17 16:34         ` Denis Kenzior
2018-10-17 16:37           ` Giacinto Cifelli
2018-10-17  4:52 ` [PATCH v4 2/2] plugins/gemalto: added voice support Giacinto Cifelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=678e682a-6f85-6c42-e1eb-99923c9a6c4a@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.