From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbaGVAXM (ORCPT ); Mon, 21 Jul 2014 20:23:12 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:61541 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751341AbaGVAXJ (ORCPT ); Mon, 21 Jul 2014 20:23:09 -0400 From: "Rafael J. Wysocki" To: Pavel Machek , Joerg Roedel Cc: Len Brown , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6 v2] PM / Hibernate: Memory bitmap scalability improvements Date: Tue, 22 Jul 2014 02:41:29 +0200 Message-ID: <6793803.1FXN0a3O0V@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20140721230500.GA7019@amd.pavel.ucw.cz> References: <1405938422-21900-1-git-send-email-joro@8bytes.org> <20140721160346.GP30979@8bytes.org> <20140721230500.GA7019@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 22, 2014 01:05:00 AM Pavel Machek wrote: > Hi! > > On Mon 2014-07-21 18:03:46, Joerg Roedel wrote: > > On Mon, Jul 21, 2014 at 04:10:27PM +0200, Pavel Machek wrote: > > > > And Linux is only made for sane people? Thats pretty new to me ;-) > > > > > > Yeah, but please don't optimize for insane people :-). > > > > Thats rather discriminating, even more when you realize that 'insane' is > > a very subjective attribute. > > You admitted you don't even have access to machine you are trying to > optimize for. > > > > #6 is bugfix. We should take it. Rest is performance improvement for > > > insane config. I don't think we should take it. > > > > Have you any other reason against these changes besides your > > proven-to-be-wrong disbelief that it is necessary? > > Where you proven me wrong? > > If kernel is preparing bitmaps before checking resume signature, that > is bug that costs you 60 seconds boot time on your 12TB machine. Fix > that bug. It will benefit everyone. > > Software watchdog during hibernation on 12TB machine is a bug that > hits insane people. Ok, lets fix it. > > Optimizing hibernation for memory-is-empty case is wrong. Linux tries > to use as much memory as it can. > > Hibernating 12TB machine will take 5 hours or more. Redoing data > structures to save 60 seconds of 5 hour process is not worth > it. Nobody sane would hibernate 12TB machine. It looks like some specific need motivated the Joerg's work, however, so let's just not dismiss the use case lightly without knowing it. That said I would like to know how much time we save through this optimization relative to the total hibernation time on systems with various amounts of memory (say, 4 GB, 8 GB, 16 GB, 32 GB, more) and whether or not it makes hibernation slower in any case. Rafael