All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Rong Chen <rong.a.chen@intel.com>, Shuah Khan <shuah@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>
Cc: kernel test robot <lkp@intel.com>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/vm: rename file run_vmtests to run_vmtests.sh
Date: Fri, 5 Feb 2021 12:06:02 -0800	[thread overview]
Message-ID: <6796b330-0a53-284e-83ae-7d7abf1f57f2@nvidia.com> (raw)
In-Reply-To: <20210205085507.1479894-1-rong.a.chen@intel.com>

On 2/5/21 12:55 AM, Rong Chen wrote:
> Commit c2aa8afc36fa has renamed run_vmtests in Makefile,
> but the file still uses the old name.
> 
> The kernel test robot reported the following issue:
> 
>   # selftests: vm: run_vmtests.sh
>   # Warning: file run_vmtests.sh is missing!
>   not ok 1 selftests: vm: run_vmtests.sh
> 

I don't know exactly what is going on here, but there was originally a mistake
on my part in renaming run_vmtests to run_vmtests.sh (I was trying to set
the executable bit, which is not always supported by the patch flow), and that 
caused some churn in Andrews's tree. And so maybe that rename got lost/dropped
along the way.

> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: c2aa8afc36fa (selftests/vm: rename run_vmtests --> run_vmtests.sh)
> Signed-off-by: Rong Chen <rong.a.chen@intel.com>
> ---
>   tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} | 0
>   1 file changed, 0 insertions(+), 0 deletions(-)
>   rename tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} (100%)
> 
> diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftests/vm/run_vmtests.sh
> similarity index 100%
> rename from tools/testing/selftests/vm/run_vmtests
> rename to tools/testing/selftests/vm/run_vmtests.sh
> 

So I guess this is OK, given that I see "run_vmtests" in both -next
and main.

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
-- 
John Hubbard
NVIDIA

      reply	other threads:[~2021-02-05 20:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05  8:55 [PATCH] selftests/vm: rename file run_vmtests to run_vmtests.sh Rong Chen
2021-02-05 20:06 ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6796b330-0a53-284e-83ae-7d7abf1f57f2@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=rong.a.chen@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.