From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A7EC433F5 for ; Thu, 30 Sep 2021 12:09:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B81B615E2 for ; Thu, 30 Sep 2021 12:09:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348874AbhI3MLE (ORCPT ); Thu, 30 Sep 2021 08:11:04 -0400 Received: from foss.arm.com ([217.140.110.172]:53192 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348155AbhI3MLD (ORCPT ); Thu, 30 Sep 2021 08:11:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64B91106F; Thu, 30 Sep 2021 05:09:20 -0700 (PDT) Received: from [10.57.21.68] (unknown [10.57.21.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E36493F793; Thu, 30 Sep 2021 05:09:17 -0700 (PDT) Subject: Re: [PATCH 1/5] perf cs-etm: Print size using consistent format To: Mathieu Poirier Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org References: <20210916154635.1525-1-german.gomez@arm.com> <20210923162434.GA2189675@p14s> From: German Gomez Message-ID: <67a54101-a514-6077-96ba-8809226181eb@arm.com> Date: Thu, 30 Sep 2021 13:09:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210923162434.GA2189675@p14s> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, Thanks for your feedback. I will keep these points in mind for future submissions. On 23/09/2021 17:24, Mathieu Poirier wrote: > Hi German, > > On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: >> [...] > Reviewed-by: Mathieu Poirier > > A couple of things to improve for your next interactions with the Linux community: > > 1) Using a cover letter, even for small changes, is always a good idea. > 2) RB tags should be picked up publicly rather than done internally and added to > a patchset. > 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do > with 01, 02 and 03. Did you perhaps mean separating 01 and 02 from the rest? I grouped 03 to 05 because they were related to snapshot mode. Thanks, German > > Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to > this patchset. As such he will not see your work. Ask James about how to > proceed when submitting patches to the perf tools. > > Thanks, > Mathieu > >> cs_etm_decoder__get_name(etmq->decoder), buffer->size); >> >> do { >> -- >> 2.17.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25677C433F5 for ; Thu, 30 Sep 2021 12:11:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E46746108E for ; Thu, 30 Sep 2021 12:11:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E46746108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H1xAFhcPbcIvqsNYZ7GqzAivbyeT+if+QVV4JSlYHrU=; b=jBsxvtspp2m3AC0K4OxoGvi80O Qi/QE0SNyRbfZG4DhwP+fEP5rpIgTxGdBzd2EJ3R4ibrrIlfF/fqiaVoz4HWFl7NmyH7lO0lhyRtd Pv8qP8ljfzwDcwJVyZrLYRT9iHV2YiZ/Hgmej1NqYLaTUM1puF55jyo9gZo87Hm3esPyf1xelCh6R 8VKTXU1xxcbIW7Bm7Zb1iIKkdmJ5SR29KemSHYE586IgraqhXDZzB+/HUTVKUtlGxkIH+hfcseBeo 9z6BkxWIiV+OIOyPwk3bDEfJzP9Av2SKk6b3z9M291l3BIH7K6ZnsFx1jNjnQEIQdwzUhHBAiMAkD +uIfnsbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVusU-00E8KG-EM; Thu, 30 Sep 2021 12:09:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVusQ-00E8Ir-Rs for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 12:09:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64B91106F; Thu, 30 Sep 2021 05:09:20 -0700 (PDT) Received: from [10.57.21.68] (unknown [10.57.21.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E36493F793; Thu, 30 Sep 2021 05:09:17 -0700 (PDT) Subject: Re: [PATCH 1/5] perf cs-etm: Print size using consistent format To: Mathieu Poirier Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org References: <20210916154635.1525-1-german.gomez@arm.com> <20210923162434.GA2189675@p14s> From: German Gomez Message-ID: <67a54101-a514-6077-96ba-8809226181eb@arm.com> Date: Thu, 30 Sep 2021 13:09:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210923162434.GA2189675@p14s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_050927_004448_733DA649 X-CRM114-Status: GOOD ( 18.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, Thanks for your feedback. I will keep these points in mind for future submissions. On 23/09/2021 17:24, Mathieu Poirier wrote: > Hi German, > > On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: >> [...] > Reviewed-by: Mathieu Poirier > > A couple of things to improve for your next interactions with the Linux community: > > 1) Using a cover letter, even for small changes, is always a good idea. > 2) RB tags should be picked up publicly rather than done internally and added to > a patchset. > 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do > with 01, 02 and 03. Did you perhaps mean separating 01 and 02 from the rest? I grouped 03 to 05 because they were related to snapshot mode. Thanks, German > > Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to > this patchset. As such he will not see your work. Ask James about how to > proceed when submitting patches to the perf tools. > > Thanks, > Mathieu > >> cs_etm_decoder__get_name(etmq->decoder), buffer->size); >> >> do { >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel