From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04A43C433EF for ; Sun, 2 Jan 2022 09:47:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 11DBD8111F; Sun, 2 Jan 2022 10:47:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Cpk6xHMT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 569A4811AC; Sun, 2 Jan 2022 10:47:56 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C651F801EB for ; Sun, 2 Jan 2022 10:47:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641116872; bh=K+TB1tzdAsknT7qui9E3HI/CCPWW1Bas6/BaokSSAsA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Cpk6xHMTTVnPVGGFd6tXu45VKLFSSdESp9gUGneHf7BnLTRX3Yu01LWv4206yGtcS TCfgjaEbx8RmIAtly9vlGF/o8cD6X4iMHoyLTqn30szYAsXuCk09CS7DLakNi0qVOW W02GDSd0lL5gAtfcjo/e6HXj3q4fwWvqPi/THq0c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.94] ([88.152.144.157]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MmUHj-1mdO9p23F3-00iQAR; Sun, 02 Jan 2022 10:47:52 +0100 Message-ID: <67aeb58f-548e-a4bc-7b2b-e1c9f40bcf10@gmx.de> Date: Sun, 2 Jan 2022 10:47:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC v2 05/20] mmc: call device_probe() after scanning Content-Language: en-US To: AKASHI Takahiro Cc: masami.hiramatsu@linaro.org, u-boot@lists.denx.de, agraf@csgraf.de, sjg@chromium.org, ilias.apalodimas@linaro.org References: <20211210064947.73361-1-takahiro.akashi@linaro.org> <20211210064947.73361-6-takahiro.akashi@linaro.org> From: Heinrich Schuchardt In-Reply-To: <20211210064947.73361-6-takahiro.akashi@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:nbMSUzr+UEhndTclO57YVxjefG4e8LI3YBnAtXH4qHQLDwPtZT3 NJRcc930iFVSRmFFxVwWxrr9gPV3ADPFTB6XczdQeqvd91ZZoYLfA6fQ87KJx5+rCcrA5kY Eg+QukTPzrJU5rWiE6bGphDIAg26RaFNyks8kgbdwzyjoNsAHzYuCUikrVJgq358vW558cS zlJORO7idHYkKoRu82bRg== X-UI-Out-Filterresults: notjunk:1;V03:K0:KHdgD6SycZU=:X0fx2O6sF9410bsCs6X8E/ ht6SUNcXuwDkl6gsUSVXXtxXeY9OqmwSI5nYyWrWAXJZ0o2HTFWGAFaQQ8omNdXkqFQEp2OBr 6pZdD1htEclLsKxEaJWfwJu8olwQn47vtv1nZlZcFfMet65uDaOvjEFlZYRVJxPUf0XAyN+fD DBUHVWNw4ShnAffqKKDW4FHvLKTR2JAeYlJqZOsvkGYTNpXwq+IPOFskAuc3HKJgrSq3q0oKS krB7UnosR2nnUGa6HSjmEn7c9hMwizxAxAt8TEdEzyQHmIxndKKOujVWsD74KulGt0QES5VP5 6+9n61V0bsxzzwR6L6QXwAsVl6mhxHZzB9ff0Y+ZvB5cvVNJW65yF8BU+JKDM9p7CTkJHAOdO WBYDfYe9jCywTMu4ANqO2VC5EN4Uij5wJEOuS/SJjCsOVwVxt5CaAxjlGXezgvEhjjExRucl7 DPtva15/GPOie9mMn2WzrZMdlug2/KPGXAKdElcSCnAQsSBL0fjLyjCx6WPL9X5kymORXbVOy znMxuBUeomXqEGAh0glzmIxGw3kLe6zc9RW7z+R8iUTWxjP21IgTtfJkowlQ86NnhwjNwV9M3 QDG4TZ6w1pYGtjHqGuQUddeoYh3WjK+MOxDN5aGoMmLckvEKc+ce8ZvGjnZKpgtiS6To3Qntg 8Kyf14CKcwI9yHjLw+GJXEPxA7cCJmM7TwkguU5TnTJcTFIaaNzFxojbKwI8H8rFwCAPdUopx JBw3fy7TXpPF9DjU95bM1vTVXIiwlNRrkRklD3t97LAKVv2MaaWvEaeIo1e36PPhMtpx2S7Qz 980MeaG/G+WMQoRrCnCasIXFw9Eu1B8vGTM6Xj5SWO15H5s+cTVXT2cM+08+9W9Cbz5+vbdF9 AQWUY2Q3T1DVjayioCgTKJQQDGYjdqDgRR62MklFN1/AdA8XxA8mRhBifz+cKQrqiUL0pp1mJ ra6lWM41iFWuMkREspe6k+e7YGWASrPyA00AxHSygu4iZz1au7Y930822vd3QfV4sTsJ15oGx C4CMEHrRaVoUhVGdKHNXsJ8hydDUbwP3zmXoPW6EzXNMsty8/z+m7DtIQIRHGUp+pME31CJsQ ZDa96jCHv0cfVg= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/10/21 07:49, AKASHI Takahiro wrote: > Every time a mmc bus/port is scanned and a new device is detected, > we want to call device_probe() as it will give us a chance to run > additional post-processings for some purposes. > > In particular, support for creating partitions on a device will be added= . > > Signed-off-by: AKASHI Takahiro > --- > drivers/mmc/mmc-uclass.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c > index 3ee92d03ca23..6c907b65fde7 100644 > --- a/drivers/mmc/mmc-uclass.c > +++ b/drivers/mmc/mmc-uclass.c > @@ -418,6 +418,7 @@ int mmc_bind(struct udevice *dev, struct mmc *mmc, c= onst struct mmc_config *cfg) > bdesc->part_type =3D cfg->part_type; > mmc->dev =3D dev; > mmc->user_speed_mode =3D MMC_MODES_END; > + > return 0; > } > > @@ -467,6 +468,18 @@ static int mmc_blk_probe(struct udevice *dev) > return ret; > } > > + ret =3D device_probe(dev); > + if (ret) { > + debug("Can't probe\n"); > + > + if (IS_ENABLED(CONFIG_MMC_UHS_SUPPORT) || > + IS_ENABLED(CONFIG_MMC_HS200_SUPPORT) || > + IS_ENABLED(CONFIG_MMC_HS400_SUPPORT)) > + mmc_deinit(mmc); This results in a warning when compiling sandbox_spl_defconfig: drivers/mmc/mmc-uclass.c: In function =E2=80=98mmc_blk_probe=E2=80=99: drivers/mmc/mmc-uclass.c:478:25: warning: implicit declaration of function =E2=80=98mmc_deinit=E2=80=99; did you mean =E2=80=98mmc_reinit=E2= =80=99? [-Wimplicit-function-declaration] 478 | mmc_deinit(mmc); | ^~~~~~~~~~ | mmc_reinit Best regards Heinrich > + > + return ret; > + } > + > return 0; > } >