From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77A84C433F5 for ; Thu, 7 Apr 2022 05:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ak0UDUx9+5ZGK8G/+cVg7PjCYumuECqYc3v55y8gAxo=; b=vI8+lsGdpgbvY2 9/m8RMfqaHNx6PkJXD3c2jgzBw879RYBqJlqPdwoNUEjcIz0ZNJMO5ha1NFdxv/vGaeO6nB2QCmiK 93UKpb8F9S8vZEaAL7S6jAphR5J822r9KcH6SeGU9g0X/2xhOTiVgTCqL6uqRVvqg/2oTtP7EUjp2 nhCQq2+cwA0hxvmXcKSNcUumLeJkdPV30KSu1MPByldDxm4SqmKRIPKf+PdymSgCPFNac/evBjkaG vc7w99zUP0Fb7t6JhbPugGCKyi1s9WM26sBPVs8oGm6F/4cxCXATyJAPJFCd7KnPArdrw1FjTczEd oJg4WoO5LsMH+z4hmz7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncL30-009b8V-VW; Thu, 07 Apr 2022 05:51:11 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncL2u-009b80-GM; Thu, 07 Apr 2022 05:51:09 +0000 X-UUID: 429e3728ff9549ee9ab8d5395758afc3-20220406 X-UUID: 429e3728ff9549ee9ab8d5395758afc3-20220406 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 496724877; Wed, 06 Apr 2022 22:51:00 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Apr 2022 22:46:03 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 Apr 2022 13:45:56 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 7 Apr 2022 13:45:55 +0800 Message-ID: <67b3e42d6a094108f724ed9b8c73f5cd6b2ce219.camel@mediatek.com> Subject: Re: [RESEND v17 3/7] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 From: CK Hu To: jason-jh.lin , Rob Herring , Matthias Brugger , "Chun-Kuang Hu" , AngeloGioacchino Del Regno CC: David Airlie , , "Alexandre Torgue" , , "Fabien Parent" , John 'Warthog9' Hawley , , , , Philipp Zabel , , Daniel Vetter , , , , , , , Maxime Coquelin Date: Thu, 7 Apr 2022 13:45:55 +0800 In-Reply-To: <20220407030409.9664-4-jason-jh.lin@mediatek.com> References: <20220407030409.9664-1-jason-jh.lin@mediatek.com> <20220407030409.9664-4-jason-jh.lin@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_225104_597692_C1826DDA X-CRM114-Status: GOOD ( 30.18 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Jason: On Thu, 2022-04-07 at 11:04 +0800, jason-jh.lin wrote: > 1. Add mt8195 mmsys compatible for vdosys0. > 2. Add mt8195 routing table settings and fix build fail. > 3. Add clock name, clock driver name and routing table into the > driver data > of mt8195 vdosys0. > 4. Add get match data by clock name function and clock platform > labels > to identify which mmsys node is corresponding to vdosys0. > > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +- > drivers/soc/mediatek/mt8167-mmsys.h | 2 +- > drivers/soc/mediatek/mt8183-mmsys.h | 2 +- > drivers/soc/mediatek/mt8186-mmsys.h | 4 +- > drivers/soc/mediatek/mt8192-mmsys.h | 4 +- > drivers/soc/mediatek/mt8195-mmsys.h | 370 > ++++++++++++++++++++ > drivers/soc/mediatek/mt8365-mmsys.h | 4 +- > drivers/soc/mediatek/mtk-mmsys.c | 62 ++++ > drivers/soc/mediatek/mtk-mmsys.h | 1 + > drivers/soc/mediatek/mtk-mutex.c | 8 +- > include/linux/soc/mediatek/mtk-mmsys.h | 13 +- > 12 files changed, 461 insertions(+), 17 deletions(-) > create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h > [snip] > diff --git a/drivers/soc/mediatek/mtk-mmsys.c > b/drivers/soc/mediatek/mtk-mmsys.c > index 4fc4c2c9ea20..b2fa239c5f5f 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -4,6 +4,8 @@ > * Author: James Liao > */ > > +#include > +#include > #include > #include > #include > @@ -17,6 +19,7 @@ > #include "mt8183-mmsys.h" > #include "mt8186-mmsys.h" > #include "mt8192-mmsys.h" > +#include "mt8195-mmsys.h" > #include "mt8365-mmsys.h" > > static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = > { > @@ -72,12 +75,24 @@ static const struct mtk_mmsys_driver_data > mt8192_mmsys_driver_data = { > .num_routes = ARRAY_SIZE(mmsys_mt8192_routing_table), > }; > > +static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data > = { > + .clk_name = "cfg_vdo0", > + .clk_driver = "clk-mt8195-vdo0", > + .routes = mmsys_mt8195_routing_table, > + .num_routes = ARRAY_SIZE(mmsys_mt8195_routing_table), > +}; > + > static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = > { > .clk_driver = "clk-mt8365-mm", > .routes = mt8365_mmsys_routing_table, > .num_routes = ARRAY_SIZE(mt8365_mmsys_routing_table), > }; > > +static const struct of_device_id mtk_clk_platform_labels[] = { > + { .compatible = "mediatek,mt8195-mmsys", > + .data = (void *)"clk-mt8195"}, > +}; > + > struct mtk_mmsys { > void __iomem *regs; > const struct mtk_mmsys_driver_data *data; > @@ -85,6 +100,45 @@ struct mtk_mmsys { > struct reset_controller_dev rcdev; > }; > > +static int mtk_mmsys_get_match_data_by_clk_name(const struct > mtk_mmsys_driver_data **data, > + struct device *dev) > +{ > + int i; > + struct clk *clk; > + const char *clk_name; > + const struct of_device_id *of_id = > of_match_node(mtk_clk_platform_labels, > + dev->of_node); > + const struct mtk_mmsys_driver_data *drvdata[] = { > + &mt8195_vdosys0_driver_data, > + }; > + > + if (!of_id || !of_id->data) { > + dev_err(dev, "Can't find match clk platform labels\n"); > + return -EINVAL; > + } > + > + clk = devm_clk_get(dev, NULL); > + if (IS_ERR(clk)) { > + dev_err(dev, "failed to get mmsys clk\n"); > + return PTR_ERR(clk); > + } > + > + clk_name = __clk_get_name(clk); > + if (!clk_name) { > + dev_err(dev, "invalid mmsys clk name\n"); > + return -EINVAL; > + } > + > + for (i = 0; i < ARRAY_SIZE(drvdata); i++) > + if (strncmp(drvdata[i]->clk_name, clk_name, > strlen(clk_name)) == 0 && > + strncmp(drvdata[i]->clk_driver, of_id->data, > strlen(of_id->data)) == 0) { I think clk_name is enough to identify the mmsys, why do you need clk_driver? > + *data = drvdata[i]; > + return 0; > + } > + > + return -EINVAL; > +} > + > void mtk_mmsys_ddp_connect(struct device *dev, > enum mtk_ddp_comp_id cur, > enum mtk_ddp_comp_id next) > @@ -206,6 +260,11 @@ static int mtk_mmsys_probe(struct > platform_device *pdev) > } > > mmsys->data = of_device_get_match_data(&pdev->dev); > + if (!mmsys->data && > mtk_mmsys_get_match_data_by_clk_name(&mmsys->data, dev) < 0) { > + dev_err(dev, "Couldn't get match driver data\n"); > + return -EINVAL; > + } > + > platform_set_drvdata(pdev, mmsys); > > clks = platform_device_register_data(&pdev->dev, mmsys->data- > >clk_driver, > @@ -260,6 +319,9 @@ static const struct of_device_id > of_match_mtk_mmsys[] = { > .compatible = "mediatek,mt8192-mmsys", > .data = &mt8192_mmsys_driver_data, > }, > + { > + .compatible = "mediatek,mt8195-mmsys", > + }, > { > .compatible = "mediatek,mt8365-mmsys", > .data = &mt8365_mmsys_driver_data, > [snip] > b/include/linux/soc/mediatek/mtk-mmsys.h > index 4bba275e235a..fb719fd1281c 100644 > --- a/include/linux/soc/mediatek/mtk-mmsys.h > +++ b/include/linux/soc/mediatek/mtk-mmsys.h > @@ -16,14 +16,25 @@ enum mtk_ddp_comp_id { > DDP_COMPONENT_CCORR, > DDP_COMPONENT_COLOR0, > DDP_COMPONENT_COLOR1, > - DDP_COMPONENT_DITHER, > + DDP_COMPONENT_DITHER0, I would like soc and drm modification to go through different tree, so this setting would not modify drm driver in this patch. DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER, Then modify drm driver after this patch. Regards, CK > + DDP_COMPONENT_DITHER1, > + DDP_COMPONENT_DP_INTF0, > + DDP_COMPONENT_DP_INTF1, > DDP_COMPONENT_DPI0, > DDP_COMPONENT_DPI1, > + DDP_COMPONENT_DSC0, > + DDP_COMPONENT_DSC1, > DDP_COMPONENT_DSI0, > DDP_COMPONENT_DSI1, > DDP_COMPONENT_DSI2, > DDP_COMPONENT_DSI3, > DDP_COMPONENT_GAMMA, > + DDP_COMPONENT_MERGE0, > + DDP_COMPONENT_MERGE1, > + DDP_COMPONENT_MERGE2, > + DDP_COMPONENT_MERGE3, > + DDP_COMPONENT_MERGE4, > + DDP_COMPONENT_MERGE5, > DDP_COMPONENT_OD0, > DDP_COMPONENT_OD1, > DDP_COMPONENT_OVL0, _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 645F6C433EF for ; Thu, 7 Apr 2022 05:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YcpkW//Bo4XZcx9i16JhUbMzwReZASl6XwyQR93fH9w=; b=VXdiaCRQxdOlgJ JpocpzbjkQ2Q/1LB+m91Y9ZbXdU249Ko31floXnBpfRUpBwdk0Ib33GsPEwI/wsMWj5zeU0vdfvIM fGWxiA5x6at9kjTm0CbgVARdvqWG4SDhYAVTqqehQyID/ejRhovvivFKvZT2dlfVRoLhis/H4u3/w I5Ku1J8/Dx17yCusReiMfPGpNv7AXoIUBH49+Dqhl4YMCX9oyUpG1T68mQvMoeznxsSEDsrm6K18B o68CoxG+zKXlvUcyYeDAFqiuoqApvcoifCGYPaW60v2jh5ohsBdShwBuOxjzeAogq124XPHxdBdz8 MJ7apShybTS05weY6D5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncL32-009b8b-0X; Thu, 07 Apr 2022 05:51:12 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncL2u-009b80-GM; Thu, 07 Apr 2022 05:51:09 +0000 X-UUID: 429e3728ff9549ee9ab8d5395758afc3-20220406 X-UUID: 429e3728ff9549ee9ab8d5395758afc3-20220406 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 496724877; Wed, 06 Apr 2022 22:51:00 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Apr 2022 22:46:03 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 Apr 2022 13:45:56 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 7 Apr 2022 13:45:55 +0800 Message-ID: <67b3e42d6a094108f724ed9b8c73f5cd6b2ce219.camel@mediatek.com> Subject: Re: [RESEND v17 3/7] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 From: CK Hu To: jason-jh.lin , Rob Herring , Matthias Brugger , "Chun-Kuang Hu" , AngeloGioacchino Del Regno CC: David Airlie , , "Alexandre Torgue" , , "Fabien Parent" , John 'Warthog9' Hawley , , , , Philipp Zabel , , Daniel Vetter , , , , , , , Maxime Coquelin Date: Thu, 7 Apr 2022 13:45:55 +0800 In-Reply-To: <20220407030409.9664-4-jason-jh.lin@mediatek.com> References: <20220407030409.9664-1-jason-jh.lin@mediatek.com> <20220407030409.9664-4-jason-jh.lin@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_225104_597692_C1826DDA X-CRM114-Status: GOOD ( 30.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Jason: On Thu, 2022-04-07 at 11:04 +0800, jason-jh.lin wrote: > 1. Add mt8195 mmsys compatible for vdosys0. > 2. Add mt8195 routing table settings and fix build fail. > 3. Add clock name, clock driver name and routing table into the > driver data > of mt8195 vdosys0. > 4. Add get match data by clock name function and clock platform > labels > to identify which mmsys node is corresponding to vdosys0. > > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +- > drivers/soc/mediatek/mt8167-mmsys.h | 2 +- > drivers/soc/mediatek/mt8183-mmsys.h | 2 +- > drivers/soc/mediatek/mt8186-mmsys.h | 4 +- > drivers/soc/mediatek/mt8192-mmsys.h | 4 +- > drivers/soc/mediatek/mt8195-mmsys.h | 370 > ++++++++++++++++++++ > drivers/soc/mediatek/mt8365-mmsys.h | 4 +- > drivers/soc/mediatek/mtk-mmsys.c | 62 ++++ > drivers/soc/mediatek/mtk-mmsys.h | 1 + > drivers/soc/mediatek/mtk-mutex.c | 8 +- > include/linux/soc/mediatek/mtk-mmsys.h | 13 +- > 12 files changed, 461 insertions(+), 17 deletions(-) > create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h > [snip] > diff --git a/drivers/soc/mediatek/mtk-mmsys.c > b/drivers/soc/mediatek/mtk-mmsys.c > index 4fc4c2c9ea20..b2fa239c5f5f 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -4,6 +4,8 @@ > * Author: James Liao > */ > > +#include > +#include > #include > #include > #include > @@ -17,6 +19,7 @@ > #include "mt8183-mmsys.h" > #include "mt8186-mmsys.h" > #include "mt8192-mmsys.h" > +#include "mt8195-mmsys.h" > #include "mt8365-mmsys.h" > > static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = > { > @@ -72,12 +75,24 @@ static const struct mtk_mmsys_driver_data > mt8192_mmsys_driver_data = { > .num_routes = ARRAY_SIZE(mmsys_mt8192_routing_table), > }; > > +static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data > = { > + .clk_name = "cfg_vdo0", > + .clk_driver = "clk-mt8195-vdo0", > + .routes = mmsys_mt8195_routing_table, > + .num_routes = ARRAY_SIZE(mmsys_mt8195_routing_table), > +}; > + > static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = > { > .clk_driver = "clk-mt8365-mm", > .routes = mt8365_mmsys_routing_table, > .num_routes = ARRAY_SIZE(mt8365_mmsys_routing_table), > }; > > +static const struct of_device_id mtk_clk_platform_labels[] = { > + { .compatible = "mediatek,mt8195-mmsys", > + .data = (void *)"clk-mt8195"}, > +}; > + > struct mtk_mmsys { > void __iomem *regs; > const struct mtk_mmsys_driver_data *data; > @@ -85,6 +100,45 @@ struct mtk_mmsys { > struct reset_controller_dev rcdev; > }; > > +static int mtk_mmsys_get_match_data_by_clk_name(const struct > mtk_mmsys_driver_data **data, > + struct device *dev) > +{ > + int i; > + struct clk *clk; > + const char *clk_name; > + const struct of_device_id *of_id = > of_match_node(mtk_clk_platform_labels, > + dev->of_node); > + const struct mtk_mmsys_driver_data *drvdata[] = { > + &mt8195_vdosys0_driver_data, > + }; > + > + if (!of_id || !of_id->data) { > + dev_err(dev, "Can't find match clk platform labels\n"); > + return -EINVAL; > + } > + > + clk = devm_clk_get(dev, NULL); > + if (IS_ERR(clk)) { > + dev_err(dev, "failed to get mmsys clk\n"); > + return PTR_ERR(clk); > + } > + > + clk_name = __clk_get_name(clk); > + if (!clk_name) { > + dev_err(dev, "invalid mmsys clk name\n"); > + return -EINVAL; > + } > + > + for (i = 0; i < ARRAY_SIZE(drvdata); i++) > + if (strncmp(drvdata[i]->clk_name, clk_name, > strlen(clk_name)) == 0 && > + strncmp(drvdata[i]->clk_driver, of_id->data, > strlen(of_id->data)) == 0) { I think clk_name is enough to identify the mmsys, why do you need clk_driver? > + *data = drvdata[i]; > + return 0; > + } > + > + return -EINVAL; > +} > + > void mtk_mmsys_ddp_connect(struct device *dev, > enum mtk_ddp_comp_id cur, > enum mtk_ddp_comp_id next) > @@ -206,6 +260,11 @@ static int mtk_mmsys_probe(struct > platform_device *pdev) > } > > mmsys->data = of_device_get_match_data(&pdev->dev); > + if (!mmsys->data && > mtk_mmsys_get_match_data_by_clk_name(&mmsys->data, dev) < 0) { > + dev_err(dev, "Couldn't get match driver data\n"); > + return -EINVAL; > + } > + > platform_set_drvdata(pdev, mmsys); > > clks = platform_device_register_data(&pdev->dev, mmsys->data- > >clk_driver, > @@ -260,6 +319,9 @@ static const struct of_device_id > of_match_mtk_mmsys[] = { > .compatible = "mediatek,mt8192-mmsys", > .data = &mt8192_mmsys_driver_data, > }, > + { > + .compatible = "mediatek,mt8195-mmsys", > + }, > { > .compatible = "mediatek,mt8365-mmsys", > .data = &mt8365_mmsys_driver_data, > [snip] > b/include/linux/soc/mediatek/mtk-mmsys.h > index 4bba275e235a..fb719fd1281c 100644 > --- a/include/linux/soc/mediatek/mtk-mmsys.h > +++ b/include/linux/soc/mediatek/mtk-mmsys.h > @@ -16,14 +16,25 @@ enum mtk_ddp_comp_id { > DDP_COMPONENT_CCORR, > DDP_COMPONENT_COLOR0, > DDP_COMPONENT_COLOR1, > - DDP_COMPONENT_DITHER, > + DDP_COMPONENT_DITHER0, I would like soc and drm modification to go through different tree, so this setting would not modify drm driver in this patch. DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER, Then modify drm driver after this patch. Regards, CK > + DDP_COMPONENT_DITHER1, > + DDP_COMPONENT_DP_INTF0, > + DDP_COMPONENT_DP_INTF1, > DDP_COMPONENT_DPI0, > DDP_COMPONENT_DPI1, > + DDP_COMPONENT_DSC0, > + DDP_COMPONENT_DSC1, > DDP_COMPONENT_DSI0, > DDP_COMPONENT_DSI1, > DDP_COMPONENT_DSI2, > DDP_COMPONENT_DSI3, > DDP_COMPONENT_GAMMA, > + DDP_COMPONENT_MERGE0, > + DDP_COMPONENT_MERGE1, > + DDP_COMPONENT_MERGE2, > + DDP_COMPONENT_MERGE3, > + DDP_COMPONENT_MERGE4, > + DDP_COMPONENT_MERGE5, > DDP_COMPONENT_OD0, > DDP_COMPONENT_OD1, > DDP_COMPONENT_OVL0, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel