From: Sohil Mehta <sohil.mehta@intel.com>
To: Avadhut Naik <avadhut.naik@amd.com>,
<linux-trace-kernel@vger.kernel.org>,
<linux-edac@vger.kernel.org>
Cc: <rostedt@goodmis.org>, <tony.luck@intel.com>, <bp@alien8.de>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<yazen.ghannam@amd.com>, <avadnaik@amd.com>
Subject: Re: [PATCH v4 2/2] tracing: Include Microcode Revision in mce_record tracepoint
Date: Wed, 27 Mar 2024 15:31:01 -0700 [thread overview]
Message-ID: <67ba2ece-6b46-4ae1-a944-a38f84360d0f@intel.com> (raw)
In-Reply-To: <20240327205435.3667588-3-avadhut.naik@amd.com>
On 3/27/2024 1:54 PM, Avadhut Naik wrote:
> - TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x",
> + TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x, MICROCODE REVISION: %x",
Nit: s/MICROCODE REVISION/MICROCODE/g
You could probably get rid of the word REVISION in the interest of
brevity similar to __print_mce().
pr_emerg(HW_ERR "PROCESSOR %u:%x TIME %llu SOCKET %u APIC %x microcode
%x\n",
m->cpuvendor, m->cpuid, m->time, m->socketid, m->apicid,
m->microcode);
-Sohil
next prev parent reply other threads:[~2024-03-27 22:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 20:54 [PATCH v4 0/2] Update mce_record tracepoint Avadhut Naik
2024-03-27 20:54 ` [PATCH v4 1/2] tracing: Include PPIN in " Avadhut Naik
2024-03-27 20:59 ` Luck, Tony
2024-03-27 20:54 ` [PATCH v4 2/2] tracing: Include Microcode Revision " Avadhut Naik
2024-03-27 21:00 ` Luck, Tony
2024-03-27 22:31 ` Sohil Mehta [this message]
2024-03-27 22:35 ` Borislav Petkov
2024-03-28 1:52 ` Sohil Mehta
2024-03-28 6:17 ` Naik, Avadhut
2024-03-28 15:44 ` Borislav Petkov
2024-03-28 6:16 ` Naik, Avadhut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67ba2ece-6b46-4ae1-a944-a38f84360d0f@intel.com \
--to=sohil.mehta@intel.com \
--cc=avadhut.naik@amd.com \
--cc=avadnaik@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.