All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Johansson via <qemu-devel@nongnu.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>
Cc: ale@rev.ng, tsimpson@quicinc.com, bcain@quicinc.com,
	mlambert@quicinc.com, babush@rev.ng, nizzo@rev.ng,
	qemu-devel@nongnu.org, "Daniel P.Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v9 08/12] target/hexagon: import flex/bison to docker files
Date: Wed, 25 May 2022 22:14:17 +0200	[thread overview]
Message-ID: <67c27109-2bb4-7147-ab7d-215b6b03b4cf@rev.ng> (raw)
In-Reply-To: <87czg11s8w.fsf@linaro.org>

On 5/25/22 18:38, Alex Bennée wrote:

> Richard Henderson <richard.henderson@linaro.org> writes:
>
>> On 5/25/22 05:29, Anton Johansson wrote:
>>> For clarity's sake, here are the exact steps taken to produce this patch:
>>>       1. Update QEMU's libvirt-ci to the commit
>>> https://gitlab.com/libvirt/libvirt-ci/-/commit/43927ff508e8ecb1ac225dabbc95b37c890db917
>>>          which adds flex/bison, and a native glib2 (required since
>>> idef-parser
>>>          is a build-time tool.)
>> This must be split out -- submodule updates should be a patch by
>> themselves.  Otherwise it can look like unintentional rebase breakage
>> (which, sadly, happens more often than legitimate submodule updates).
>>
>>>       2. Copy in new `tests/lcitool/projects/qemu.yml` from `libvirt-ci`
>>>       3. run `tests/lcitool/refresh` to generate new docker/cirrus
>>> files
>> And, yes, having one patch that's simply auto-generated is helpful.
> To quote danpb:
>
>     danpb: should our tests/lcitool/projects/qemu.yml match the one in
>        the lcitool repo or are they different use cases?
>    <danpb> the one in libvirt-ci.git should be deleted really
>    <danpb> the one in qemu.git is the source of truth
>
> so please just update the qemu.git qemu.yml for just what you need for
> flex/bison without bringing in all the other (stale?) stuff.
>
>
>>
>> r~
>
I see, thanks!

Just to make sure I understood you correctly, I should:

     1. Make a standalone patch that updates libvirt-ci and runs
         the refresh script, in case any package mappings changed

     2. Change this patch to add flex/bison to QEMU's qemu.yml,
         and run refresh

-- 
Anton Johansson,
rev.ng Labs Srl.



  reply	other threads:[~2022-05-25 20:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 17:40 [PATCH v9 00/12] target/hexagon: introduce idef-parser Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 01/12] target/hexagon: update MAINTAINERS for idef-parser Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 02/12] target/hexagon: import README " Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 03/12] target/hexagon: make slot number an unsigned Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 04/12] target/hexagon: make helper functions non-static Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 05/12] target/hexagon: introduce new helper functions Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 06/12] target/hexagon: expose next PC in DisasContext Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 07/12] target/hexagon: prepare input for the idef-parser Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 08/12] target/hexagon: import flex/bison to docker files Anton Johansson via
2022-05-24 10:07   ` Alex Bennée
2022-05-25 12:29     ` Anton Johansson via
2022-05-25 15:22       ` Richard Henderson
2022-05-25 16:38         ` Alex Bennée
2022-05-25 20:14           ` Anton Johansson via [this message]
2022-05-25 20:16             ` Richard Henderson
2022-05-25 20:27               ` Anton Johansson via
2022-05-25 21:05                 ` Richard Henderson
2022-04-22 17:40 ` [PATCH v9 09/12] target/hexagon: import lexer for idef-parser Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 10/12] target/hexagon: import parser " Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 11/12] target/hexagon: call idef-parser functions Anton Johansson via
2022-04-22 17:40 ` [PATCH v9 12/12] target/hexagon: import additional tests Anton Johansson via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67c27109-2bb4-7147-ab7d-215b6b03b4cf@rev.ng \
    --to=qemu-devel@nongnu.org \
    --cc=ale@rev.ng \
    --cc=alex.bennee@linaro.org \
    --cc=anjo@rev.ng \
    --cc=babush@rev.ng \
    --cc=bcain@quicinc.com \
    --cc=berrange@redhat.com \
    --cc=mlambert@quicinc.com \
    --cc=nizzo@rev.ng \
    --cc=richard.henderson@linaro.org \
    --cc=tsimpson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.