From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH 3/3] drm/udl: Switch to SHMEM Date: Wed, 6 Nov 2019 09:22:25 +0100 Message-ID: <67c86556-9b8e-3bb8-161b-754f63d25d8d@suse.de> References: <20191028084549.30243-1-tzimmermann@suse.de> <20191028084549.30243-4-tzimmermann@suse.de> <20191105110521.zwv35ihnqlmwla3u@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0461102253==" Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1D306E1A3 for ; Wed, 6 Nov 2019 08:22:27 +0000 (UTC) In-Reply-To: <20191105110521.zwv35ihnqlmwla3u@sirius.home.kraxel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: sean@poorly.run, dri-devel@lists.freedesktop.org, airlied@redhat.com, sam@ravnborg.org, emil.velikov@collabora.com List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0461102253== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EsEcsv8h5FPJnCPIlzxPFa75xeZFCf5Qn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EsEcsv8h5FPJnCPIlzxPFa75xeZFCf5Qn Content-Type: multipart/mixed; boundary="9VaQpgqdZ11wloREsGVKwx4d3q6XytsSQ"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann Cc: airlied@redhat.com, sean@poorly.run, daniel@ffwll.ch, noralf@tronnes.org, sam@ravnborg.org, emil.velikov@collabora.com, dri-devel@lists.freedesktop.org Message-ID: <67c86556-9b8e-3bb8-161b-754f63d25d8d@suse.de> Subject: Re: [PATCH 3/3] drm/udl: Switch to SHMEM References: <20191028084549.30243-1-tzimmermann@suse.de> <20191028084549.30243-4-tzimmermann@suse.de> <20191105110521.zwv35ihnqlmwla3u@sirius.home.kraxel.org> In-Reply-To: <20191105110521.zwv35ihnqlmwla3u@sirius.home.kraxel.org> --9VaQpgqdZ11wloREsGVKwx4d3q6XytsSQ Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 05.11.19 um 12:05 schrieb Gerd Hoffmann: > On Mon, Oct 28, 2019 at 09:45:49AM +0100, Thomas Zimmermann wrote: >> Udl's GEM code and the generic SHMEM are almost identical. Replace >> the former with SHMEM. The dmabuf support in udl is being removed >> in favor of the generic GEM PRIME functions. >> >> The main difference is in the caching flags for mmap pages. By >> default, SHMEM always sets (uncached) write combining. In udl's >> memory management code, only imported buffers use write combining. >> Memory pages of locally created buffer objects are mmap'ed with >> caching enabled. To keep the optimization, udl provides its own >> mmap function for GEM objects where it fixes up the mapping flags. >=20 > Hmm, couldn't spot anything wrong, but it's rather hard to see the > actual changes here ... >=20 > Any chance that having a separate "remove all dead code obsoleted by > shmem helpers" patch helps? Let me see what I can do. Best regards Thomas >=20 > cheers, > Gerd >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=FCrnberg, Germany (HRB 36809, AG N=FCrnberg) Gesch=E4ftsf=FChrer: Felix Imend=F6rffer --9VaQpgqdZ11wloREsGVKwx4d3q6XytsSQ-- --EsEcsv8h5FPJnCPIlzxPFa75xeZFCf5Qn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl3CgsEACgkQaA3BHVML eiNpNAgApsStL+y7JH90+0+DpBCj4aDT8/gUUUs44FWLjSQr4vkT2ifTL+5GZyg3 oX0QFXE3KUR7rn3L4U3JamYqX04FBzolBrz7O+3Fju8mJGS4NfKBqofy9nrAZ6V2 zonoWQ+tvRsounkQ9GfSDWTbY7+1V5OW2CPQzqxwaKElHoZEZL7+c/IxcypmPG66 oc7QTP9LSVeaOv2gCc0w/z07G4f83qC6AylJggjH6OgfNx268bM4tU6UyXKzepwX HMV/yMdY6g8wX+PyFvYeGxulmYVGUKLZquRpYiP3Tre+1ekkj1v8J8fexIZR+Aak hvJrHPFearEyanqjWxItgn073F6fyQ== =2IJr -----END PGP SIGNATURE----- --EsEcsv8h5FPJnCPIlzxPFa75xeZFCf5Qn-- --===============0461102253== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0461102253==--