From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 654BBC433C1 for ; Tue, 23 Mar 2021 23:21:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BBEB619DD for ; Tue, 23 Mar 2021 23:21:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234264AbhCWXVY (ORCPT ); Tue, 23 Mar 2021 19:21:24 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2736 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234257AbhCWXVP (ORCPT ); Tue, 23 Mar 2021 19:21:15 -0400 Received: from fraeml713-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4F4nLN6999z681yy; Wed, 24 Mar 2021 07:16:28 +0800 (CST) Received: from lhreml721-chm.china.huawei.com (10.201.108.72) by fraeml713-chm.china.huawei.com (10.206.15.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 00:21:13 +0100 Received: from dggemi761-chm.china.huawei.com (10.1.198.147) by lhreml721-chm.china.huawei.com (10.201.108.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 23:21:11 +0000 Received: from dggemi761-chm.china.huawei.com ([10.9.49.202]) by dggemi761-chm.china.huawei.com ([10.9.49.202]) with mapi id 15.01.2106.013; Wed, 24 Mar 2021 07:21:09 +0800 From: "Song Bao Hua (Barry Song)" To: Tim Chen , "catalin.marinas@arm.com" , "will@kernel.org" , "rjw@rjwysocki.net" , "vincent.guittot@linaro.org" , "bp@alien8.de" , "tglx@linutronix.de" , "mingo@redhat.com" , "lenb@kernel.org" , "peterz@infradead.org" , "dietmar.eggemann@arm.com" , "rostedt@goodmis.org" , "bsegall@google.com" , "mgorman@suse.de" CC: "msys.mizuma@gmail.com" , "valentin.schneider@arm.com" , "gregkh@linuxfoundation.org" , Jonathan Cameron , "juri.lelli@redhat.com" , "mark.rutland@arm.com" , "sudeep.holla@arm.com" , "aubrey.li@linux.intel.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "x86@kernel.org" , "xuwei (O)" , "Zengtao (B)" , "guodong.xu@linaro.org" , yangyicong , "Liguozhu (Kenneth)" , "linuxarm@openeuler.org" , "hpa@zytor.com" Subject: RE: [RFC PATCH v5 4/4] scheduler: Add cluster scheduler level for x86 Thread-Topic: [RFC PATCH v5 4/4] scheduler: Add cluster scheduler level for x86 Thread-Index: AQHXHHecEK2PZNeGJ0y0ASUDVCEuNqqRruSAgACLbJA= Date: Tue, 23 Mar 2021 23:21:09 +0000 Message-ID: <67cc380019fd40d88d7a493b6cbc0852@hisilicon.com> References: <20210319041618.14316-1-song.bao.hua@hisilicon.com> <20210319041618.14316-5-song.bao.hua@hisilicon.com> <110234d1-22ce-8a9a-eabb-c15ac29a5dcd@linux.intel.com> In-Reply-To: <110234d1-22ce-8a9a-eabb-c15ac29a5dcd@linux.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.201.12] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogVGltIENoZW4gW21haWx0 bzp0aW0uYy5jaGVuQGxpbnV4LmludGVsLmNvbV0NCj4gU2VudDogV2VkbmVzZGF5LCBNYXJjaCAy NCwgMjAyMSAxMTo1MSBBTQ0KPiBUbzogU29uZyBCYW8gSHVhIChCYXJyeSBTb25nKSA8c29uZy5i YW8uaHVhQGhpc2lsaWNvbi5jb20+Ow0KPiBjYXRhbGluLm1hcmluYXNAYXJtLmNvbTsgd2lsbEBr ZXJuZWwub3JnOyByandAcmp3eXNvY2tpLm5ldDsNCj4gdmluY2VudC5ndWl0dG90QGxpbmFyby5v cmc7IGJwQGFsaWVuOC5kZTsgdGdseEBsaW51dHJvbml4LmRlOw0KPiBtaW5nb0ByZWRoYXQuY29t OyBsZW5iQGtlcm5lbC5vcmc7IHBldGVyekBpbmZyYWRlYWQub3JnOw0KPiBkaWV0bWFyLmVnZ2Vt YW5uQGFybS5jb207IHJvc3RlZHRAZ29vZG1pcy5vcmc7IGJzZWdhbGxAZ29vZ2xlLmNvbTsNCj4g bWdvcm1hbkBzdXNlLmRlDQo+IENjOiBtc3lzLm1penVtYUBnbWFpbC5jb207IHZhbGVudGluLnNj aG5laWRlckBhcm0uY29tOw0KPiBncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZzsgSm9uYXRoYW4g Q2FtZXJvbiA8am9uYXRoYW4uY2FtZXJvbkBodWF3ZWkuY29tPjsNCj4ganVyaS5sZWxsaUByZWRo YXQuY29tOyBtYXJrLnJ1dGxhbmRAYXJtLmNvbTsgc3VkZWVwLmhvbGxhQGFybS5jb207DQo+IGF1 YnJleS5saUBsaW51eC5pbnRlbC5jb207IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZzsNCj4gbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGludXgtYWNwaUB2Z2VyLmtl cm5lbC5vcmc7IHg4NkBrZXJuZWwub3JnOw0KPiB4dXdlaSAoTykgPHh1d2VpNUBodWF3ZWkuY29t PjsgWmVuZ3RhbyAoQikgPHByaW1lLnplbmdAaGlzaWxpY29uLmNvbT47DQo+IGd1b2RvbmcueHVA bGluYXJvLm9yZzsgeWFuZ3lpY29uZyA8eWFuZ3lpY29uZ0BodWF3ZWkuY29tPjsgTGlndW96aHUg KEtlbm5ldGgpDQo+IDxsaWd1b3podUBoaXNpbGljb24uY29tPjsgbGludXhhcm1Ab3BlbmV1bGVy Lm9yZzsgaHBhQHp5dG9yLmNvbQ0KPiBTdWJqZWN0OiBSZTogW1JGQyBQQVRDSCB2NSA0LzRdIHNj aGVkdWxlcjogQWRkIGNsdXN0ZXIgc2NoZWR1bGVyIGxldmVsIGZvciB4ODYNCj4gDQo+IA0KPiAN Cj4gT24gMy8xOC8yMSA5OjE2IFBNLCBCYXJyeSBTb25nIHdyb3RlOg0KPiA+IEZyb206IFRpbSBD aGVuIDx0aW0uYy5jaGVuQGxpbnV4LmludGVsLmNvbT4NCj4gPg0KPiA+IFRoZXJlIGFyZSB4ODYg Q1BVIGFyY2hpdGVjdHVyZXMgKGUuZy4gSmFjb2JzdmlsbGUpIHdoZXJlIEwyIGNhaGNlDQo+ID4g aXMgc2hhcmVkIGFtb25nIGEgY2x1c3RlciBvZiBjb3JlcyBpbnN0ZWFkIG9mIGJlaW5nIGV4Y2x1 c2l2ZQ0KPiA+IHRvIG9uZSBzaW5nbGUgY29yZS4NCj4gPg0KPiA+IFRvIHByZXZlbnQgb3ZlcnN1 YnNjcmlwdGlvbiBvZiBMMiBjYWNoZSwgbG9hZCBzaG91bGQgYmUNCj4gPiBiYWxhbmNlZCBiZXR3 ZWVuIHN1Y2ggTDIgY2x1c3RlcnMsIGVzcGVjaWFsbHkgZm9yIHRhc2tzIHdpdGgNCj4gPiBubyBz aGFyZWQgZGF0YS4NCj4gPg0KPiA+IEFsc28gd2l0aCBjbHVzdGVyIHNjaGVkdWxpbmcgcG9saWN5 IHdoZXJlIHRhc2tzIGFyZSB3b2tlbiB1cA0KPiA+IGluIHRoZSBzYW1lIEwyIGNsdXN0ZXIsIHdl IHdpbGwgYmVuZWZpdCBmcm9tIGtlZXBpbmcgdGFza3MNCj4gPiByZWxhdGVkIHRvIGVhY2ggb3Ro ZXIgYW5kIGxpa2VseSBzaGFyaW5nIGRhdGEgaW4gdGhlIHNhbWUgTDINCj4gPiBjbHVzdGVyLg0K PiA+DQo+ID4gQWRkIENQVSBtYXNrcyBvZiBDUFVzIHNoYXJpbmcgdGhlIEwyIGNhY2hlIHNvIHdl IGNhbiBidWlsZCBzdWNoDQo+ID4gTDIgY2x1c3RlciBzY2hlZHVsZXIgZG9tYWluLg0KPiA+DQo+ ID4gU2lnbmVkLW9mZi1ieTogVGltIENoZW4gPHRpbS5jLmNoZW5AbGludXguaW50ZWwuY29tPg0K PiA+IFNpZ25lZC1vZmYtYnk6IEJhcnJ5IFNvbmcgPHNvbmcuYmFvLmh1YUBoaXNpbGljb24uY29t Pg0KPiANCj4gDQo+IEJhcnJ5LA0KPiANCj4gQ2FuIHlvdSBhbHNvIGFkZCB0aGlzIGNodW5rIHRv IHRoZSBwYXRjaC4NCj4gVGhhbmtzLg0KDQpTdXJlLCBUaW0sIFRoYW5rcy4gSSdsbCBwdXQgdGhh dCBpbnRvIHBhdGNoIDQvNCBpbiB2Ni4NCg0KPiANCj4gVGltDQo+IA0KPiANCj4gZGlmZiAtLWdp dCBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3RvcG9sb2d5LmgNCj4gYi9hcmNoL3g4Ni9pbmNsdWRl L2FzbS90b3BvbG9neS5oDQo+IGluZGV4IDJhMTFjY2MxNGZiMS4uODAwZmE0OGM5ZmNkIDEwMDY0 NA0KPiAtLS0gYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS90b3BvbG9neS5oDQo+ICsrKyBiL2FyY2gv eDg2L2luY2x1ZGUvYXNtL3RvcG9sb2d5LmgNCj4gQEAgLTExNSw2ICsxMTUsNyBAQCBleHRlcm4g dW5zaWduZWQgaW50IF9fbWF4X2RpZV9wZXJfcGFja2FnZTsNCj4gDQo+ICAjaWZkZWYgQ09ORklH X1NNUA0KPiAgI2RlZmluZSB0b3BvbG9neV9kaWVfY3B1bWFzayhjcHUpCQkocGVyX2NwdShjcHVf ZGllX21hcCwgY3B1KSkNCj4gKyNkZWZpbmUgdG9wb2xvZ3lfY2x1c3Rlcl9jcHVtYXNrKGNwdSkJ CShjcHVfY2x1c3Rlcmdyb3VwX21hc2soY3B1KSkNCj4gICNkZWZpbmUgdG9wb2xvZ3lfY29yZV9j cHVtYXNrKGNwdSkJCShwZXJfY3B1KGNwdV9jb3JlX21hcCwgY3B1KSkNCj4gICNkZWZpbmUgdG9w b2xvZ3lfc2libGluZ19jcHVtYXNrKGNwdSkJCShwZXJfY3B1KGNwdV9zaWJsaW5nX21hcCwgY3B1 KSkNCj4gDQoNClRoYW5rcw0KQmFycnkNCg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2F6C433C1 for ; Tue, 23 Mar 2021 23:23:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AB93600CD for ; Tue, 23 Mar 2021 23:23:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AB93600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CHV553EvlACGMwulAi0jb7la/3yTEkRz4IHpGPiXleE=; b=XLH1LNAJLOSkMLj0RHoM+a8Sn A1a19hmU+wSwnEPQpyTlSOqKIM0Wmq8Vxde5UGMnOM7vuNYA+1wti+YEAOMKuLz5j1NBPYnuShb19 ugJEAfhEULUdYfjJX0RP1yleB3mrHVgxabQWpTI0MgWIrZlJrUqxTU4f6jOgjv9gb0Dapkuo3gSH9 8ts76qnBxVuQD0TR8EvX/q1tR4WVP5wlCtP3cHHYlLLirUgBLNyzLarSJ6zoXRYwm3CwVoLpGsFAF I1ua4kJLmS/KQz0gI7x7Qq7yJCEWx7KUlx1r48T8MpYeL/46oT5B3/SLEnnNCGcA0CLq0ZZdX0Cwb CY5w2EJ4g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOqKy-00FypN-11; Tue, 23 Mar 2021 23:21:24 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOqKr-00FyoX-HO for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 23:21:20 +0000 Received: from fraeml713-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4F4nLN6999z681yy; Wed, 24 Mar 2021 07:16:28 +0800 (CST) Received: from lhreml721-chm.china.huawei.com (10.201.108.72) by fraeml713-chm.china.huawei.com (10.206.15.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 00:21:13 +0100 Received: from dggemi761-chm.china.huawei.com (10.1.198.147) by lhreml721-chm.china.huawei.com (10.201.108.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 23:21:11 +0000 Received: from dggemi761-chm.china.huawei.com ([10.9.49.202]) by dggemi761-chm.china.huawei.com ([10.9.49.202]) with mapi id 15.01.2106.013; Wed, 24 Mar 2021 07:21:09 +0800 From: "Song Bao Hua (Barry Song)" To: Tim Chen , "catalin.marinas@arm.com" , "will@kernel.org" , "rjw@rjwysocki.net" , "vincent.guittot@linaro.org" , "bp@alien8.de" , "tglx@linutronix.de" , "mingo@redhat.com" , "lenb@kernel.org" , "peterz@infradead.org" , "dietmar.eggemann@arm.com" , "rostedt@goodmis.org" , "bsegall@google.com" , "mgorman@suse.de" CC: "msys.mizuma@gmail.com" , "valentin.schneider@arm.com" , "gregkh@linuxfoundation.org" , Jonathan Cameron , "juri.lelli@redhat.com" , "mark.rutland@arm.com" , "sudeep.holla@arm.com" , "aubrey.li@linux.intel.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "x86@kernel.org" , "xuwei (O)" , "Zengtao (B)" , "guodong.xu@linaro.org" , yangyicong , "Liguozhu (Kenneth)" , "linuxarm@openeuler.org" , "hpa@zytor.com" Subject: RE: [RFC PATCH v5 4/4] scheduler: Add cluster scheduler level for x86 Thread-Topic: [RFC PATCH v5 4/4] scheduler: Add cluster scheduler level for x86 Thread-Index: AQHXHHecEK2PZNeGJ0y0ASUDVCEuNqqRruSAgACLbJA= Date: Tue, 23 Mar 2021 23:21:09 +0000 Message-ID: <67cc380019fd40d88d7a493b6cbc0852@hisilicon.com> References: <20210319041618.14316-1-song.bao.hua@hisilicon.com> <20210319041618.14316-5-song.bao.hua@hisilicon.com> <110234d1-22ce-8a9a-eabb-c15ac29a5dcd@linux.intel.com> In-Reply-To: <110234d1-22ce-8a9a-eabb-c15ac29a5dcd@linux.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.201.12] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_232117_686234_C36BC45E X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Tim Chen [mailto:tim.c.chen@linux.intel.com] > Sent: Wednesday, March 24, 2021 11:51 AM > To: Song Bao Hua (Barry Song) ; > catalin.marinas@arm.com; will@kernel.org; rjw@rjwysocki.net; > vincent.guittot@linaro.org; bp@alien8.de; tglx@linutronix.de; > mingo@redhat.com; lenb@kernel.org; peterz@infradead.org; > dietmar.eggemann@arm.com; rostedt@goodmis.org; bsegall@google.com; > mgorman@suse.de > Cc: msys.mizuma@gmail.com; valentin.schneider@arm.com; > gregkh@linuxfoundation.org; Jonathan Cameron ; > juri.lelli@redhat.com; mark.rutland@arm.com; sudeep.holla@arm.com; > aubrey.li@linux.intel.com; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org; x86@kernel.org; > xuwei (O) ; Zengtao (B) ; > guodong.xu@linaro.org; yangyicong ; Liguozhu (Kenneth) > ; linuxarm@openeuler.org; hpa@zytor.com > Subject: Re: [RFC PATCH v5 4/4] scheduler: Add cluster scheduler level for x86 > > > > On 3/18/21 9:16 PM, Barry Song wrote: > > From: Tim Chen > > > > There are x86 CPU architectures (e.g. Jacobsville) where L2 cahce > > is shared among a cluster of cores instead of being exclusive > > to one single core. > > > > To prevent oversubscription of L2 cache, load should be > > balanced between such L2 clusters, especially for tasks with > > no shared data. > > > > Also with cluster scheduling policy where tasks are woken up > > in the same L2 cluster, we will benefit from keeping tasks > > related to each other and likely sharing data in the same L2 > > cluster. > > > > Add CPU masks of CPUs sharing the L2 cache so we can build such > > L2 cluster scheduler domain. > > > > Signed-off-by: Tim Chen > > Signed-off-by: Barry Song > > > Barry, > > Can you also add this chunk to the patch. > Thanks. Sure, Tim, Thanks. I'll put that into patch 4/4 in v6. > > Tim > > > diff --git a/arch/x86/include/asm/topology.h > b/arch/x86/include/asm/topology.h > index 2a11ccc14fb1..800fa48c9fcd 100644 > --- a/arch/x86/include/asm/topology.h > +++ b/arch/x86/include/asm/topology.h > @@ -115,6 +115,7 @@ extern unsigned int __max_die_per_package; > > #ifdef CONFIG_SMP > #define topology_die_cpumask(cpu) (per_cpu(cpu_die_map, cpu)) > +#define topology_cluster_cpumask(cpu) (cpu_clustergroup_mask(cpu)) > #define topology_core_cpumask(cpu) (per_cpu(cpu_core_map, cpu)) > #define topology_sibling_cpumask(cpu) (per_cpu(cpu_sibling_map, cpu)) > Thanks Barry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel