From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0188BC4363D for ; Tue, 22 Sep 2020 18:24:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E4AA239D4 for ; Tue, 22 Sep 2020 18:24:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xen.org header.i=@xen.org header.b="1ofcBOoi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E4AA239D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKmxO-00088Y-Lv; Tue, 22 Sep 2020 18:24:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKmxN-00088R-7o for xen-devel@lists.xenproject.org; Tue, 22 Sep 2020 18:24:01 +0000 X-Inumbo-ID: 5d4e3ac6-4fe0-4999-a665-bb51315787bf Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5d4e3ac6-4fe0-4999-a665-bb51315787bf; Tue, 22 Sep 2020 18:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=WK8HqUc7UcXT7zlX5Zl6tFsFW86Pt1Pm4/72J/E5zi8=; b=1ofcBOoiSwSzf9zabW1OWUw/av 0TW/3+hEqgt7J/+TlwcAPywC4QcXAkPXlQvTatTFmCWB+HLNABLThESuV8QlYXEZq5ekuHg5oxHzQ MT8JoIJaizubc/cu9nF2tN/zxyuunw3EQ9DDgFe4njI2xZUvAcpz6olSmOapkJT9AhN8=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKmxJ-0005Rg-5R; Tue, 22 Sep 2020 18:23:57 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kKmxI-0005IV-Uy; Tue, 22 Sep 2020 18:23:57 +0000 Subject: Re: [PATCH v4 3/4] xen: Remove mfn_to_gmfn macro To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20200921180214.4842-1-julien@xen.org> <20200921180214.4842-4-julien@xen.org> From: Julien Grall Message-ID: <67d2dc46-e2f1-1ab8-b91e-499498deff17@xen.org> Date: Tue, 22 Sep 2020 19:23:54 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 21/09/2020 21:34, Andrew Cooper wrote: > On 21/09/2020 19:02, Julien Grall wrote: >> From: Julien Grall >> >> On x86, mfn_to_gmfn can be replaced with mfn_to_gfn. On Arm, there are >> no more call to mfn_to_gmfn, so the helper can be dropped. > > The previous patch dropped the mfn_to_gmfn() call from the domain shared > info path, but without a hunk adjusting the innards of > memory_exchange(), this is going to break the x86 build. Urgh, I thought I build test it the code. I will fix it. > >> At the same time rework a comment in Arm code that does not make sense. >> >> Signed-off-by: Julien Grall > > To save a round trip, Acked-by: Andrew Cooper > with the appropriate hunk to memory_exchange(). > > Alternatively, it might make sense to fold the adjustment into patch 1 > which is perhaps more obvious, given the insertion of an is_pv_domain() > check. I will add in this patch unless someone else also prefer that the change is added in patch #1. Cheers, -- Julien Grall