From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A0EC07E9C for ; Wed, 14 Jul 2021 17:14:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDFBA61370 for ; Wed, 14 Jul 2021 17:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239711AbhGNRRc (ORCPT ); Wed, 14 Jul 2021 13:17:32 -0400 Received: from mga01.intel.com ([192.55.52.88]:35631 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239635AbhGNRRb (ORCPT ); Wed, 14 Jul 2021 13:17:31 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="232208078" X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="232208078" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 10:14:39 -0700 X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="413353810" Received: from alpinagh-mobl1.amr.corp.intel.com (HELO [10.212.71.223]) ([10.212.71.223]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 10:14:37 -0700 Subject: Re: [PATCH v2 16/16] ASoC: qcom: sm8250: Add audioreach support To: Srinivas Kandagatla , bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, lgirdwood@gmail.com, tiwai@suse.de, plai@codeaurora.org, linux-kernel@vger.kernel.org References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-17-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: <67e19b85-7f97-c965-04ea-6a46eaf19f3f@linux.intel.com> Date: Wed, 14 Jul 2021 12:12:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714153039.28373-17-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/14/21 10:30 AM, Srinivas Kandagatla wrote: > This patch adds support for parsing dt for AudioReach based soundcards > which only have backend DAI links in DT. > > Signed-off-by: Srinivas Kandagatla > --- > sound/soc/qcom/sm8250.c | 144 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 143 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/sm8250.c b/sound/soc/qcom/sm8250.c > index fe8fd7367e21..421f9d1d2bed 100644 > --- a/sound/soc/qcom/sm8250.c > +++ b/sound/soc/qcom/sm8250.c > @@ -20,6 +20,141 @@ struct sm8250_snd_data { > struct sdw_stream_runtime *sruntime[AFE_PORT_MAX]; > }; > > +static int qcom_audioreach_snd_parse_of(struct snd_soc_card *card) > +{ > + struct device_node *np; > + struct device_node *codec = NULL; > + struct device_node *platform = NULL; > + struct device_node *cpu = NULL; > + struct device *dev = card->dev; > + struct snd_soc_dai_link *link; > + struct of_phandle_args args; > + struct snd_soc_dai_link_component *dlc; > + int ret, num_links; > + > + ret = snd_soc_of_parse_card_name(card, "model"); > + if (ret) { > + dev_err(dev, "Error parsing card name: %d\n", ret); > + return ret; > + } > + > + /* DAPM routes */ > + if (of_property_read_bool(dev->of_node, "audio-routing")) { > + ret = snd_soc_of_parse_audio_routing(card, "audio-routing"); > + if (ret) > + return ret; > + } > + > + /* Populate links */ > + num_links = of_get_child_count(dev->of_node); > + > + /* Allocate the DAI link array */ > + card->dai_link = devm_kcalloc(dev, num_links, sizeof(*link), GFP_KERNEL); > + if (!card->dai_link) > + return -ENOMEM; > + > + card->num_links = num_links; > + link = card->dai_link; > + > + for_each_child_of_node(dev->of_node, np) { > + > + dlc = devm_kzalloc(dev, 2 * sizeof(*dlc), GFP_KERNEL); > + if (!dlc) { > + ret = -ENOMEM; > + goto err_put_np; > + } > + > + link->cpus = &dlc[0]; > + link->platforms = &dlc[1]; > + > + link->num_cpus = 1; > + link->num_platforms = 1; > + > + > + ret = of_property_read_string(np, "link-name", &link->name); > + if (ret) { > + dev_err(card->dev, "error getting codec dai_link name\n"); > + goto err_put_np; > + } > + > + cpu = of_get_child_by_name(np, "cpu"); > + platform = of_get_child_by_name(np, "platform"); > + codec = of_get_child_by_name(np, "codec"); > + if (!cpu) { > + dev_err(dev, "%s: Can't find cpu DT node\n", link->name); > + ret = -EINVAL; > + goto err; > + } > + > + if (!platform) { > + dev_err(dev, "%s: Can't find platform DT node\n", link->name); > + ret = -EINVAL; > + goto err; > + } > + > + if (!codec) { > + dev_err(dev, "%s: Can't find codec DT node\n", link->name); > + ret = -EINVAL; > + goto err; > + } > + > + ret = of_parse_phandle_with_args(cpu, "sound-dai", "#sound-dai-cells", 0, &args); > + if (ret) { > + dev_err(card->dev, "%s: error getting cpu phandle\n", link->name); > + goto err; > + } > + > + link->cpus->of_node = args.np; > + link->id = args.args[0]; > + > + ret = snd_soc_of_get_dai_name(cpu, &link->cpus->dai_name); > + if (ret) { > + if (ret != -EPROBE_DEFER) > + dev_err(card->dev, "%s: error getting cpu dai name: %d\n", > + link->name, ret); > + goto err; > + } > + > + link->platforms->of_node = of_parse_phandle(platform, "sound-dai", 0); > + if (!link->platforms->of_node) { > + dev_err(card->dev, "%s: platform dai not found\n", link->name); > + ret = -EINVAL; > + goto err; > + } > + > + ret = snd_soc_of_get_dai_link_codecs(dev, codec, link); > + if (ret < 0) { > + if (ret != -EPROBE_DEFER) > + dev_err(card->dev, "%s: codec dai not found: %d\n", > + link->name, ret); > + goto err; > + } > + > + /* DPCM backend */ > + link->no_pcm = 1; > + link->ignore_pmdown_time = 1; > + link->ignore_suspend = 1; why are those two fields set unconditionally? If you parse information from DT shouldn't those links be explicitly tagged as requiring those fields to be set? It's a recurring battle for me to ask why people set them in Intel machine drivers, I find it really odd that you would set them since they aren't without side effect on clocks and suspend. > + > + link->stream_name = link->name; > + snd_soc_dai_link_set_capabilities(link); > + link++; > + > + of_node_put(cpu); > + of_node_put(codec); > + of_node_put(platform); > + > + } > + > + return 0; > +err: > + of_node_put(cpu); > + of_node_put(codec); > + of_node_put(platform); > +err_put_np: > + of_node_put(np); > + return ret; > +} > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2661AC07E9A for ; Wed, 14 Jul 2021 17:18:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90741613B5 for ; Wed, 14 Jul 2021 17:18:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90741613B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3030516B1; Wed, 14 Jul 2021 19:17:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3030516B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626283119; bh=JvY0RPNhDFGRIDDlcWau0biVcrGrUlcz1AzyNPCi/Bs=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Z+izj4Ach6yd6xLxPadJ8UDs1lgGsT/Rmf4qeUpmKQJgzl0rFHMsyGA5zhjc8ctF5 5f556rD/CuH2ffhGEUymbyB5yR3qqMQMMCrmAzEP1aM/OMfrxGn23n+AxaFtrqXiN0 l8AmSDms9+mU0RPjxFaKf3oQRJLIl9W2QfWFd24o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E5131F80516; Wed, 14 Jul 2021 19:14:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E0D43F80517; Wed, 14 Jul 2021 19:14:46 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E32C6F80507 for ; Wed, 14 Jul 2021 19:14:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E32C6F80507 X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="190770010" X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="190770010" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 10:14:39 -0700 X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="413353810" Received: from alpinagh-mobl1.amr.corp.intel.com (HELO [10.212.71.223]) ([10.212.71.223]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 10:14:37 -0700 Subject: Re: [PATCH v2 16/16] ASoC: qcom: sm8250: Add audioreach support To: Srinivas Kandagatla , bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-17-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: <67e19b85-7f97-c965-04ea-6a46eaf19f3f@linux.intel.com> Date: Wed, 14 Jul 2021 12:12:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714153039.28373-17-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, tiwai@suse.de, plai@codeaurora.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/14/21 10:30 AM, Srinivas Kandagatla wrote: > This patch adds support for parsing dt for AudioReach based soundcards > which only have backend DAI links in DT. > > Signed-off-by: Srinivas Kandagatla > --- > sound/soc/qcom/sm8250.c | 144 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 143 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/sm8250.c b/sound/soc/qcom/sm8250.c > index fe8fd7367e21..421f9d1d2bed 100644 > --- a/sound/soc/qcom/sm8250.c > +++ b/sound/soc/qcom/sm8250.c > @@ -20,6 +20,141 @@ struct sm8250_snd_data { > struct sdw_stream_runtime *sruntime[AFE_PORT_MAX]; > }; > > +static int qcom_audioreach_snd_parse_of(struct snd_soc_card *card) > +{ > + struct device_node *np; > + struct device_node *codec = NULL; > + struct device_node *platform = NULL; > + struct device_node *cpu = NULL; > + struct device *dev = card->dev; > + struct snd_soc_dai_link *link; > + struct of_phandle_args args; > + struct snd_soc_dai_link_component *dlc; > + int ret, num_links; > + > + ret = snd_soc_of_parse_card_name(card, "model"); > + if (ret) { > + dev_err(dev, "Error parsing card name: %d\n", ret); > + return ret; > + } > + > + /* DAPM routes */ > + if (of_property_read_bool(dev->of_node, "audio-routing")) { > + ret = snd_soc_of_parse_audio_routing(card, "audio-routing"); > + if (ret) > + return ret; > + } > + > + /* Populate links */ > + num_links = of_get_child_count(dev->of_node); > + > + /* Allocate the DAI link array */ > + card->dai_link = devm_kcalloc(dev, num_links, sizeof(*link), GFP_KERNEL); > + if (!card->dai_link) > + return -ENOMEM; > + > + card->num_links = num_links; > + link = card->dai_link; > + > + for_each_child_of_node(dev->of_node, np) { > + > + dlc = devm_kzalloc(dev, 2 * sizeof(*dlc), GFP_KERNEL); > + if (!dlc) { > + ret = -ENOMEM; > + goto err_put_np; > + } > + > + link->cpus = &dlc[0]; > + link->platforms = &dlc[1]; > + > + link->num_cpus = 1; > + link->num_platforms = 1; > + > + > + ret = of_property_read_string(np, "link-name", &link->name); > + if (ret) { > + dev_err(card->dev, "error getting codec dai_link name\n"); > + goto err_put_np; > + } > + > + cpu = of_get_child_by_name(np, "cpu"); > + platform = of_get_child_by_name(np, "platform"); > + codec = of_get_child_by_name(np, "codec"); > + if (!cpu) { > + dev_err(dev, "%s: Can't find cpu DT node\n", link->name); > + ret = -EINVAL; > + goto err; > + } > + > + if (!platform) { > + dev_err(dev, "%s: Can't find platform DT node\n", link->name); > + ret = -EINVAL; > + goto err; > + } > + > + if (!codec) { > + dev_err(dev, "%s: Can't find codec DT node\n", link->name); > + ret = -EINVAL; > + goto err; > + } > + > + ret = of_parse_phandle_with_args(cpu, "sound-dai", "#sound-dai-cells", 0, &args); > + if (ret) { > + dev_err(card->dev, "%s: error getting cpu phandle\n", link->name); > + goto err; > + } > + > + link->cpus->of_node = args.np; > + link->id = args.args[0]; > + > + ret = snd_soc_of_get_dai_name(cpu, &link->cpus->dai_name); > + if (ret) { > + if (ret != -EPROBE_DEFER) > + dev_err(card->dev, "%s: error getting cpu dai name: %d\n", > + link->name, ret); > + goto err; > + } > + > + link->platforms->of_node = of_parse_phandle(platform, "sound-dai", 0); > + if (!link->platforms->of_node) { > + dev_err(card->dev, "%s: platform dai not found\n", link->name); > + ret = -EINVAL; > + goto err; > + } > + > + ret = snd_soc_of_get_dai_link_codecs(dev, codec, link); > + if (ret < 0) { > + if (ret != -EPROBE_DEFER) > + dev_err(card->dev, "%s: codec dai not found: %d\n", > + link->name, ret); > + goto err; > + } > + > + /* DPCM backend */ > + link->no_pcm = 1; > + link->ignore_pmdown_time = 1; > + link->ignore_suspend = 1; why are those two fields set unconditionally? If you parse information from DT shouldn't those links be explicitly tagged as requiring those fields to be set? It's a recurring battle for me to ask why people set them in Intel machine drivers, I find it really odd that you would set them since they aren't without side effect on clocks and suspend. > + > + link->stream_name = link->name; > + snd_soc_dai_link_set_capabilities(link); > + link++; > + > + of_node_put(cpu); > + of_node_put(codec); > + of_node_put(platform); > + > + } > + > + return 0; > +err: > + of_node_put(cpu); > + of_node_put(codec); > + of_node_put(platform); > +err_put_np: > + of_node_put(np); > + return ret; > +} > +