All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 2/4] crypto/fsl: export caam_get_era()
Date: Wed, 3 Jun 2020 19:12:05 +0200	[thread overview]
Message-ID: <67ecb921-2549-84f1-957e-a9dfdd181993@gmx.de> (raw)
In-Reply-To: <20200602220554.22477-3-michael@walle.cc>

On 6/3/20 12:05 AM, Michael Walle wrote:
> We need the era in other modules, too. For example, to get the RNG
> version.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/crypto/fsl/sec.c | 2 +-
>  include/fsl_sec.h        | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/fsl/sec.c b/drivers/crypto/fsl/sec.c
> index a2c0bfaf44..a2fe5b1cc9 100644
> --- a/drivers/crypto/fsl/sec.c
> +++ b/drivers/crypto/fsl/sec.c
> @@ -98,7 +98,7 @@ void fdt_fixup_crypto_node(void *blob, int sec_rev)
>  		       fdt_strerror(err));
>  }
>  #elif CONFIG_SYS_FSL_SEC_COMPAT >= 4  /* SEC4 */
> -static u8 caam_get_era(void)
> +u8 caam_get_era(void)
>  {
>  	static const struct {
>  		u16 ip_id;
> diff --git a/include/fsl_sec.h b/include/fsl_sec.h
> index c0d2c7e866..2ebb75c9b2 100644
> --- a/include/fsl_sec.h
> +++ b/include/fsl_sec.h
> @@ -316,6 +316,8 @@ int blob_dek(const u8 *src, u8 *dst, u8 len);
>  int sec_init_idx(uint8_t);
>  #endif
>  int sec_init(void);
> +

Exported functions should be documented. See
https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#function-documentation

> +u8 caam_get_era(void);
>  #endif
>
>  #endif /* __FSL_SEC_H */
>

  parent reply	other threads:[~2020-06-03 17:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 22:05 [PATCH 0/4] crypto/fsl: add RNG support Michael Walle
2020-06-02 22:05 ` [PATCH 1/4] crypto/fsl: make SEC%u status line consistent Michael Walle
2020-06-03 17:00   ` Horia Geantă
2020-06-03 17:10   ` Heinrich Schuchardt
2020-06-02 22:05 ` [PATCH 2/4] crypto/fsl: export caam_get_era() Michael Walle
2020-06-03 17:07   ` Horia Geantă
2020-06-03 17:12   ` Heinrich Schuchardt [this message]
2020-06-02 22:05 ` [PATCH 3/4] crypto/fsl: support newer SEC modules Michael Walle
2020-06-03 17:51   ` Horia Geantă
2020-06-02 22:05 ` [PATCH 4/4] crypto/fsl: add RNG support Michael Walle
2020-06-03 16:50   ` Horia Geantă
2020-06-03 17:35     ` Heinrich Schuchardt
2020-06-03 18:25       ` Michael Walle
2020-06-03 20:25         ` Horia Geantă
2020-06-04  2:31   ` Heinrich Schuchardt
2020-06-04  8:05     ` Horia Geantă
2020-06-04 10:28       ` Michael Walle
2020-06-04 12:26       ` Heinrich Schuchardt
2020-06-04 12:52         ` Michael Walle
2020-06-04 12:58           ` Heinrich Schuchardt
2020-06-04 13:20             ` Michael Walle
2020-06-04 15:45               ` Heinrich Schuchardt
2020-06-05 12:15                 ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67ecb921-2549-84f1-957e-a9dfdd181993@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.