From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC773C433FE for ; Thu, 3 Nov 2022 16:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231827AbiKCQag (ORCPT ); Thu, 3 Nov 2022 12:30:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbiKCQaW (ORCPT ); Thu, 3 Nov 2022 12:30:22 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98694B92; Thu, 3 Nov 2022 09:30:20 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2A3GToek119565; Thu, 3 Nov 2022 11:29:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1667492990; bh=tku/OEvVMYCVyJUwEFWbSTgXMuBEfZMv78bmcEijKEU=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=NI9urWluRQ1mAozq+guJV0WCseYHWaz89rZOHQku5axa2KGRwPtoY4XRk7RoRWeuO Z/WYOnoY/Oho88F4rkakWLjh2voQYoM8ihJl8I0SX6Mf4QR8UjnQ+83fce1TkajChi goB8VhRG2859EkhvsRTDnQIxkmlnTTjfIadXe+pY= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2A3GToL9072450 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Nov 2022 11:29:50 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Thu, 3 Nov 2022 11:29:50 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Thu, 3 Nov 2022 11:29:50 -0500 Received: from [10.250.32.80] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2A3GTnWQ003709; Thu, 3 Nov 2022 11:29:49 -0500 Message-ID: <67f9ce4b-1ed6-fc41-c133-1fbafb743830@ti.com> Date: Thu, 3 Nov 2022 11:29:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4 7/9] ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap Content-Language: en-US To: Dmitry Torokhov CC: Lee Jones , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Linus Walleij , Geert Uytterhoeven , Daniel Tang , Fabian Vogt , , , References: <20221101215804.16262-1-afd@ti.com> <20221101215804.16262-8-afd@ti.com> From: Andrew Davis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/2/22 11:07 PM, Dmitry Torokhov wrote: > Hi Andrew, > > On Tue, Nov 1, 2022 at 2:59 PM Andrew Davis wrote: >> >> This looks better and allows us to see the row and column numbers >> more easily. Switch to this macro here. >> >> Signed-off-by: Andrew Davis >> --- >> arch/arm/boot/dts/nspire-clp.dts | 90 ++++++++++++++++++++++++-------- >> arch/arm/boot/dts/nspire-cx.dts | 90 ++++++++++++++++++++++++-------- >> arch/arm/boot/dts/nspire-tp.dts | 90 ++++++++++++++++++++++++-------- >> 3 files changed, 204 insertions(+), 66 deletions(-) >> >> diff --git a/arch/arm/boot/dts/nspire-clp.dts b/arch/arm/boot/dts/nspire-clp.dts >> index f52f38c615886..916ede0c2499c 100644 >> --- a/arch/arm/boot/dts/nspire-clp.dts >> +++ b/arch/arm/boot/dts/nspire-clp.dts >> @@ -6,32 +6,78 @@ >> */ >> /dts-v1/; >> >> +#include >> + >> /include/ "nspire-classic.dtsi" >> >> &keypad { >> linux,keymap = < >> - 0x0000001c 0x0001001c 0x00020039 >> - 0x0004002c 0x00050034 0x00060015 >> - 0x0007000b 0x0008002d 0x01000033 >> - 0x0101004e 0x01020011 0x01030004 >> - 0x0104002f 0x01050003 0x01060016 >> - 0x01070002 0x01080014 0x02000062 >> - 0x0201000c 0x0202001f 0x02030007 >> - 0x02040013 0x02050006 0x02060010 >> - 0x02070005 0x02080019 0x03000027 >> - 0x03010037 0x03020018 0x0303000a >> - 0x03040031 0x03050009 0x03060032 >> - 0x03070008 0x03080026 0x04000028 >> - 0x04010035 0x04020025 0x04040024 >> - 0x04060017 0x04080023 0x05000028 >> - 0x05020022 0x0503001b 0x05040021 >> - 0x0505001a 0x05060012 0x0507006f >> - 0x05080020 0x0509002a 0x0601001c >> - 0x0602002e 0x06030068 0x06040030 >> - 0x0605006d 0x0606001e 0x06070001 >> - 0x0608002b 0x0609000f 0x07000067 >> - 0x0702006a 0x0704006c 0x07060069 >> - 0x0707000e 0x0708001d 0x070a000d >> + MATRIX_KEY(0, 0, 0x1c) >> + MATRIX_KEY(0, 1, 0x1c) >> + MATRIX_KEY(0, 2, 0x39) > > Can this also be switched over to using KEY_* macros to describe the > keycodes emitted? > That's going to be done in a follow up patch. This change here was done mechanically, but moving to KEY_* might need to be double checked by hand since some of these do not seem to map how one would expect to the function on the keypad. Thanks, Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 319F2C4332F for ; Thu, 3 Nov 2022 16:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lLnjnMpmuqzBs0M2i/CRkj3WVKJhsVyBs5AhpWCrMOs=; b=cUDLZecudNTatw fvkke954fMYCcMJrRzgo1fvAYc933L+VM2Or+JLULO5tiuSySqOIeLgmn50cn7dZuLBQYK5untgYJ m6IUXY5lTDNy2Lkxs73LY4/Q7RCxan3v9cRRiMf1YRDdd+bO5ZEsHGa9KIB2lkyXifG7u8ZJj0uPh b+MriMDtD9lsd2HY1q+QmTOTeo1FZhNRmVlHzhU0Gl6DToCWrnSi+dqSJwcBCk3IrXfOwLJhUGJsy rkXJSqAkr2Kx9rFcjux/cg/gS1Q0MkogKC8uUXXVvv5/f5/O6L8RWIMtBU5LxAYATy12Ffhm6tOGB u6+hWr3dAaDPx/ORoJ8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqd6h-000hYf-Fr; Thu, 03 Nov 2022 16:30:19 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqd6U-000hVK-5D for linux-arm-kernel@lists.infradead.org; Thu, 03 Nov 2022 16:30:17 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2A3GToek119565; Thu, 3 Nov 2022 11:29:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1667492990; bh=tku/OEvVMYCVyJUwEFWbSTgXMuBEfZMv78bmcEijKEU=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=NI9urWluRQ1mAozq+guJV0WCseYHWaz89rZOHQku5axa2KGRwPtoY4XRk7RoRWeuO Z/WYOnoY/Oho88F4rkakWLjh2voQYoM8ihJl8I0SX6Mf4QR8UjnQ+83fce1TkajChi goB8VhRG2859EkhvsRTDnQIxkmlnTTjfIadXe+pY= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2A3GToL9072450 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Nov 2022 11:29:50 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Thu, 3 Nov 2022 11:29:50 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Thu, 3 Nov 2022 11:29:50 -0500 Received: from [10.250.32.80] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2A3GTnWQ003709; Thu, 3 Nov 2022 11:29:49 -0500 Message-ID: <67f9ce4b-1ed6-fc41-c133-1fbafb743830@ti.com> Date: Thu, 3 Nov 2022 11:29:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4 7/9] ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap Content-Language: en-US To: Dmitry Torokhov CC: Lee Jones , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Linus Walleij , Geert Uytterhoeven , Daniel Tang , Fabian Vogt , , , References: <20221101215804.16262-1-afd@ti.com> <20221101215804.16262-8-afd@ti.com> From: Andrew Davis In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221103_093015_665441_6AD8CFA1 X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/2/22 11:07 PM, Dmitry Torokhov wrote: > Hi Andrew, > > On Tue, Nov 1, 2022 at 2:59 PM Andrew Davis wrote: >> >> This looks better and allows us to see the row and column numbers >> more easily. Switch to this macro here. >> >> Signed-off-by: Andrew Davis >> --- >> arch/arm/boot/dts/nspire-clp.dts | 90 ++++++++++++++++++++++++-------- >> arch/arm/boot/dts/nspire-cx.dts | 90 ++++++++++++++++++++++++-------- >> arch/arm/boot/dts/nspire-tp.dts | 90 ++++++++++++++++++++++++-------- >> 3 files changed, 204 insertions(+), 66 deletions(-) >> >> diff --git a/arch/arm/boot/dts/nspire-clp.dts b/arch/arm/boot/dts/nspire-clp.dts >> index f52f38c615886..916ede0c2499c 100644 >> --- a/arch/arm/boot/dts/nspire-clp.dts >> +++ b/arch/arm/boot/dts/nspire-clp.dts >> @@ -6,32 +6,78 @@ >> */ >> /dts-v1/; >> >> +#include >> + >> /include/ "nspire-classic.dtsi" >> >> &keypad { >> linux,keymap = < >> - 0x0000001c 0x0001001c 0x00020039 >> - 0x0004002c 0x00050034 0x00060015 >> - 0x0007000b 0x0008002d 0x01000033 >> - 0x0101004e 0x01020011 0x01030004 >> - 0x0104002f 0x01050003 0x01060016 >> - 0x01070002 0x01080014 0x02000062 >> - 0x0201000c 0x0202001f 0x02030007 >> - 0x02040013 0x02050006 0x02060010 >> - 0x02070005 0x02080019 0x03000027 >> - 0x03010037 0x03020018 0x0303000a >> - 0x03040031 0x03050009 0x03060032 >> - 0x03070008 0x03080026 0x04000028 >> - 0x04010035 0x04020025 0x04040024 >> - 0x04060017 0x04080023 0x05000028 >> - 0x05020022 0x0503001b 0x05040021 >> - 0x0505001a 0x05060012 0x0507006f >> - 0x05080020 0x0509002a 0x0601001c >> - 0x0602002e 0x06030068 0x06040030 >> - 0x0605006d 0x0606001e 0x06070001 >> - 0x0608002b 0x0609000f 0x07000067 >> - 0x0702006a 0x0704006c 0x07060069 >> - 0x0707000e 0x0708001d 0x070a000d >> + MATRIX_KEY(0, 0, 0x1c) >> + MATRIX_KEY(0, 1, 0x1c) >> + MATRIX_KEY(0, 2, 0x39) > > Can this also be switched over to using KEY_* macros to describe the > keycodes emitted? > That's going to be done in a follow up patch. This change here was done mechanically, but moving to KEY_* might need to be double checked by hand since some of these do not seem to map how one would expect to the function on the keypad. Thanks, Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel