From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC496D00 for ; Sat, 10 Apr 2021 14:21:18 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id ba6so9797727edb.1 for ; Sat, 10 Apr 2021 07:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q5nuHsBBM9Uu1NfcSwY0BeNDKPAr9Mc7yGwZ1gPZKnI=; b=nKprcCW1KTc/ZmDN5ZQEAry5+/nQAra+VVTkkuAbas6WuVdFCJ5fZvp3vXivJT0DM5 dp18WmeGkl3zuj6UxxceNPQ8M/d0sih/Ac4iUX5J0Vjir+Tk2jLTqUrxcLh5VNGb/LRp OljX66TtyEMSo3mg6/apkaUJOMWXtFcfJKHNvS7mE799ijil+vGRQmO6NJL/0W3FfMK7 36Ng16iUJ7o9uHFFaW+VcvuCqM0PTyktNDO971wVAVo4Plfn9aoleub93Elf6Cmg7yk2 0J18SHspXPBPGol0Ul9S2rSTCfooV5bLdjx3aDmAOMyvBnI4iIKLt2IVVKg5R6Y/J71V y5jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q5nuHsBBM9Uu1NfcSwY0BeNDKPAr9Mc7yGwZ1gPZKnI=; b=tQgkTv/7rTsYoYrgQ138ZtTAjl9wRmUKAU20gDr55eJzOc4bpg86thAe2Ux4y1K7QG b/Fm8y2cR9GhSkHhJj6Q+Q3vGnVB3ZKYJrnkg6NYoW7lgAFMiU24YjuPHGJfYW33DSPm QRyr1tLdOECWvk6EpK2MsjOlVnrCOfwiuFpr3EK8e87l+Ezy0PMq7CREF87CqzAJFi+u 9EQndD2kTr1poH2DlZIF4KpsZKFaBGku+qbCkztu7RkRoi2Q0fdcYy179UcI3PabtwYf wdX6w+wkZBWLcu6Z0UWjqb7YhYhTm07lHZRQiK/xZYIl9il2Kf4liUnuGrh1KriGWiCk StEw== X-Gm-Message-State: AOAM531bC9LIfk7KcLSQ84/P64IDRm37sGToByKIKMiaLtKjgJBOjeAk qomQJ12QrOi0MujGg7lw23Q= X-Google-Smtp-Source: ABdhPJxeC5c3e6VdSCsFCmVjQi/P2oC645yjC7t0oCNNxYoJmVqrKrujomXohaEdCntWE7Kp1NheBw== X-Received: by 2002:aa7:db9a:: with SMTP id u26mr21776965edt.292.1618064476704; Sat, 10 Apr 2021 07:21:16 -0700 (PDT) Received: from agape ([5.171.81.28]) by smtp.gmail.com with ESMTPSA id df8sm3270777edb.4.2021.04.10.07.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 07:21:16 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 23/25] staging: rtl8723bs: fix comparison to true issue Date: Sat, 10 Apr 2021 16:20:36 +0200 Message-Id: <680d86950d760003a694f8880c0a912a9d815a5e.1618064275.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fix following post-commit hook checkpatch issue: CHECK: Using comparison to true is error prone 136: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: 2497: + if (psta->dot8021xalg != 1 || psta->bpairwise_key_installed == true) { Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 9c98820952e4..89a21eb63c0a 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -2491,7 +2491,7 @@ static int cfg80211_rtw_del_station(struct wiphy *wiphy, struct net_device *ndev plist = get_next(plist); if (!memcmp((u8 *)mac, psta->hwaddr, ETH_ALEN)) { - if (psta->dot8021xalg != 1 || psta->bpairwise_key_installed == true) { + if (psta->dot8021xalg != 1 || psta->bpairwise_key_installed) { list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; -- 2.20.1