From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Fri, 19 Oct 2018 07:53:04 +0200 Subject: [U-Boot] [PATCH v11 2/6] efi_loader: Drop setup_ok In-Reply-To: References: <20181015141750.56480-1-sjg@chromium.org> <20181015141750.56480-3-sjg@chromium.org> <152f1386-6646-46a5-14cf-293d8bc74f3c@gmx.de> Message-ID: <68194240-5428-d7dc-e6cd-f060b2e26b0a@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/19/2018 05:25 AM, Simon Glass wrote: > Hi, > > On 15 October 2018 at 11:16, Heinrich Schuchardt wrote: >> On 10/15/2018 04:17 PM, Simon Glass wrote: >>> This value is stored in data which appears to be read-only with sandbox on >>> my Ubuntu 18.04 machine. In any case it is not good practice to store >>> run-time data in a build-time linker list. >> Yes this should be changed. Otherwise a reset of the board will not put >> us back into the initial status. >> >>> >>> The value does not seem to be that useful, since tests that fail to setup >>> are likely to fail to run also. Let's drop it for now. >> >> With your change we will run execute() even if setup() fails. This >> contradicts the commit message. Please, find a solution that avoids >> calling execute() after a failed setup(). > > How about we just exit if setup() fails? It should not fail. The test > can fail, but not the setup. > > Regards, > Simon > I just have sent an alternative patch. Thanks for reporting the issue. Best regards Heinrich