From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 56F4D820EA for ; Thu, 16 Feb 2017 07:42:39 -0800 (PST) Subject: Re: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear() References: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> From: Dave Hansen Message-ID: <68216ac2-e194-30fa-9dcb-2020e8953bf5@linux.intel.com> Date: Thu, 16 Feb 2017 07:42:34 -0800 MIME-Version: 1.0 In-Reply-To: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dave Jiang , akpm@linux-foundation.org Cc: jack@suse.com, alexander.kapshuk@gmail.com, linux-nvdimm@lists.01.org, mawilcox@microsoft.com, linux-xfs@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, keescook@google.com, linux-ext4@vger.kernel.org, kirill.shutemov@linux.intel.com List-ID: On 02/15/2017 12:31 PM, Dave Jiang wrote: > The fix introduced by e4decc90 to fix the UP case for 32bit x86, however > that broke the SMP case that was working previously. Add ifdef so the dummy > function only show up for 32bit UP case only. Could you elaborate a bit on how it broke things? > Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build Which tree is that in, btw? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear() Date: Thu, 16 Feb 2017 07:42:34 -0800 Message-ID: <68216ac2-e194-30fa-9dcb-2020e8953bf5@linux.intel.com> References: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: jack-IBi9RG/b67k@public.gmane.org, alexander.kapshuk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, mawilcox-0li6OtcxBFHby3iVrkZq2A@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, vbabka-AlSwsSmVLrQ@public.gmane.org, keescook-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org To: Dave Jiang , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org Return-path: In-Reply-To: <148719066814.31111.3239231168815337012.stgit-Cxk7aZI4ujnJARH06PadV2t3HXsI98Cx0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On 02/15/2017 12:31 PM, Dave Jiang wrote: > The fix introduced by e4decc90 to fix the UP case for 32bit x86, however > that broke the SMP case that was working previously. Add ifdef so the dummy > function only show up for 32bit UP case only. Could you elaborate a bit on how it broke things? > Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build Which tree is that in, btw? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:27077 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932224AbdBPPmy (ORCPT ); Thu, 16 Feb 2017 10:42:54 -0500 Subject: Re: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear() References: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> From: Dave Hansen Message-ID: <68216ac2-e194-30fa-9dcb-2020e8953bf5@linux.intel.com> Date: Thu, 16 Feb 2017 07:42:34 -0800 MIME-Version: 1.0 In-Reply-To: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Jiang , akpm@linux-foundation.org Cc: keescook@google.com, mawilcox@microsoft.com, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, kirill.shutemov@linux.intel.com, jack@suse.com, dan.j.williams@intel.com, linux-ext4@vger.kernel.org, ross.zwisler@linux.intel.com, vbabka@suse.cz, alexander.kapshuk@gmail.com On 02/15/2017 12:31 PM, Dave Jiang wrote: > The fix introduced by e4decc90 to fix the UP case for 32bit x86, however > that broke the SMP case that was working previously. Add ifdef so the dummy > function only show up for 32bit UP case only. Could you elaborate a bit on how it broke things? > Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build Which tree is that in, btw? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id 4F6AE680FF1 for ; Thu, 16 Feb 2017 10:42:40 -0500 (EST) Received: by mail-pf0-f199.google.com with SMTP id 80so27211781pfy.2 for ; Thu, 16 Feb 2017 07:42:40 -0800 (PST) Received: from mga03.intel.com (mga03.intel.com. [134.134.136.65]) by mx.google.com with ESMTPS id y9si7247135pge.356.2017.02.16.07.42.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 07:42:39 -0800 (PST) Subject: Re: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear() References: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> From: Dave Hansen Message-ID: <68216ac2-e194-30fa-9dcb-2020e8953bf5@linux.intel.com> Date: Thu, 16 Feb 2017 07:42:34 -0800 MIME-Version: 1.0 In-Reply-To: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dave Jiang , akpm@linux-foundation.org Cc: keescook@google.com, mawilcox@microsoft.com, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, kirill.shutemov@linux.intel.com, jack@suse.com, dan.j.williams@intel.com, linux-ext4@vger.kernel.org, ross.zwisler@linux.intel.com, vbabka@suse.cz, alexander.kapshuk@gmail.com On 02/15/2017 12:31 PM, Dave Jiang wrote: > The fix introduced by e4decc90 to fix the UP case for 32bit x86, however > that broke the SMP case that was working previously. Add ifdef so the dummy > function only show up for 32bit UP case only. Could you elaborate a bit on how it broke things? > Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build Which tree is that in, btw? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org