All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]
Date: Thu, 24 Nov 2016 07:27:33 +0000	[thread overview]
Message-ID: <6825.1479972453@warthog.procyon.org.uk> (raw)
In-Reply-To: <D1A5E76A-5739-42FE-A451-B49CD1699DB0@dilger.ca>

Andreas Dilger <adilger@dilger.ca> wrote:

> > +		case S_IFCHR:	printf(" character special file\n");	ft = 'c'; break;
> 
> This will overflow 80 columns.  Could use just "character special"?
> 
> > +		case S_IFDIR:	printf(" directory\n");			ft = 'd'; break;
> > +		case S_IFBLK:	printf(" block special file\n");	ft = 'b'; break;
> > +		case S_IFREG:	printf(" regular file\n");		ft = '-'; break;
> > +		case S_IFLNK:	printf(" symbolic link\n");		ft = 'l'; break;
> 
> Having these all as single-word items would make it easier to parse for
> test programs.  Same with "IO Block:" -> "Blocksize:".  Not a huge deal.

Try doing "stat /dev/null".

David

WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Andreas Dilger <adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>
Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]
Date: Thu, 24 Nov 2016 07:27:33 +0000	[thread overview]
Message-ID: <6825.1479972453@warthog.procyon.org.uk> (raw)
In-Reply-To: <D1A5E76A-5739-42FE-A451-B49CD1699DB0-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>

Andreas Dilger <adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org> wrote:

> > +		case S_IFCHR:	printf(" character special file\n");	ft = 'c'; break;
> 
> This will overflow 80 columns.  Could use just "character special"?
> 
> > +		case S_IFDIR:	printf(" directory\n");			ft = 'd'; break;
> > +		case S_IFBLK:	printf(" block special file\n");	ft = 'b'; break;
> > +		case S_IFREG:	printf(" regular file\n");		ft = '-'; break;
> > +		case S_IFLNK:	printf(" symbolic link\n");		ft = 'l'; break;
> 
> Having these all as single-word items would make it easier to parse for
> test programs.  Same with "IO Block:" -> "Blocksize:".  Not a huge deal.

Try doing "stat /dev/null".

David

  parent reply	other threads:[~2016-11-24  7:30 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23  0:55 [RFC][PATCH 0/4] Enhanced file stat system call [ver #3] David Howells
2016-11-23  0:55 ` David Howells
2016-11-23  0:55 ` [PATCH 1/4] statx: Add a system call to make enhanced file info available " David Howells
2016-11-23  8:37   ` Michael Kerrisk (man-pages)
2016-11-23 22:42     ` Andreas Dilger
2016-11-23 22:42       ` Andreas Dilger
2016-11-23 22:57     ` Andreas Dilger
2016-11-23 22:57       ` Andreas Dilger
2016-11-24  8:13       ` Michael Kerrisk (man-pages)
2016-11-24  8:13         ` Michael Kerrisk (man-pages)
2016-11-24  2:08   ` Andreas Dilger
2016-11-24  2:08     ` Andreas Dilger
2016-11-24  7:27   ` David Howells [this message]
2016-11-24  7:27     ` David Howells
2016-12-04  4:00   ` Al Viro
2016-12-04  4:38   ` Al Viro
2016-12-04 16:05     ` Al Viro
2016-12-04 17:33     ` Al Viro
2016-12-04 17:33       ` Al Viro
2016-12-05 14:49       ` Miklos Szeredi
2016-12-05 14:49         ` Miklos Szeredi
2016-12-05 15:37     ` David Howells
2016-12-05 15:37       ` David Howells
2016-11-23  0:55 ` [PATCH 2/4] statx: Ext4: Return enhanced file attributes " David Howells
2016-11-23 17:59   ` Andreas Dilger
2016-11-23 17:59     ` Andreas Dilger
2016-11-23  0:56 ` [PATCH 3/4] statx: NFS: " David Howells
2016-11-23  0:56 ` [PATCH 4/4] statx: AFS: " David Howells
2016-11-23  0:56   ` David Howells
2016-11-24  2:06   ` Andreas Dilger
2016-11-24  2:06     ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6825.1479972453@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=adilger@dilger.ca \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.