All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Aaron Lewis <aaronlewis@google.com>, kvm@vger.kernel.org
Cc: jmattson@google.com, seanjc@google.com
Subject: Re: [kvm-unit-tests PATCH 00/14] Run access test in an L2 guest
Date: Thu, 11 Nov 2021 18:51:54 +0100	[thread overview]
Message-ID: <682754b9-a402-e992-7318-48844a3da20c@redhat.com> (raw)
In-Reply-To: <20211110212001.3745914-1-aaronlewis@google.com>

On 11/10/21 22:19, Aaron Lewis wrote:
> The motivation behind this change is to test the routing logic when an
> exception occurs in an L2 guest and ensure the exception goes to the
> correct place.  For example, if an exception occurs in L2, does L1 want
> to get involved, or L0, or do niether of them care about it and leave
> it to L2 to handle.  Test that the exception doesn't end up going to L1
> When L1 didn't ask for it.  This was occurring before commit 18712c13709d
> ("KVM: nVMX: Use vmx_need_pf_intercept() when deciding if L0 wants a #PF")
> fixed the issue.  Without that fix, running
> vmx_pf_exception_test_reduced_maxphyaddr with allow_smaller_maxphyaddr=Y
> would have resulted in the test failing with the following error:
> 
> x86/vmx_tests.c:10698: assert failed: false: Unexpected exit to L1,
> exit_reason: VMX_EXC_NMI (0x0)
> 
> This series only tests the routing logic for #PFs.  A future
> series will address other exceptions, however, getting #PF testing in
> place is a big enough chunk that the other exceptions will be submitted
> seperately (in a future series).
> 
> This series is dependant on Paolo's changes (inlcuded). Without them,
> running ac_test_run() on one of the userspace test fails.  Of note:  the
> commit ("x86: get rid of ring0stacktop") has been updated to include a fix
> for a compiler error to get it building on clang.
> 
> This series is also dependant on the commit ("x86: Look up the PTEs rather
> than assuming them").  This was sent out for review seperately, however,
> it is needed to get ac_test_run() running on a different cr3 than the one
> access_test runs on, so it is included here as well.  This is also v2 of
> that commit.  While preparing this series a review came in, so I just
> included the changes here.

Queued, thanks.

Paolo


      parent reply	other threads:[~2021-11-11 17:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 21:19 [kvm-unit-tests PATCH 00/14] Run access test in an L2 guest Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 01/14] x86: cleanup handling of 16-byte GDT descriptors Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 02/14] x86: fix call to set_gdt_entry Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 03/14] unify field names and definitions for GDT descriptors Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 04/14] replace tss_descr global with a function Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 05/14] x86: Move IDT to desc.c Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 06/14] x86: unify name of 32-bit and 64-bit GDT Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 07/14] x86: get rid of ring0stacktop Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 08/14] x86: Move 64-bit GDT and TSS to desc.c Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 09/14] x86: Move 32-bit " Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 10/14] x86: Look up the PTEs rather than assuming them Aaron Lewis
2021-11-29 19:43   ` Babu Moger
2021-11-29 20:43     ` Sean Christopherson
2021-11-29 21:04       ` Babu Moger
2021-11-29 21:30       ` Babu Moger
2021-11-10 21:19 ` [kvm-unit-tests PATCH 11/14] x86: Prepare access test for running in L2 Aaron Lewis
2021-11-10 21:19 ` [kvm-unit-tests PATCH 12/14] x86: Fix tabs in access.c Aaron Lewis
2021-11-10 21:20 ` [kvm-unit-tests PATCH 13/14] x86: Clean up the global, page_table_levels, " Aaron Lewis
2021-11-10 21:20 ` [kvm-unit-tests PATCH 14/14] x86: Add tests that run ac_test_run() in an L2 guest Aaron Lewis
2021-11-11 17:51 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=682754b9-a402-e992-7318-48844a3da20c@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aaronlewis@google.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.