From: Murali Karicheri <m-karicheri2@ti.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-api@vger.kernel.org>, <nsekhar@ti.com>,
<vinicius.gomes@intel.com>, <kuznet@ms2.inr.ac.ru>
Subject: Re: [net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR
Date: Mon, 17 Aug 2020 16:58:39 -0400 [thread overview]
Message-ID: <682a636a-a42b-f40d-853c-3ae7d3c4bd82@ti.com> (raw)
In-Reply-To: <20200816154608.0fe0917b@hermes.lan>
On 8/16/20 6:46 PM, Stephen Hemminger wrote:
> On Thu, 6 Aug 2020 16:37:11 -0400
> Murali Karicheri <m-karicheri2@ti.com> wrote:
>
>> +
>
>> + print_int(PRINT_ANY,
>> + "proto",
>> + "proto %d ",
>> + rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));
>
> Since this unsigned value, you probably want to use print_uint, or print_hhu.
> Also please put as many arguments on one line that will fit in 80 (to 90) characters.
>
> if (tb[IFLA_HSR_PROTOCOL])
> print_hhu(PRINT_ANY, "proto", "proto %hhu ",
> rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));
>
Ok. Will send v5 shortly for this.
--
Murali Karicheri
Texas Instruments
next prev parent reply other threads:[~2020-08-17 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 20:37 [net-next iproute2 PATCH v4 0/2] iplink: hsr: add support for creating PRP device Murali Karicheri
2020-08-06 20:37 ` [net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR Murali Karicheri
2020-08-16 22:46 ` Stephen Hemminger
2020-08-17 20:58 ` Murali Karicheri [this message]
2020-08-06 20:37 ` [net-next iproute2 PATCH v4 2/2] ip: iplink: prp: update man page for new parameter Murali Karicheri
2020-08-10 15:43 ` [net-next iproute2 PATCH v4 0/2] iplink: hsr: add support for creating PRP device Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682a636a-a42b-f40d-853c-3ae7d3c4bd82@ti.com \
--to=m-karicheri2@ti.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=stephen@networkplumber.org \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.