From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v5 18/20] PM / devfreq: tegra30: Define ACTMON_DEV_CTRL_STOP Date: Wed, 31 Jul 2019 13:55:21 +0300 Message-ID: <682c7b5d-eace-8c6a-6117-4b9b6d4e82f8@gmail.com> References: <20190730162236.6063-1-digetx@gmail.com> <20190730162236.6063-19-digetx@gmail.com> <033a342c-ffd6-fa51-a9a2-daac36b195f9@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <033a342c-ffd6-fa51-a9a2-daac36b195f9@samsung.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Chanwoo Choi , Thierry Reding , MyungJoo Ham , Kyungmin Park , Jonathan Hunter , Tomeu Vizoso Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org 31.07.2019 3:37, Chanwoo Choi пишет: > On 19. 7. 31. 오전 1:22, Dmitry Osipenko wrote: >> Add verbose definition for the client's device control register value that >> makes ACTMON to stop monitoring of the device. >> >> Suggested-by: Chanwoo Choi >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/devfreq/tegra30-devfreq.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c >> index 3543fba74b52..8adc0ff48b45 100644 >> --- a/drivers/devfreq/tegra30-devfreq.c >> +++ b/drivers/devfreq/tegra30-devfreq.c >> @@ -35,6 +35,8 @@ >> #define ACTMON_DEV_CTRL_CONSECUTIVE_ABOVE_WMARK_EN BIT(30) >> #define ACTMON_DEV_CTRL_ENB BIT(31) >> >> +#define ACTMON_DEV_CTRL_STOP 0x00000000 >> + >> #define ACTMON_DEV_UPPER_WMARK 0x4 >> #define ACTMON_DEV_LOWER_WMARK 0x8 >> #define ACTMON_DEV_INIT_AVG 0xc >> @@ -714,7 +716,7 @@ static void tegra_actmon_configure_device(struct tegra_devfreq *tegra, >> >> static void tegra_actmon_stop_device(struct tegra_devfreq_device *dev) >> { >> - device_writel(dev, 0x00000000, ACTMON_DEV_CTRL); >> + device_writel(dev, ACTMON_DEV_CTRL_STOP, ACTMON_DEV_CTRL); >> device_writel(dev, ACTMON_INTR_STATUS_CLEAR, ACTMON_DEV_INTR_STATUS); >> } >> >> > > I think that you can combine it to patch11. > When combining it to patch11, don't need to add the suggested-by tag. > Thanks. > Alright, will combine them in the next revision which I'll make once the rest of the patches will be reviewed.