From: Arnout Vandecappelle <arnout@mind.be>
To: Norbert Lange <nolange79@gmail.com>, buildroot@buildroot.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: Re: [Buildroot] [PATCH v4 2/3] package/zstd: Change Build options
Date: Wed, 4 Aug 2021 16:31:05 +0200 [thread overview]
Message-ID: <682f3d33-c5ab-b8b2-2dd4-d5f59c360a6c@mind.be> (raw)
In-Reply-To: <20210617091456.272611-5-nolange79@gmail.com>
On 17/06/2021 11:14, Norbert Lange wrote:
> Disable the legacy format, these are just needed for
> decompressing files created with pre-release version.
>
> Use Buildroot's setting for optimization, zstd's build system
> overrides CFLAGS, but MOREFLAGS can override again.
> Quick tests show that using -O2 (like buildroot)
> is actually a little faster than -O3 on x86_64 Atoms.
>
> Signed-off-by: Norbert Lange <nolange79@gmail.com>
Applied to master, thanks. I just rewrote the commit message a little (in
particular, the subject line gave no indication that this patch is actually
fixing something).
Regards,
Arnout
> ---
> v2->v3:
> * Remove ZSTD_OPTS_MOREFLAGS variable
> ---
> package/zstd/zstd.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/zstd/zstd.mk b/package/zstd/zstd.mk
> index 5674e85bfe..58b0d0099e 100644
> --- a/package/zstd/zstd.mk
> +++ b/package/zstd/zstd.mk
> @@ -13,6 +13,7 @@ ZSTD_CPE_ID_VENDOR = facebook
> ZSTD_CPE_ID_PRODUCT = zstandard
>
> ZSTD_OPTS += PREFIX=/usr
> +ZSTD_OPTS += ZSTD_LEGACY_SUPPORT=0
>
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> ZSTD_DEPENDENCIES += zlib
> @@ -35,6 +36,9 @@ else
> ZSTD_OPTS += HAVE_LZ4=0
> endif
>
> +# zstd will append -O3 after $(CFLAGS), use MOREFLAGS to override again
> +ZSTD_OPTS += MOREFLAGS="$(TARGET_OPTIMIZATION)"
> +
> ZSTD_BUILD_PROG_TARGET = zstd-release
>
> ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-04 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 9:14 [Buildroot] [PATCH v3 1/3] package/zstd: rework build and install Norbert Lange
2021-06-17 9:14 ` [Buildroot] [PATCH v3 2/3] package/zstd: Change Build options Norbert Lange
2021-06-17 9:14 ` [Buildroot] [PATCH v3 3/3] package/zstd: Prefer dynamically linked tool Norbert Lange
2021-06-17 9:14 ` [Buildroot] [PATCH v4 1/3] package/zstd: rework build and install Norbert Lange
2021-08-04 13:01 ` Arnout Vandecappelle
2021-08-04 21:51 ` Norbert Lange
2021-06-17 9:14 ` [Buildroot] [PATCH v4 2/3] package/zstd: Change Build options Norbert Lange
2021-08-04 14:31 ` Arnout Vandecappelle [this message]
2021-06-17 9:14 ` [Buildroot] [PATCH v4 3/3] package/zstd: Prefer dynamically linked tool Norbert Lange
2021-08-04 14:32 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682f3d33-c5ab-b8b2-2dd4-d5f59c360a6c@mind.be \
--to=arnout@mind.be \
--cc=andrew.smirnov@gmail.com \
--cc=buildroot@buildroot.org \
--cc=nolange79@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.