From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935408AbcJ0A2j (ORCPT ); Wed, 26 Oct 2016 20:28:39 -0400 Received: from vern.gendns.com ([206.190.152.46]:40375 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932430AbcJ0A2g (ORCPT ); Wed, 26 Oct 2016 20:28:36 -0400 Subject: Re: [PATCH] ARM: davinci: Add full regulator constraints for non-DT boot To: ahaslam@baylibre.com, nsekhar@ti.com, khilman@kernel.org References: <20161026194155.14304-1-ahaslam@baylibre.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: David Lechner Message-ID: <6831ba9f-12a6-81fc-f34c-7e658f154cd6@lechnology.com> Date: Wed, 26 Oct 2016 19:28:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161026194155.14304-1-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2016 02:41 PM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > The phy framework requests an optional "phy" regulator. If it does > not find one, it returns -EPROBE_DEFER. In the case of non-DT boot > for the omap138-lcdk board, this would prevent the usb11 phy to probe > correctly and ohci would not enumerate. > > By calling "regulator_has_full_constraints", An error would be returned > instead of DEFER for the regulator, and the probe of the phy driver can > continue normally without a regulator. > > Signed-off-by: Axel Haslam > --- > > This applies cleanly after David's recent patches: > > [PATCH v6 0/5] da8xx USB PHY platform devices and clocks > https://lkml.org/lkml/2016/10/25/867 > Applies cleanly on v7 as well. And actually, this should apply cleanly even without my patches. From mboxrd@z Thu Jan 1 00:00:00 1970 From: david@lechnology.com (David Lechner) Date: Wed, 26 Oct 2016 19:28:37 -0500 Subject: [PATCH] ARM: davinci: Add full regulator constraints for non-DT boot In-Reply-To: <20161026194155.14304-1-ahaslam@baylibre.com> References: <20161026194155.14304-1-ahaslam@baylibre.com> Message-ID: <6831ba9f-12a6-81fc-f34c-7e658f154cd6@lechnology.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/26/2016 02:41 PM, ahaslam at baylibre.com wrote: > From: Axel Haslam > > The phy framework requests an optional "phy" regulator. If it does > not find one, it returns -EPROBE_DEFER. In the case of non-DT boot > for the omap138-lcdk board, this would prevent the usb11 phy to probe > correctly and ohci would not enumerate. > > By calling "regulator_has_full_constraints", An error would be returned > instead of DEFER for the regulator, and the probe of the phy driver can > continue normally without a regulator. > > Signed-off-by: Axel Haslam > --- > > This applies cleanly after David's recent patches: > > [PATCH v6 0/5] da8xx USB PHY platform devices and clocks > https://lkml.org/lkml/2016/10/25/867 > Applies cleanly on v7 as well. And actually, this should apply cleanly even without my patches.