All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/2] tcg: Restart after TB code generation overflow
Date: Tue, 16 Apr 2019 12:47:25 -0500	[thread overview]
Message-ID: <6860567d-8678-783e-e001-1dd53785c84a@redhat.com> (raw)
In-Reply-To: <20190416083150.19649-3-richard.henderson@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On 4/16/19 3:31 AM, Richard Henderson wrote:
> If a TB generates too much code, try again with fewer insns.
> 
> Fixes: https://bugs.launchpad.net/bugs/1824853
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  accel/tcg/translate-all.c | 39 +++++++++++++++++++++++++++++++++------
>  tcg/tcg.c                 |  4 ++++
>  2 files changed, 37 insertions(+), 6 deletions(-)
> 

> +             * Try again with half as many insns as we attempted this time.
> +             * If a single insn overflows, there's a bug somewhere...
> +             */
> +            max_insns = tb->icount;
> +qemu_log("TB overflow: pc=%lx insns=%d\n", (unsigned long)pc, max_insns);

Leftover debugging? Or should it be kept but properly indented?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-04-16 17:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16  8:31 [Qemu-devel] [PATCH 0/2] tcg: Fix launchpad 1824853 Richard Henderson
2019-04-16  8:31 ` [Qemu-devel] [PATCH 1/2] tcg: Hoist max_insns computation to tb_gen_code Richard Henderson
2019-04-19 21:01   ` Alistair Francis
2019-04-19 21:01     ` Alistair Francis
2019-04-16  8:31 ` [Qemu-devel] [PATCH 2/2] tcg: Restart after TB code generation overflow Richard Henderson
2019-04-16 17:47   ` Eric Blake [this message]
2019-04-16 17:55     ` Philippe Mathieu-Daudé
2019-04-16 18:48     ` Richard Henderson
2019-04-16 17:25 ` [Qemu-devel] [PATCH 0/2] tcg: Fix launchpad 1824853 Philippe Mathieu-Daudé
2019-04-19 23:07 ` Alex Bennée
2019-04-20  1:38   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6860567d-8678-783e-e001-1dd53785c84a@redhat.com \
    --to=eblake@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.