All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Kang Kai <Kai.Kang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] Disable build qt related packagegroups on mips64 with 64 bits userspace
Date: Fri, 28 Jun 2013 10:53:44 +0100	[thread overview]
Message-ID: <6864785.i8K3q4aBBb@helios> (raw)
In-Reply-To: <1372412549.9930.248.camel@ted>

On Friday 28 June 2013 10:42:29 Richard Purdie wrote:
> On Fri, 2013-06-28 at 17:33 +0800, Kang Kai wrote:
> > On 2013年06月28日 17:00, Paul Eggleton wrote:
> > > Hi Kai,
> > > 
> > > On Friday 28 June 2013 15:48:47 Kai Kang wrote:
> > >> Because qt could not be built on mips64 with 64 bits userspace, set
> > >> COMPATIBLE_HOST for qt related packagegroups to disable them on mips64
> > >> with 64 bit userspace too.
> > >> 
> > >> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> > >> ---
> > >> 
> > >>   .../packagegroups/packagegroup-core-qt.bb          |    3 +++
> > >>   .../packagegroups/packagegroup-core-qt4e.bb        |    3 +++
> > >>   .../packagegroup-qt-toolchain-target.inc           |    3 +++
> > >>   3 files changed, 9 insertions(+), 0 deletions(-)
> > >> 
> > >> diff --git a/meta/recipes-qt/packagegroups/packagegroup-core-qt.bb
> > >> b/meta/recipes-qt/packagegroups/packagegroup-core-qt.bb index
> > >> 315df33..c993242 100644
> > >> --- a/meta/recipes-qt/packagegroups/packagegroup-core-qt.bb
> > >> +++ b/meta/recipes-qt/packagegroups/packagegroup-core-qt.bb
> > >> @@ -6,6 +6,9 @@ DESCRIPTION = "Qt package groups"
> > >> 
> > >>   LICENSE = "MIT"
> > >>   PR = "r4"
> > >> 
> > >> +# Qt4 could NOT be built on MIPS64 with 64 bits userspace
> > >> +COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
> > >> +
> > >> 
> > >>   inherit packagegroup
> > >>   
> > >>   PACKAGES = "${PN}-demoapps"
> > >> 
> > >> diff --git a/meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb
> > >> b/meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb index
> > >> 9263828..6ef844f 100644
> > >> --- a/meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb
> > >> +++ b/meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb
> > >> @@ -2,6 +2,9 @@ SUMMARY = "Qt for Embedded Linux (Qt without X11)"
> > >> 
> > >>   PR = "r2"
> > >>   LICENSE = "MIT"
> > >> 
> > >> +# Qt4 could NOT be built on MIPS64 with 64 bits userspace
> > >> +COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
> > >> +
> > >> 
> > >>   inherit packagegroup
> > >>   
> > >>   # For backwards compatibility after rename
> > >> 
> > >> diff --git
> > >> a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
> > >> b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
> > >> index
> > >> 8413eec..fc1ccba 100644
> > >> ---
> > >> a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
> > >> +++
> > >> b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
> > >> @@ -1,5 +1,8 @@
> > >> 
> > >>   LICENSE = "MIT"
> > >> 
> > >> +# Qt4 could NOT be built on MIPS64 with 64 bits userspace
> > >> +COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
> > >> +
> > >> 
> > >>   inherit packagegroup
> > >>   
> > >>   PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
> > > 
> > > I'm fine with the other change; the question is is this one needed in
> > > addition? Since the packagegroup-*qt* recipes reference packages from
> > > Qt which itself inherits qt4x11/qt4e bbclasses, surely trying to build
> > > these will immediately fail for mips64 anyway?
> > 
> > Yes, it will fail immediately. What I want to do is to underline these
> > packagegroups' build platform.
> > If you believe that they are redundant, I retrieve the patch 2/2.
> 
> At a guess the one advantage of this is to clean up what "bitbake world"
> would show?

OK, I don't have any strong objections if it does help in some way.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


      reply	other threads:[~2013-06-28  9:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28  7:48 [PATCH 0/2] Disable qt and related packages on mips64 with 64 bits userspace Kai Kang
2013-06-28  7:48 ` [PATCH 1/2] qt4*.bbclass: disable build qt " Kai Kang
2013-06-28  7:48 ` [PATCH 2/2] Disable build qt related packagegroups " Kai Kang
2013-06-28  9:00   ` Paul Eggleton
2013-06-28  9:33     ` Kang Kai
2013-06-28  9:42       ` Richard Purdie
2013-06-28  9:53         ` Paul Eggleton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6864785.i8K3q4aBBb@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=Kai.Kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.