From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD6CC636D4 for ; Wed, 15 Feb 2023 11:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233816AbjBOLvg (ORCPT ); Wed, 15 Feb 2023 06:51:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233794AbjBOLve (ORCPT ); Wed, 15 Feb 2023 06:51:34 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F014513C; Wed, 15 Feb 2023 03:51:32 -0800 (PST) Received: from [192.168.1.90] (unknown [86.120.32.152]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 319A86602181; Wed, 15 Feb 2023 11:51:29 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676461890; bh=QSCp6bo6FjxCSjfy/l3o4z89Z1La9kTv6gN3Uu+EpL4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=A4rqdwtauXFIbQbOGHfLvjjQ6dlZiEqLF0CG/sWghsauCpAP2mXYKVMwkBAi8uEqZ WyAnVKG1j4VGABIVUzHJKddu8kq1OX83D1bLDMHtGsHI0oTkwtBXfMA4Hpi9kWPQHQ SEL0utAZxVaMKf2Rn3/aUwiy2nTVGox5FI2O/ZIxZdnaanRmdNZIk8hG7PXJMdadHn 7p01MjXuIbSf0cggW1k1sHvKuqRRXNk2UdSqWWaS2ECm5wmKJXU5+bWLLesiDLkBTy 0Qf3noLv63LboE1TWJ1VuVVP0d2wQjP+LjbDiK6j9PO8YUdgtvqbiop5Cg/d3aw3Ar FDekpJ+BswxCw== Message-ID: <68708ef5-9a7f-b7e5-a7a0-e08f6d5ae3a3@collabora.com> Date: Wed, 15 Feb 2023 13:51:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 08/12] net: stmmac: Add glue layer for StarFive JH7100 SoC Content-Language: en-US To: Emil Renner Berthing Cc: Andrew Lunn , Lee Jones , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Emil Renner Berthing , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Sagar Kadam , Yanhong Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20230211031821.976408-1-cristian.ciocaltea@collabora.com> <20230211031821.976408-9-cristian.ciocaltea@collabora.com> From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/15/23 13:20, Emil Renner Berthing wrote: > On Wed, 15 Feb 2023 at 01:09, Cristian Ciocaltea > wrote: >> >> On 2/11/23 18:11, Andrew Lunn wrote: >>>> + >>>> +#define JH7100_SYSMAIN_REGISTER28 0x70 >>>> +/* The value below is not a typo, just really bad naming by StarFive ¯\_(ツ)_/¯ */ >>>> +#define JH7100_SYSMAIN_REGISTER49 0xc8 >>> >>> Seems like the comment should be one line earlier? > > Well yes, the very generic register names are also bad, but this > comment refers to the fact that it kind of makes sense that register > 28 has the offset > 28 * 4 bytes pr. register = 0x70 > ..but then register 49 is oddly out of place at offset 0xc8 instead of > 49 * 4 bytes pr. register = 0xc4 > >>> There is value in basing the names on the datasheet, but you could >>> append something meaningful on the end: >>> >>> #define JH7100_SYSMAIN_REGISTER49_DLYCHAIN 0xc8 >> >> Unfortunately the JH7100 datasheet I have access to doesn't provide any >> information regarding the SYSCTRL-MAINSYS related registers. Maybe Emil >> could provide some details here? > > This is reverse engineered from the auto generated headers in their u-boot: > https://github.com/starfive-tech/u-boot/blob/JH7100_VisionFive_devel/arch/riscv/include/asm/arch-jh7100/syscon_sysmain_ctrl_macro.h > > Christian, I'm happy that you're working on this, but mess like this > and waiting for the non-coherent dma to be sorted is why I didn't send > it upstream yet. Thank you for clarifying this and for all the work you have done so far, Emil! If you don't mind, I would be glad to continue helping with this mainlining effort. >>>> + if (!of_property_read_u32(np, "starfive,gtxclk-dlychain", >xclk_dlychain)) { >>>> + ret = regmap_write(sysmain, JH7100_SYSMAIN_REGISTER49, gtxclk_dlychain); >>>> + if (ret) >>>> + return dev_err_probe(dev, ret, "error selecting gtxclk delay chain\n"); >>>> + } >>> >>> You should probably document that if starfive,gtxclk-dlychain is not >>> found in the DT blob, the value for the delay chain is undefined. It >>> would actually be better to define it, set it to 0 for example. That >>> way, you know you don't have any dependency on the bootloader for >>> example. >> >> Sure, I will set it to 0. >> >>> >>> Andrew >> >> Thanks for reviewing, >> Cristian >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73BE6C636CC for ; Wed, 15 Feb 2023 11:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pw1IxSJEHLmRloTBrym8eko6TwGVBqXh9RlcOe6O6vY=; b=G09A4sKSXzTTOp yrh9b34mWKVDm7uPI3xyGJbNvkI/DpJ4xSMpkTZhkgMNHDF8oiNffvo/I8uMwo8muDpr5OOMAHzgn ZFKxIMLXHTJTokLJt4wes4MNF6NH3hKbovWgQXMt80zqV9D3IbelOspBB99fu9hHuCkiI4vCZm0Zf pewDAC/m5UWWLbyMKO5GUy6qhLasKgdRjJ7xxyIj8YzViD+Ns0hC6yvbbdUFNC+K05KCpZQMZVuis MTIw4SxXpEhSAykzYE+6VvTGscYREes7PpobsEIHgWvNUswz7zoZqlQCgx9+B1k/Tv2WRB9Hnb/hB oezqlZPvZRd/GAtLB6Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSGKA-005f7x-HM; Wed, 15 Feb 2023 11:51:46 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSGJz-005f4p-0a; Wed, 15 Feb 2023 11:51:36 +0000 Received: from [192.168.1.90] (unknown [86.120.32.152]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 319A86602181; Wed, 15 Feb 2023 11:51:29 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676461890; bh=QSCp6bo6FjxCSjfy/l3o4z89Z1La9kTv6gN3Uu+EpL4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=A4rqdwtauXFIbQbOGHfLvjjQ6dlZiEqLF0CG/sWghsauCpAP2mXYKVMwkBAi8uEqZ WyAnVKG1j4VGABIVUzHJKddu8kq1OX83D1bLDMHtGsHI0oTkwtBXfMA4Hpi9kWPQHQ SEL0utAZxVaMKf2Rn3/aUwiy2nTVGox5FI2O/ZIxZdnaanRmdNZIk8hG7PXJMdadHn 7p01MjXuIbSf0cggW1k1sHvKuqRRXNk2UdSqWWaS2ECm5wmKJXU5+bWLLesiDLkBTy 0Qf3noLv63LboE1TWJ1VuVVP0d2wQjP+LjbDiK6j9PO8YUdgtvqbiop5Cg/d3aw3Ar FDekpJ+BswxCw== Message-ID: <68708ef5-9a7f-b7e5-a7a0-e08f6d5ae3a3@collabora.com> Date: Wed, 15 Feb 2023 13:51:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 08/12] net: stmmac: Add glue layer for StarFive JH7100 SoC Content-Language: en-US To: Emil Renner Berthing Cc: Andrew Lunn , Lee Jones , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Emil Renner Berthing , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Sagar Kadam , Yanhong Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20230211031821.976408-1-cristian.ciocaltea@collabora.com> <20230211031821.976408-9-cristian.ciocaltea@collabora.com> From: Cristian Ciocaltea In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_035135_291313_A8909C95 X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMi8xNS8yMyAxMzoyMCwgRW1pbCBSZW5uZXIgQmVydGhpbmcgd3JvdGU6Cj4gT24gV2VkLCAx NSBGZWIgMjAyMyBhdCAwMTowOSwgQ3Jpc3RpYW4gQ2lvY2FsdGVhCj4gPGNyaXN0aWFuLmNpb2Nh bHRlYUBjb2xsYWJvcmEuY29tPiB3cm90ZToKPj4KPj4gT24gMi8xMS8yMyAxODoxMSwgQW5kcmV3 IEx1bm4gd3JvdGU6Cj4+Pj4gKwo+Pj4+ICsjZGVmaW5lIEpINzEwMF9TWVNNQUlOX1JFR0lTVEVS MjggMHg3MAo+Pj4+ICsvKiBUaGUgdmFsdWUgYmVsb3cgaXMgbm90IGEgdHlwbywganVzdCByZWFs bHkgYmFkIG5hbWluZyBieSBTdGFyRml2ZSDCr1xfKOODhClfL8KvICovCj4+Pj4gKyNkZWZpbmUg Skg3MTAwX1NZU01BSU5fUkVHSVNURVI0OSAweGM4Cj4+Pgo+Pj4gU2VlbXMgbGlrZSB0aGUgY29t bWVudCBzaG91bGQgYmUgb25lIGxpbmUgZWFybGllcj8KPiAKPiBXZWxsIHllcywgdGhlIHZlcnkg Z2VuZXJpYyByZWdpc3RlciBuYW1lcyBhcmUgYWxzbyBiYWQsIGJ1dCB0aGlzCj4gY29tbWVudCBy ZWZlcnMgdG8gdGhlIGZhY3QgdGhhdCBpdCBraW5kIG9mIG1ha2VzIHNlbnNlIHRoYXQgcmVnaXN0 ZXIKPiAyOCBoYXMgdGhlIG9mZnNldAo+ICAgIDI4ICogNCBieXRlcyBwci4gcmVnaXN0ZXIgPSAw eDcwCj4gLi5idXQgdGhlbiByZWdpc3RlciA0OSBpcyBvZGRseSBvdXQgb2YgcGxhY2UgYXQgb2Zm c2V0IDB4YzggaW5zdGVhZCBvZgo+ICAgIDQ5ICogNCBieXRlcyBwci4gcmVnaXN0ZXIgPSAweGM0 Cj4gCj4+PiBUaGVyZSBpcyB2YWx1ZSBpbiBiYXNpbmcgdGhlIG5hbWVzIG9uIHRoZSBkYXRhc2hl ZXQsIGJ1dCB5b3UgY291bGQKPj4+IGFwcGVuZCBzb21ldGhpbmcgbWVhbmluZ2Z1bCBvbiB0aGUg ZW5kOgo+Pj4KPj4+ICNkZWZpbmUgSkg3MTAwX1NZU01BSU5fUkVHSVNURVI0OV9ETFlDSEFJTiAw eGM4Cj4+Cj4+IFVuZm9ydHVuYXRlbHkgdGhlIEpINzEwMCBkYXRhc2hlZXQgSSBoYXZlIGFjY2Vz cyB0byBkb2Vzbid0IHByb3ZpZGUgYW55Cj4+IGluZm9ybWF0aW9uIHJlZ2FyZGluZyB0aGUgU1lT Q1RSTC1NQUlOU1lTIHJlbGF0ZWQgcmVnaXN0ZXJzLiBNYXliZSBFbWlsCj4+IGNvdWxkIHByb3Zp ZGUgc29tZSBkZXRhaWxzIGhlcmU/Cj4gCj4gVGhpcyBpcyByZXZlcnNlIGVuZ2luZWVyZWQgZnJv bSB0aGUgYXV0byBnZW5lcmF0ZWQgaGVhZGVycyBpbiB0aGVpciB1LWJvb3Q6Cj4gaHR0cHM6Ly9n aXRodWIuY29tL3N0YXJmaXZlLXRlY2gvdS1ib290L2Jsb2IvSkg3MTAwX1Zpc2lvbkZpdmVfZGV2 ZWwvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9hcmNoLWpoNzEwMC9zeXNjb25fc3lzbWFpbl9jdHJs X21hY3JvLmgKPiAKPiBDaHJpc3RpYW4sIEknbSBoYXBweSB0aGF0IHlvdSdyZSB3b3JraW5nIG9u IHRoaXMsIGJ1dCBtZXNzIGxpa2UgdGhpcwo+IGFuZCB3YWl0aW5nIGZvciB0aGUgbm9uLWNvaGVy ZW50IGRtYSB0byBiZSBzb3J0ZWQgaXMgd2h5IEkgZGlkbid0IHNlbmQKPiBpdCB1cHN0cmVhbSB5 ZXQuCgpUaGFuayB5b3UgZm9yIGNsYXJpZnlpbmcgdGhpcyBhbmQgZm9yIGFsbCB0aGUgd29yayB5 b3UgaGF2ZSBkb25lIHNvIGZhciwgCkVtaWwhIElmIHlvdSBkb24ndCBtaW5kLCBJIHdvdWxkIGJl IGdsYWQgdG8gY29udGludWUgaGVscGluZyB3aXRoIHRoaXMgCm1haW5saW5pbmcgZWZmb3J0LgoK Pj4+PiArICAgIGlmICghb2ZfcHJvcGVydHlfcmVhZF91MzIobnAsICJzdGFyZml2ZSxndHhjbGst ZGx5Y2hhaW4iLCAmZ3R4Y2xrX2RseWNoYWluKSkgewo+Pj4+ICsgICAgICAgICAgICByZXQgPSBy ZWdtYXBfd3JpdGUoc3lzbWFpbiwgSkg3MTAwX1NZU01BSU5fUkVHSVNURVI0OSwgZ3R4Y2xrX2Rs eWNoYWluKTsKPj4+PiArICAgICAgICAgICAgaWYgKHJldCkKPj4+PiArICAgICAgICAgICAgICAg ICAgICByZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIHJldCwgImVycm9yIHNlbGVjdGluZyBndHhj bGsgZGVsYXkgY2hhaW5cbiIpOwo+Pj4+ICsgICAgfQo+Pj4KPj4+IFlvdSBzaG91bGQgcHJvYmFi bHkgZG9jdW1lbnQgdGhhdCBpZiBzdGFyZml2ZSxndHhjbGstZGx5Y2hhaW4gaXMgbm90Cj4+PiBm b3VuZCBpbiB0aGUgRFQgYmxvYiwgdGhlIHZhbHVlIGZvciB0aGUgZGVsYXkgY2hhaW4gaXMgdW5k ZWZpbmVkLiAgSXQKPj4+IHdvdWxkIGFjdHVhbGx5IGJlIGJldHRlciB0byBkZWZpbmUgaXQsIHNl dCBpdCB0byAwIGZvciBleGFtcGxlLiBUaGF0Cj4+PiB3YXksIHlvdSBrbm93IHlvdSBkb24ndCBo YXZlIGFueSBkZXBlbmRlbmN5IG9uIHRoZSBib290bG9hZGVyIGZvcgo+Pj4gZXhhbXBsZS4KPj4K Pj4gU3VyZSwgSSB3aWxsIHNldCBpdCB0byAwLgo+Pgo+Pj4KPj4+ICAgICAgICBBbmRyZXcKPj4K Pj4gVGhhbmtzIGZvciByZXZpZXdpbmcsCj4+IENyaXN0aWFuCj4+Cj4+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdAo+PiBsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCj4+IGh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlz dApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A535FC636CC for ; Wed, 15 Feb 2023 11:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WSaOLbZkx1nJyCqwEcol5ScWHs65HqcnFIcUnhdk6/w=; b=hCv9el6K1VsOww 2/O317NDLHJPqSBJ14sRCDPPng+A8JiOdNxlgRlM0f0AfTCrNTXkge8LkgQnwj8GFslnrIowTKXN1 TcJzwt548UEj+1Xn5j7CuMR7Mg72yKmATM75IqaHTjYxe3BZNWuDiGthDx8HeTI/GWGgSFICTEthJ xalTXPhdp+KEnOxbJd1zDjy0vnBV5pMmN574xzwueGoaDQzDTABLooYNqmxv9zM6WKmhz2jYSk5ga BtYl/rTAN1i2SBw6mpnC/LTuxMh3hEiK0idXHUYQJWnKz6qU2xF+g/YVE9zsFTqOxEOnhfmaq56WM xGCZx81WJ6xK5I/j7M2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSGK3-005f6T-DG; Wed, 15 Feb 2023 11:51:39 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSGJz-005f4p-0a; Wed, 15 Feb 2023 11:51:36 +0000 Received: from [192.168.1.90] (unknown [86.120.32.152]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 319A86602181; Wed, 15 Feb 2023 11:51:29 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676461890; bh=QSCp6bo6FjxCSjfy/l3o4z89Z1La9kTv6gN3Uu+EpL4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=A4rqdwtauXFIbQbOGHfLvjjQ6dlZiEqLF0CG/sWghsauCpAP2mXYKVMwkBAi8uEqZ WyAnVKG1j4VGABIVUzHJKddu8kq1OX83D1bLDMHtGsHI0oTkwtBXfMA4Hpi9kWPQHQ SEL0utAZxVaMKf2Rn3/aUwiy2nTVGox5FI2O/ZIxZdnaanRmdNZIk8hG7PXJMdadHn 7p01MjXuIbSf0cggW1k1sHvKuqRRXNk2UdSqWWaS2ECm5wmKJXU5+bWLLesiDLkBTy 0Qf3noLv63LboE1TWJ1VuVVP0d2wQjP+LjbDiK6j9PO8YUdgtvqbiop5Cg/d3aw3Ar FDekpJ+BswxCw== Message-ID: <68708ef5-9a7f-b7e5-a7a0-e08f6d5ae3a3@collabora.com> Date: Wed, 15 Feb 2023 13:51:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 08/12] net: stmmac: Add glue layer for StarFive JH7100 SoC Content-Language: en-US To: Emil Renner Berthing Cc: Andrew Lunn , Lee Jones , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Emil Renner Berthing , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Sagar Kadam , Yanhong Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20230211031821.976408-1-cristian.ciocaltea@collabora.com> <20230211031821.976408-9-cristian.ciocaltea@collabora.com> From: Cristian Ciocaltea In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_035135_291313_A8909C95 X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMi8xNS8yMyAxMzoyMCwgRW1pbCBSZW5uZXIgQmVydGhpbmcgd3JvdGU6Cj4gT24gV2VkLCAx NSBGZWIgMjAyMyBhdCAwMTowOSwgQ3Jpc3RpYW4gQ2lvY2FsdGVhCj4gPGNyaXN0aWFuLmNpb2Nh bHRlYUBjb2xsYWJvcmEuY29tPiB3cm90ZToKPj4KPj4gT24gMi8xMS8yMyAxODoxMSwgQW5kcmV3 IEx1bm4gd3JvdGU6Cj4+Pj4gKwo+Pj4+ICsjZGVmaW5lIEpINzEwMF9TWVNNQUlOX1JFR0lTVEVS MjggMHg3MAo+Pj4+ICsvKiBUaGUgdmFsdWUgYmVsb3cgaXMgbm90IGEgdHlwbywganVzdCByZWFs bHkgYmFkIG5hbWluZyBieSBTdGFyRml2ZSDCr1xfKOODhClfL8KvICovCj4+Pj4gKyNkZWZpbmUg Skg3MTAwX1NZU01BSU5fUkVHSVNURVI0OSAweGM4Cj4+Pgo+Pj4gU2VlbXMgbGlrZSB0aGUgY29t bWVudCBzaG91bGQgYmUgb25lIGxpbmUgZWFybGllcj8KPiAKPiBXZWxsIHllcywgdGhlIHZlcnkg Z2VuZXJpYyByZWdpc3RlciBuYW1lcyBhcmUgYWxzbyBiYWQsIGJ1dCB0aGlzCj4gY29tbWVudCBy ZWZlcnMgdG8gdGhlIGZhY3QgdGhhdCBpdCBraW5kIG9mIG1ha2VzIHNlbnNlIHRoYXQgcmVnaXN0 ZXIKPiAyOCBoYXMgdGhlIG9mZnNldAo+ICAgIDI4ICogNCBieXRlcyBwci4gcmVnaXN0ZXIgPSAw eDcwCj4gLi5idXQgdGhlbiByZWdpc3RlciA0OSBpcyBvZGRseSBvdXQgb2YgcGxhY2UgYXQgb2Zm c2V0IDB4YzggaW5zdGVhZCBvZgo+ICAgIDQ5ICogNCBieXRlcyBwci4gcmVnaXN0ZXIgPSAweGM0 Cj4gCj4+PiBUaGVyZSBpcyB2YWx1ZSBpbiBiYXNpbmcgdGhlIG5hbWVzIG9uIHRoZSBkYXRhc2hl ZXQsIGJ1dCB5b3UgY291bGQKPj4+IGFwcGVuZCBzb21ldGhpbmcgbWVhbmluZ2Z1bCBvbiB0aGUg ZW5kOgo+Pj4KPj4+ICNkZWZpbmUgSkg3MTAwX1NZU01BSU5fUkVHSVNURVI0OV9ETFlDSEFJTiAw eGM4Cj4+Cj4+IFVuZm9ydHVuYXRlbHkgdGhlIEpINzEwMCBkYXRhc2hlZXQgSSBoYXZlIGFjY2Vz cyB0byBkb2Vzbid0IHByb3ZpZGUgYW55Cj4+IGluZm9ybWF0aW9uIHJlZ2FyZGluZyB0aGUgU1lT Q1RSTC1NQUlOU1lTIHJlbGF0ZWQgcmVnaXN0ZXJzLiBNYXliZSBFbWlsCj4+IGNvdWxkIHByb3Zp ZGUgc29tZSBkZXRhaWxzIGhlcmU/Cj4gCj4gVGhpcyBpcyByZXZlcnNlIGVuZ2luZWVyZWQgZnJv bSB0aGUgYXV0byBnZW5lcmF0ZWQgaGVhZGVycyBpbiB0aGVpciB1LWJvb3Q6Cj4gaHR0cHM6Ly9n aXRodWIuY29tL3N0YXJmaXZlLXRlY2gvdS1ib290L2Jsb2IvSkg3MTAwX1Zpc2lvbkZpdmVfZGV2 ZWwvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9hcmNoLWpoNzEwMC9zeXNjb25fc3lzbWFpbl9jdHJs X21hY3JvLmgKPiAKPiBDaHJpc3RpYW4sIEknbSBoYXBweSB0aGF0IHlvdSdyZSB3b3JraW5nIG9u IHRoaXMsIGJ1dCBtZXNzIGxpa2UgdGhpcwo+IGFuZCB3YWl0aW5nIGZvciB0aGUgbm9uLWNvaGVy ZW50IGRtYSB0byBiZSBzb3J0ZWQgaXMgd2h5IEkgZGlkbid0IHNlbmQKPiBpdCB1cHN0cmVhbSB5 ZXQuCgpUaGFuayB5b3UgZm9yIGNsYXJpZnlpbmcgdGhpcyBhbmQgZm9yIGFsbCB0aGUgd29yayB5 b3UgaGF2ZSBkb25lIHNvIGZhciwgCkVtaWwhIElmIHlvdSBkb24ndCBtaW5kLCBJIHdvdWxkIGJl IGdsYWQgdG8gY29udGludWUgaGVscGluZyB3aXRoIHRoaXMgCm1haW5saW5pbmcgZWZmb3J0LgoK Pj4+PiArICAgIGlmICghb2ZfcHJvcGVydHlfcmVhZF91MzIobnAsICJzdGFyZml2ZSxndHhjbGst ZGx5Y2hhaW4iLCAmZ3R4Y2xrX2RseWNoYWluKSkgewo+Pj4+ICsgICAgICAgICAgICByZXQgPSBy ZWdtYXBfd3JpdGUoc3lzbWFpbiwgSkg3MTAwX1NZU01BSU5fUkVHSVNURVI0OSwgZ3R4Y2xrX2Rs eWNoYWluKTsKPj4+PiArICAgICAgICAgICAgaWYgKHJldCkKPj4+PiArICAgICAgICAgICAgICAg ICAgICByZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIHJldCwgImVycm9yIHNlbGVjdGluZyBndHhj bGsgZGVsYXkgY2hhaW5cbiIpOwo+Pj4+ICsgICAgfQo+Pj4KPj4+IFlvdSBzaG91bGQgcHJvYmFi bHkgZG9jdW1lbnQgdGhhdCBpZiBzdGFyZml2ZSxndHhjbGstZGx5Y2hhaW4gaXMgbm90Cj4+PiBm b3VuZCBpbiB0aGUgRFQgYmxvYiwgdGhlIHZhbHVlIGZvciB0aGUgZGVsYXkgY2hhaW4gaXMgdW5k ZWZpbmVkLiAgSXQKPj4+IHdvdWxkIGFjdHVhbGx5IGJlIGJldHRlciB0byBkZWZpbmUgaXQsIHNl dCBpdCB0byAwIGZvciBleGFtcGxlLiBUaGF0Cj4+PiB3YXksIHlvdSBrbm93IHlvdSBkb24ndCBo YXZlIGFueSBkZXBlbmRlbmN5IG9uIHRoZSBib290bG9hZGVyIGZvcgo+Pj4gZXhhbXBsZS4KPj4K Pj4gU3VyZSwgSSB3aWxsIHNldCBpdCB0byAwLgo+Pgo+Pj4KPj4+ICAgICAgICBBbmRyZXcKPj4K Pj4gVGhhbmtzIGZvciByZXZpZXdpbmcsCj4+IENyaXN0aWFuCj4+Cj4+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdAo+PiBsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCj4+IGh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK