From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Thu, 26 Dec 2019 11:16:58 +0000 Subject: Re: [PATCH] scsi: don't memset to zero after dma_alloc_coherent Message-Id: <68771eb5-03c4-422b-9956-930a0e3c9de8@cogentembedded.com> List-Id: References: <20191225132327.7121-1-yukuai3@huawei.com> <958ffbe5-f3da-da16-9f2b-05923d13485b@huawei.com> In-Reply-To: <958ffbe5-f3da-da16-9f2b-05923d13485b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: "yukuai (C)" , ysato@users.sourceforge.jp, dalias@libc.org, aacraid@microsemi.com, jejb@linux.ibm.com, martin.petersen@oracle.com, sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, zhengbin13@huawei.com, yi.zhang@huawei.com On 26.12.2019 14:13, yukuai (C) wrote: >>> dma_alloc_coherent already zeros out memory, so memset to zero is not >>> needed. >>> >>> Signed-off-by: yu kuai >>> --- >>>   arch/sh/mm/consistent.c             | 2 -- >> >>     How this one is related to SCSI? >> > Thank you for your response! > I put them in the same patch because I thougt they are the same situation. I'm > sorry if it's not appropriate. I'd recommend to split such patch to (at least) different subsystems, e.g. arch/sh/ part, drivers/scsi/ part. > Yu Kuai MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2810C2D0DA for ; Thu, 26 Dec 2019 11:17:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE2BA2075E for ; Thu, 26 Dec 2019 11:17:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="KnrndgTb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfLZLRM (ORCPT ); Thu, 26 Dec 2019 06:17:12 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:40381 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfLZLRL (ORCPT ); Thu, 26 Dec 2019 06:17:11 -0500 Received: by mail-lj1-f196.google.com with SMTP id u1so24461736ljk.7 for ; Thu, 26 Dec 2019 03:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aH15/cT0heFYqB/O73b1ObuaExtcpJbzvHVltZDRg9o=; b=KnrndgTbgC+oNIE6XF0clvVLd8PM3LoikB+aKjySpuV+msB35GPNyBCGbGYwLvqX9H oGGE5ZuZmzM6NFQv2M6gOWgcp0SVHTAvQqeSrKu8KWO5rIwskN6Kic1yoJM/BBZjhYU0 aVz+G0AGx0EWdQa/5tADzdl1m7OwkzcZ33tguhUul5kbWHlWHfwVz9wEJQgxAMyOK88Z LNm1HR76ofTD0vcEhtUimSRgCZnNbnqEEFP2YYxbz1BLCD8oitVnTMtjPuCp3jnIvONc YJOaumWRIAbQ2g1G6PXH+4E8mEL8Wfpil3le47jmgVaerjQivAULbX0KtC2WFTFW9N/b LRlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aH15/cT0heFYqB/O73b1ObuaExtcpJbzvHVltZDRg9o=; b=KP/3L7YfYRpuT85RGSk47AS8G5EOQjwUR1KyUE2tXp612q6wcVMKxDQ15+/U+A2Qxb PmyElIb0P0D/8g4c6JdYrtxDznAIa75HLRNZqrQbM0f3/r1YfzmXtS950nibFNdjbRve Un9hH8cYtb/qeAU+NNSc6vrUb9Xt88Krm20iY6uUvSZIN0jKFW0/VmfQxM92SXUfJ3cn iSbVoxQeF+zyeI16KApGQ4/BFUisaT9TmIgISLJGg3mjkJL/qYOOsITlL+Hpot08S0Qo b877lNEVOWrEzWEh08WPLB6TzCyS5iPD7KtPgA/OSIYrqv14UXSioMD99k+xp62Fc0B2 QnhA== X-Gm-Message-State: APjAAAV09rR2wRr2uAXqKUaIf2zl/8nldQZeDMagbLGArbDTI2nqgZBy MeUVxqs07X9w1lNeneZ+DGxO9g== X-Google-Smtp-Source: APXvYqzioTsPIZdItBjF2rkZ8V9K+a/TAmQhvWhQznPkKJqf7cfwwFOc0U6kjoSqHvWnMJgGXWznSA== X-Received: by 2002:a2e:9b05:: with SMTP id u5mr25457606lji.59.1577359029381; Thu, 26 Dec 2019 03:17:09 -0800 (PST) Received: from ?IPv6:2a00:1fa0:867:b21c:a50d:bd68:cd46:4921? ([2a00:1fa0:867:b21c:a50d:bd68:cd46:4921]) by smtp.gmail.com with ESMTPSA id c27sm12798426lfh.62.2019.12.26.03.17.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Dec 2019 03:17:08 -0800 (PST) Subject: Re: [PATCH] scsi: don't memset to zero after dma_alloc_coherent To: "yukuai (C)" , ysato@users.sourceforge.jp, dalias@libc.org, aacraid@microsemi.com, jejb@linux.ibm.com, martin.petersen@oracle.com, sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, zhengbin13@huawei.com, yi.zhang@huawei.com References: <20191225132327.7121-1-yukuai3@huawei.com> <958ffbe5-f3da-da16-9f2b-05923d13485b@huawei.com> From: Sergei Shtylyov Message-ID: <68771eb5-03c4-422b-9956-930a0e3c9de8@cogentembedded.com> Date: Thu, 26 Dec 2019 14:16:58 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <958ffbe5-f3da-da16-9f2b-05923d13485b@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.12.2019 14:13, yukuai (C) wrote: >>> dma_alloc_coherent already zeros out memory, so memset to zero is not >>> needed. >>> >>> Signed-off-by: yu kuai >>> --- >>>   arch/sh/mm/consistent.c             | 2 -- >> >>     How this one is related to SCSI? >> > Thank you for your response! > I put them in the same patch because I thougt they are the same situation. I'm > sorry if it's not appropriate. I'd recommend to split such patch to (at least) different subsystems, e.g. arch/sh/ part, drivers/scsi/ part. > Yu Kuai MBR, Sergei