All of lore.kernel.org
 help / color / mirror / Atom feed
From: bvanassche@acm.org (Bart Van Assche)
Subject: [PATCH v3 2/3] nvmet: Export NVMe namespace attributes
Date: Wed, 19 Jun 2019 08:44:41 -0700	[thread overview]
Message-ID: <68786de5-cdd8-c6d8-98a7-8a4310dac789@acm.org> (raw)
In-Reply-To: <yq1a7eeusa5.fsf@oracle.com>

On 6/18/19 9:13 PM, Martin K. Petersen wrote:
> 
> Bart,
> 
>> +	/*
>> +	 * Physical blocks per logical block, 0's based. Is it possible to
>> +	 * extract this information from the filesystem properties?
>> +	 */
>> +	const __le16 ppl0b = cpu_to_le16(0);
> 
> Maybe report the filesystem block size here?
> 
> Otherwise OK.
> 
> Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>

Hi Martin,

Thanks for the review.

Are you perhaps referring to the parameter that can be specified as 
command-line option -b to mkfs? I'm not sure that we should report that 
size as the physical block size since that parameter can be set to a 
value that is much larger than the physical block size of the storage 
medium (in the target system). I'd like to make sure that writes with a 
size of what is reported as physical block size are atomic because that 
is what filesystems (at the initiator side) expect.

Bart.

  reply	other threads:[~2019-06-19 15:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 16:12 [PATCH v3 0/3] NVMe 1.4 Identify Namespace Support Bart Van Assche
2019-06-17 16:12 ` [PATCH v3 1/3] nvme: Introduce NVMe 1.4 Identify Namespace fields in struct nvme_id_ns Bart Van Assche
2019-06-18  7:49   ` Hannes Reinecke
2019-06-17 16:12 ` [PATCH v3 2/3] nvmet: Export NVMe namespace attributes Bart Van Assche
2019-06-18  7:50   ` Hannes Reinecke
2019-06-19  4:13   ` Martin K. Petersen
2019-06-19 15:44     ` Bart Van Assche [this message]
2019-06-21  1:56       ` Martin K. Petersen
2019-06-21 15:19         ` Bart Van Assche
2019-06-24 23:30           ` Martin K. Petersen
2019-06-24 23:51             ` Bart Van Assche
2019-06-20  3:19   ` Chaitanya Kulkarni
2019-06-17 16:12 ` [PATCH v3 3/3] nvme: Set physical block size and optimal I/O size according to NVMe 1.4 Bart Van Assche
2019-06-18  7:51   ` Hannes Reinecke
2019-06-19  4:17   ` Martin K. Petersen
2019-06-18  7:52 ` [PATCH v3 0/3] NVMe 1.4 Identify Namespace Support Hannes Reinecke
2019-06-18 20:34   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68786de5-cdd8-c6d8-98a7-8a4310dac789@acm.org \
    --to=bvanassche@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.