From: "Sundaresan, Sujaritha" <sujaritha.sundaresan@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
"Wajdeczko, Michal" <Michal.Wajdeczko@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915/guc: Fixing error code for WOPCM initialization
Date: Wed, 6 Mar 2019 19:17:43 +0000 [thread overview]
Message-ID: <687D8D17F9F506458453BCE47B835DBD55E4B526@FMSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <155186330557.27405.944800209177609752@skylake-alporthouse-com>
-----Original Message-----
From: Chris Wilson <chris@chris-wilson.co.uk>
Sent: Wednesday, March 6, 2019 1:08 AM
To: Wajdeczko, Michal <Michal.Wajdeczko@intel.com>; Sundaresan, Sujaritha <sujaritha.sundaresan@intel.com>; intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Fixing error code for WOPCM initialization
Quoting Michal Wajdeczko (2019-03-06 09:01:09)
> On Wed, 06 Mar 2019 09:45:17 +0100, Chris Wilson
> > Now doing an if (i915_error_injected() && !err) err = -EINVAL; makes
> > sense to catch places where we've eaten that error and so breaking
> > the test.
>
> This will not work today, as at least in one place - i915_gem_init -
> we inject -EIO which later we try to replace with success. And for
> that case we may rather want to add
I think we may want to move that particular test to one side, something along the lines of i915.disable_gpu=1 ?
-Chris
Just to clarify on how to proceed with the fix. I'm not sure if the suggestion is to go back to the previous version of
the patch or to go for a different approach. It also looks like this issue will be flaggin up on the public CI, following the
changes Arek has said will be made to the dmesg style.
-Sujaritha
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-06 19:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 0:55 [PATCH 1/1] drm/i915: Fixing error code for WOPCM initialization Sujaritha Sundaresan
2019-03-05 2:23 ` ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
2019-03-05 7:25 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-05 22:05 ` [PATCH 1/1] " Daniele Ceraolo Spurio
2019-03-05 22:06 ` Daniele Ceraolo Spurio
2019-03-06 0:11 ` Sujaritha
2019-03-06 0:30 ` [PATCH v2] drm/i915/guc: " Sujaritha Sundaresan
2019-03-06 8:41 ` Michal Wajdeczko
2019-03-06 8:45 ` Chris Wilson
2019-03-06 9:01 ` Michal Wajdeczko
2019-03-06 9:08 ` Chris Wilson
2019-03-06 18:44 ` Sujaritha
2019-03-06 19:17 ` Sundaresan, Sujaritha [this message]
2019-03-06 1:31 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915/guc: Fixing error code for WOPCM initialization (rev2) Patchwork
2019-03-06 9:10 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687D8D17F9F506458453BCE47B835DBD55E4B526@FMSMSX108.amr.corp.intel.com \
--to=sujaritha.sundaresan@intel.com \
--cc=Michal.Wajdeczko@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.