From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B05173 for ; Mon, 16 Aug 2021 15:10:06 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id q16so21055537ioj.0 for ; Mon, 16 Aug 2021 08:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ApokTc8mxObi8oLsmYtRa9frQO6t6d0mzitkU5awMsA=; b=Ktq396n8+YfDiWEgaDGrc2kjUj/FbqM187aiv6pP6u0LMj3/QFpzl/GCX8JmtA78jY yBDs/I6ZiBu2UH7uoTcze9yCn7oF0JmgH6GSGMtMkvghXspXiIAgu+DIUqXPzA9nxlj4 wUQC2zigW6KRNF7d3zu+lzRo8g8k/o6ybatkPaKFGzYXWpbX5yez8Qx/PvzKGzlGcREU AssuQ9yIsg1jOgYvYeBQp/S6j7z0Dx5XRad1af35c8fy0m+kinIguuxrhb0lGx4GVWrc wUyPmrhPTicTNIw6oWM/gK0bvsT5INnjm7r5z6idw7bkGR+VeJVa7bOYGb974rHE+jv1 5ZVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ApokTc8mxObi8oLsmYtRa9frQO6t6d0mzitkU5awMsA=; b=sxlMgg8yOXWZ7lozGAv4ylrjC7jq7yFhtKnMW4ehwnIczYb1ih/i0UcEVkSbn8DqO9 yqmMNk4jo/QAl5zysY3p2YfYKzOCZtO9TJiN6bXl7AmZti5/gilWPTFT01LJMlRffrPZ HmP+zjNHTQ6UTKbnnkWefCsWul8gPdRPaxOlAz6Sw8oQiiRPZgXM09Kdb3mDYWvEsTjR sCzJBz3BDLesfuM+2I4+8DAf3E58nzZotdU2Vwp+UaX6DW2xWANCq/aHk4C8qgZxnyQn 4YBVCeyUyCXgRSHH0UiFdYH1lW/i3oU6g57TBiYpaAAT9SlzwhKm9VTQKfjfSOQCkp5E af0Q== X-Gm-Message-State: AOAM531LZ+dtNCNhNZJLSnk+hsge5iJ5QD0/wUIEX4R21YIC99FSy6+Q VlQYEVgjT5arTFlT3WsH0QoyMg== X-Google-Smtp-Source: ABdhPJzyIkOm/xZ02NFnTH6W4iDNwHM/gJaa4hr0GPRjC4doNqTHl9+QaDOnw/R0q7UZnod0GL2mSw== X-Received: by 2002:a05:6638:329d:: with SMTP id f29mr15989957jav.140.1629126605321; Mon, 16 Aug 2021 08:10:05 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id w10sm5725935ioc.55.2021.08.16.08.10.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 08:10:04 -0700 (PDT) Subject: Re: [greybus-dev] [PATCH v2] staging: greybus: Convert uart.c from IDR to XArray To: Dan Carpenter , Greg Kroah-Hartman Cc: Alex Elder , kernel test robot , linux-staging@lists.linux.dev, Johan Hovold , linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org, "Fabio M. De Francesco" References: <20210814181130.21383-1-fmdefrancesco@gmail.com> <5541b638-db1e-26f2-2682-81f35504c9a3@ieee.org> <20210816150653.GH1931@kadam> From: Alex Elder Message-ID: <687f29ce-6245-e549-9b7b-7cc2befba962@linaro.org> Date: Mon, 16 Aug 2021 10:10:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210816150653.GH1931@kadam> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/16/21 10:06 AM, Dan Carpenter wrote: > On Mon, Aug 16, 2021 at 05:01:02PM +0200, Greg Kroah-Hartman wrote: >> On Mon, Aug 16, 2021 at 09:46:08AM -0500, Alex Elder wrote: >>> On 8/14/21 1:11 PM, Fabio M. De Francesco wrote: >>>> Convert greybus/uart.c from IDR to XArray. The abstract data type XArray >>>> is more memory-efficient, parallelisable, and cache friendly. It takes >>>> advantage of RCU to perform lookups without locking. Furthermore, IDR is >>>> deprecated because XArray has a better (cleaner and more consistent) API. >>> >>> I haven't verified the use of the new API (yet) but I have a few >>> comments on your patch, below. >>> >>> -Alex >>> >>>> Reported-by: kernel test robot >>>> Signed-off-by: Fabio M. De Francesco >>> >>> I'm not sure I'm right about this... But the actual change you're >>> making has nothing to do with what the Intel test robot reported. >>> I personally find the "Reported-by" here a little misleading, but >>> maybe the "Link" line that gets added will provide explanation. >>> >>> Anyway, unless someone else contradicts/corrects me, I'd rather >>> not have the "Reported-by" here (despite wanting to provide much >>> credit to ...). >> >> You are correct, "Reported-by:" does not make sense here. > > There should be a Fixes-from: tag for bugs found in review (not style > issues) but when I suggest it then people just say to use the > Reported-by tag. I think things caught during review aren't normally worthy of specific mention in the commit message (though maybe in the non-committed part under "---"). I mean, that's what review is for. And in the case of what does, that's effectively a technical aspect of "review." So I don't think "Fixes-from" (whatever that means) or "Reported-by" make sense for this type of update. -Alex > > regards, > dan carpenter > > _______________________________________________ > greybus-dev mailing list > greybus-dev@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/greybus-dev >