Hi Jonas,

On 10/17/2018 11:30 AM, Jonas Bonn wrote:
> 
> 
> On 17/10/18 17:18, Denis Kenzior wrote:
>> Hi Jonas,
>>>> +
>>>> +extern void gemalto_voicecall_init();
>>>> +extern void gemalto_voicecall_exit();
>>>> +
>>>
>>> Why are these "extern"?
>>>
>>
>> Okay, I haven't had my coffee yet, but what is the actual problem?  
>> All functions defined in the header are extern anyway, whether they're 
>> labeled extern or not.  So, dropping extern would have no actual 
>> effect besides style.
> 
> No, of course, it's stylistic... just interesting that this particular 
> style is used in these particular header files and nowhere else.  Was 
> there a reason for that once?  Something to do with modules/plugins?

That is a good question.  I'm not sure there was a reason.  But then 
that code is ~10 years old, so I wouldn't remember the reason anyway.

If it bothers you so much, feel free to remove the externs.

> 
> Grab a coffee.  The day is long!
> 

Yep, having it now.  :)

Regards,
-Denis