From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v2 5/7] ACPI/SFI: Fix wrong inclusion in SFI/ACPI wrapper - table definitions. Date: Mon, 07 Jul 2014 23:25:20 +0200 Message-ID: <6888009.veyX2bKRlF@vostro.rjw.lan> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: Received: from v094114.home.net.pl ([79.96.170.134]:59289 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751345AbaGGVHQ (ORCPT ); Mon, 7 Jul 2014 17:07:16 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Lv Zheng Cc: "Rafael J. Wysocki" , Len Brown , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Len Brown , sfi-devel@simplefirmware.org On Monday, July 07, 2014 12:17:28 PM Lv Zheng wrote: > This patch removes inclusions from as > has already included it for CONFIG_ACPI=n builds. So are patches [1-4/5] only needed to fix this particular issue? > Cc: Len Brown > Cc: sfi-devel@simplefirmware.org > Signed-off-by: Lv Zheng > --- > include/linux/sfi_acpi.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/sfi_acpi.h b/include/linux/sfi_acpi.h > index 4723bbf..a6e555c 100644 > --- a/include/linux/sfi_acpi.h > +++ b/include/linux/sfi_acpi.h > @@ -63,8 +63,6 @@ > #include > > #ifdef CONFIG_SFI > -#include /* FIXME: inclusion should be removed */ > - > extern int sfi_acpi_table_parse(char *signature, char *oem_id, > char *oem_table_id, > int (*handler)(struct acpi_table_header *)); > @@ -78,7 +76,6 @@ static inline int __init acpi_sfi_table_parse(char *signature, > return sfi_acpi_table_parse(signature, NULL, NULL, handler); > } > #else /* !CONFIG_SFI */ > - > static inline int sfi_acpi_table_parse(char *signature, char *oem_id, > char *oem_table_id, > int (*handler)(struct acpi_table_header *)) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.