From: Daniel Borkmann <daniel@iogearbox.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jiri Olsa" <jolsa@redhat.com>
Cc: ast@fb.com, bpf@vger.kernel.org, netdev@vger.kernel.org,
jolsa@kernel.org
Subject: Re: [PATCH bpf] tools/bpf: build: make sure resolve_btfids cleans up after itself
Date: Tue, 1 Sep 2020 18:13:40 +0200 [thread overview]
Message-ID: <68904564-aa5a-0ba7-01e6-21484daceb8c@iogearbox.net> (raw)
In-Reply-To: <87sgc1iior.fsf@toke.dk>
On 9/1/20 6:08 PM, Toke Høiland-Jørgensen wrote:
> Jiri Olsa <jolsa@redhat.com> writes:
>
>> On Tue, Sep 01, 2020 at 04:43:43PM +0200, Toke Høiland-Jørgensen wrote:
>>> The new resolve_btfids tool did not clean up the feature detection folder
>>> on 'make clean', and also was not called properly from the clean rule in
>>> tools/make/ folder on its 'make clean'. This lead to stale objects being
>>> left around, which could cause feature detection to fail on subsequent
>>> builds.
>>>
>>> Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
>>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Applied, thanks guys!
next prev parent reply other threads:[~2020-09-01 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 14:43 [PATCH bpf] tools/bpf: build: make sure resolve_btfids cleans up after itself Toke Høiland-Jørgensen
2020-09-01 15:20 ` Jiri Olsa
2020-09-01 16:08 ` Toke Høiland-Jørgensen
2020-09-01 16:13 ` Daniel Borkmann [this message]
2020-09-01 19:28 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68904564-aa5a-0ba7-01e6-21484daceb8c@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.