From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH v5 1/4] net/mlx5: add flow action functions
	to glue
Date: Thu, 11 Oct 2018 17:05:09 +0000
Message-ID: <68B2734D-87B8-43D8-A8B3-BBBAAEEE3739@mellanox.com>
References: <1539160531-27953-1-git-send-email-dekelp@mellanox.com>
 <1539259967-10975-2-git-send-email-dekelp@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>, Ori
 Kam <orika@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20070.outbound.protection.outlook.com [40.107.2.70])
 by dpdk.org (Postfix) with ESMTP id C20651B53A
 for <dev@dpdk.org>; Thu, 11 Oct 2018 19:05:10 +0200 (CEST)
In-Reply-To: <1539259967-10975-2-git-send-email-dekelp@mellanox.com>
Content-Language: en-US
Content-ID: <44DBA66123253A4F9D7BEB0403AAE06A@eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On Oct 11, 2018, at 5:12 AM, Dekel Peled <dekelp@mellanox.com> wrote:
>=20
> This patch adds glue functions for operations:
> - Create packet reformat (encap/decap) flow action.
> - Destroy flow action.
>=20
> The new operations depend on HAVE_IBV_FLOW_DV_SUPPORT.
>=20
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> drivers/net/mlx5/Makefile    |  2 +-
> drivers/net/mlx5/meson.build |  2 +-
> drivers/net/mlx5/mlx5_glue.c | 38 ++++++++++++++++++++++++++++++++++++++
> drivers/net/mlx5/mlx5_glue.h | 10 ++++++++++
> 4 files changed, 50 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> index 92bae9d..bbfb686 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -139,7 +139,7 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-confi=
g-h.sh
> 	$Q sh -- '$<' '$@' \
> 		HAVE_IBV_FLOW_DV_SUPPORT \
> 		infiniband/mlx5dv.h \
> -		enum MLX5DV_FLOW_ACTION_TAG \
> +		func mlx5dv_create_flow_action_packet_reformat \
> 		$(AUTOCONF_OUTPUT)
> 	$Q sh -- '$<' '$@' \
> 		HAVE_ETHTOOL_LINK_MODE_25G \
> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
> index 6966248..c93347c 100644
> --- a/drivers/net/mlx5/meson.build
> +++ b/drivers/net/mlx5/meson.build
> @@ -95,7 +95,7 @@ if build
> 		[ 'HAVE_IBV_MLX5_MOD_CQE_128B_COMP', 'infiniband/mlx5dv.h',
> 		'MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP' ],
> 		[ 'HAVE_IBV_FLOW_DV_SUPPORT', 'infiniband/mlx5dv.h',
> -		'MLX5DV_FLOW_ACTION_TAG' ],
> +		'mlx5dv_create_flow_action_packet_reformat' ],
> 		[ 'HAVE_IBV_DEVICE_MPLS_SUPPORT', 'infiniband/verbs.h',
> 		'IBV_FLOW_SPEC_MPLS' ],
> 		[ 'HAVE_IBV_WQ_FLAG_RX_END_PADDING', 'infiniband/verbs.h',
> diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
> index 48590df..565c2cf 100644
> --- a/drivers/net/mlx5/mlx5_glue.c
> +++ b/drivers/net/mlx5/mlx5_glue.c
> @@ -174,6 +174,17 @@
> 	return ibv_destroy_flow(flow_id);
> }
>=20
> +static int
> +mlx5_glue_destroy_flow_action(struct ibv_flow_action *action)
> +{
> +#ifdef HAVE_IBV_FLOW_DV_SUPPORT
> +	return ibv_destroy_flow_action(action);
> +#else
> +	(void)action;
> +	return -ENOTSUP;

Please revert it to positive value and submit v6 with my acked-by tag.=20

Thanks
Yongseok=