From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7900C43331 for ; Sat, 9 Nov 2019 08:31:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C8CB21848 for ; Sat, 9 Nov 2019 08:31:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726275AbfKII05 (ORCPT ); Sat, 9 Nov 2019 03:26:57 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:5752 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726136AbfKII04 (ORCPT ); Sat, 9 Nov 2019 03:26:56 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 32D67157DA822E96A5FA; Sat, 9 Nov 2019 16:26:53 +0800 (CST) Received: from [127.0.0.1] (10.184.12.158) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Sat, 9 Nov 2019 16:26:43 +0800 Subject: Re: [PATCH v2 01/11] irqchip/gic-v3-its: Free collection mapping on device teardown To: Marc Zyngier , CC: Thomas Gleixner , Jason Cooper , , , Heyi Guo References: <20191108165805.3071-1-maz@kernel.org> <20191108165805.3071-2-maz@kernel.org> From: Zenghui Yu Message-ID: <68a30908-90ea-7aeb-0ef2-6197ef8805e3@huawei.com> Date: Sat, 9 Nov 2019 16:26:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Thunderbird/64.0 MIME-Version: 1.0 In-Reply-To: <20191108165805.3071-2-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.184.12.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/11/9 0:57, Marc Zyngier wrote: > We allocate the collection mapping on device creation, but somehow > free it on the irqdomain free path, which is pretty inconsistent > and has led to bugs in the past. > > Move it to the point where we teardown the device, making the > alloc/free symetric. > > Signed-off-by: Marc Zyngier Reviewed-by: Zenghui Yu