From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Mike Rapoport <rppt@linux.ibm.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 2/3] mm: Add PUD level pagetable account
Date: Sun, 3 Jul 2022 23:07:47 +0800 [thread overview]
Message-ID: <68a5286b-7ff3-2c4e-1ab2-305e7860a2f3@linux.alibaba.com> (raw)
In-Reply-To: <YsGtPnfB4/A8pFhA@casper.infradead.org>
On 7/3/2022 10:52 PM, Matthew Wilcox wrote:
> On Sun, Jul 03, 2022 at 10:06:32PM +0800, Baolin Wang wrote:
>> So for kernel pte page table allocation, I need another similar helpers like
>> below. However they do the samething with
>> pgtable_pud_page_ctor/pgtable_pud_page_dtor, so I am not sure this is good
>> for adding these duplicate code.
>
> Why do we want to account kernel PTE page tables in NR_PAGETABLE?
> I think that's confusing.
Why this will confuse you? I think it is inconsistent that kernel PTE
page tables are not accounted, because we will account PMD/PUD level
page tables no matter they are userspace pagetable pages or kernel
pagetable pages.
Moreover the the vmalloc()/vmap() can consume some kernel pagetable
pages, which should be accounted.
next prev parent reply other threads:[~2022-07-03 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:11 [RFC PATCH v3 0/3] Add PUD and kernel PTE level pagetable account Baolin Wang
2022-06-30 11:11 ` [RFC PATCH v3 1/3] mm: Factor out the pagetable pages account into new helper function Baolin Wang
2022-06-30 14:11 ` Mike Rapoport
2022-07-01 8:00 ` Baolin Wang
2022-07-02 10:15 ` Mike Rapoport
2022-07-03 13:48 ` Baolin Wang
2022-06-30 11:11 ` [RFC PATCH v3 2/3] mm: Add PUD level pagetable account Baolin Wang
2022-06-30 14:17 ` Mike Rapoport
2022-07-01 8:04 ` Baolin Wang
2022-07-03 3:40 ` Matthew Wilcox
2022-07-03 14:06 ` Baolin Wang
2022-07-03 14:28 ` Mike Rapoport
2022-07-03 14:49 ` Baolin Wang
2022-07-03 14:52 ` Matthew Wilcox
2022-07-03 15:07 ` Baolin Wang [this message]
2022-07-03 3:47 ` Matthew Wilcox
2022-07-03 14:18 ` Mike Rapoport
2022-06-30 11:11 ` [RFC PATCH v3 3/3] mm: Add kernel PTE level pagetable pages account Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a5286b-7ff3-2c4e-1ab2-305e7860a2f3@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.