From: Joe Perches <joe@perches.com>
To: Hu Haowen <src.res@email.cn>, apw@canonical.com
Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: add grammatical judgement for total output
Date: Wed, 21 Jul 2021 09:03:41 -0700 [thread overview]
Message-ID: <68b4f05607e9e44559e174d9b50e435fb58ef5aa.camel@perches.com> (raw)
In-Reply-To: <20210721151416.30530-1-src.res@email.cn>
On Wed, 2021-07-21 at 23:14 +0800, Hu Haowen wrote:
> There lacked a English grammatical identification within the final
> output of checkpatch.pl such as the following:
>
> total: 1 errors, 11 warnings, 4094 lines checked
> ^
>
> Which violated the rule about the usage of the singular form and the
> plural form. Hence fix the issue up and make it output the proper
> sentence.
NAK
I appreciate the desire for precision but I don't want to require
any automated downstream user of checkpatch to be changed.
I think users understand the output even though it may not be
grammatically correct in some cases.
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -7439,9 +7439,14 @@ sub process {
> print report_dump();
> if ($summary && !($clean == 1 && $quiet == 1)) {
> print "$filename " if ($summary_file);
> - print "total: $cnt_error errors, $cnt_warn warnings, " .
> - (($check)? "$cnt_chk checks, " : "") .
> - "$cnt_lines lines checked\n";
> + my $errors_str = ($cnt_error == 1) ? "error" : "errors";
> + my $warnings_str = ($cnt_warn == 1) ? "warning" : "warnings";
> + my $checks_str = ($cnt_chk == 1) ? "check" : "checks";
> + my $lines_str = ($cnt_lines == 1) ? "line" : "lines";
> + print "total: $cnt_error $errors_str, " .
> + "$cnt_warn $warnings_str, " .
> + (($check)? "$cnt_chk $checks_str, " : "") .
> + "$cnt_lines $lines_str checked\n";
> }
>
>
> if ($quiet == 0) {
next prev parent reply other threads:[~2021-07-21 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 15:14 [PATCH] checkpatch: add grammatical judgement for total output Hu Haowen
2021-07-21 16:03 ` Joe Perches [this message]
2021-07-22 10:04 ` Hu Haowen
2021-07-22 17:01 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b4f05607e9e44559e174d9b50e435fb58ef5aa.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=src.res@email.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.