From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/5] drm/i915/execlists: Direct submit onto idle engines Date: Thu, 10 May 2018 18:26:31 +0100 Message-ID: <68b5b65f-e504-9cc5-a8a5-6d106cade0f5@linux.intel.com> References: <20180509142801.28130-1-chris@chris-wilson.co.uk> <20180509142801.28130-3-chris@chris-wilson.co.uk> <52b631ff-5760-dc18-bc9f-e385fe8f10b9@linux.intel.com> <152596950582.19716.12455454575905000362@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B082E6EFD8 for ; Thu, 10 May 2018 17:26:41 +0000 (UTC) In-Reply-To: <152596950582.19716.12455454575905000362@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzA1LzIwMTggMTc6MjUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA1LTEwIDE3OjA5OjE0KQo+Pgo+PiBPbiAwOS8wNS8yMDE4IDE1OjI3 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBCeXBhc3MgdXNpbmcgdGhlIHRhc2tsZXQgdG8gc3Vi bWl0IHRoZSBmaXJzdCByZXF1ZXN0IHRvIEhXLCBhcyB0aGUKPj4+IHRhc2tsZXQgbWF5IGJlIGRl ZmVycmVkIHVudG8ga3NvZnRpcnFkIGFuZCBhdCBhIG1pbmltdW0gd2lsbCBhZGQgaW4KPj4+IGV4 Y2VzcyBvZiAxMHVzIChhbmQgbWF5YmUgdGVucyBvZiBtaWxsaXNlY29uZHMpIHRvIG91ciBleGVj dXRpb24KPj4+IGxhdGVuY3kuIFRoaXMgbGF0ZW5jeSByZWR1Y3Rpb24gaXMgbW9zdCBub3RhYmxl IHdoZW4gZXhlY3V0aW9uIGZsb3dzCj4+PiBiZXR3ZWVuIGVuZ2luZXMuCj4+Pgo+Pj4gdjI6IEJl d2FyZSBoYW5kbGluZyBwcmVlbXB0aW9uIGNvbXBsZXRpb24gZnJvbSB0aGUgZGlyZWN0IHN1Ym1p dCBwYXRoIGFzCj4+PiB3ZWxsLgo+Pj4gdjM6IE1ha2UgdGhlIGFidXNlIGNsZWFyIGFuZCB0cmFj ayBvdXIgZXh0cmEgc3RhdGUgaW5zaWRlIGk5MTVfdGFza2xldC4KPj4+Cj4+PiBTdWdnZXN0ZWQt Ynk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+PiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+IENjOiBU dnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Rhc2tsZXQuaCAgICAgICAgIHwgMjQgKysrKysrKwo+ Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Npb24uYyB8IDEwICsr LQo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgICAgICB8IDcx ICsrKysrKysrKysrKysrKysrLS0tLQo+Pj4gICAgMyBmaWxlcyBjaGFuZ2VkLCA4OSBpbnNlcnRp b25zKCspLCAxNiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV90YXNrbGV0LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Rhc2ts ZXQuaAo+Pj4gaW5kZXggNDJiMDAyYjg4ZWRiLi45OWUyZmEyMjQxYmEgMTAwNjQ0Cj4+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Rhc2tsZXQuaAo+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV90YXNrbGV0LmgKPj4+IEBAIC04LDggKzgsMTEgQEAKPj4+ICAgICNk ZWZpbmUgX0k5MTVfVEFTS0xFVF9IXwo+Pj4gICAgCj4+PiAgICAjaW5jbHVkZSA8bGludXgvYXRv bWljLmg+Cj4+PiArI2luY2x1ZGUgPGxpbnV4L2JpdG9wcy5oPgo+Pj4gICAgI2luY2x1ZGUgPGxp bnV4L2ludGVycnVwdC5oPgo+Pj4gICAgCj4+PiArI2luY2x1ZGUgImk5MTVfZ2VtLmgiCj4+PiAr Cj4+PiAgICAvKioKPj4+ICAgICAqIHN0cnVjdCBpOTE1X3Rhc2tsZXQgLSB3cmFwcGVyIGFyb3Vu ZCB0YXNrbGV0X3N0cnVjdAo+Pj4gICAgICoKPj4+IEBAIC0xOSw2ICsyMiw4IEBACj4+PiAgICAg Ki8KPj4+ICAgIHN0cnVjdCBpOTE1X3Rhc2tsZXQgewo+Pj4gICAgICAgIHN0cnVjdCB0YXNrbGV0 X3N0cnVjdCBiYXNlOwo+Pj4gKyAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPj4+ICsjZGVmaW5l IEk5MTVfVEFTS0xFVF9ESVJFQ1RfU1VCTUlUIEJJVCgwKQo+Pgo+PiBJIHdvdWxkIHN1Z2dlc3Qg YSBtb3JlIGdlbmVyaWMgbmFtZSBmb3IgdGhlIGJpdCBzaW5jZSBpOTE1X3Rhc2tsZXQgaXMKPj4g Z2VuZXJpYy1pc2guIEZvciBpbnN0YW5jZSBzaW1wbHkgSTkxNV9UQVNLTEVUX0RJUkVDVCB3b3Vs ZCBzaWduaWZ5IHRoZQo+PiBjYWxsYmFjayBoYXMgYmVlbiBpbnZva2VkIGRpcmVjdGx5IGFuZCBu b3QgKG5lY2Vzc2FyaWx5KSBmcm9tIHNvZnRpcnEKPj4gY29udGV4dC4gVGhlbiBpdCBpcyBmb3Ig ZWFjaCB1c2VyIHRvIGtub3cgd2hhdCB0aGF0IG1lYW5zIGZvciB0aGVtCj4+IHNwZWNpZmljYWxs eS4KPiAKPiBQcm9ibGVtIGlzIHdlIGhhdmUgdHdvIGRpcmVjdCBpbnZvY2F0aW9ucywgb25seSBv bmUgaXMgc3BlY2lhbC4gSXQKPiByZWFsbHkgd2FudHMgdG8gYmUgc29tZXRoaW5nIGxpa2UgSTkx NV9UQVNLTEVUX0VOR0lORV9JU19MT0NLRUQgLSB5b3UgY2FuCj4gc2VlIHdoeSBJIGRpZG4ndCBw cm9wb3NlIHRoYXQuCgpUQkMuLi4KCj4+PiAtc3RhdGljIHZvaWQgX19zdWJtaXRfcXVldWUoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBpbnQgcHJpbykKPj4+ICtzdGF0aWMgdm9pZCBf X3dha2V1cF9xdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsIGludCBwcmlvKQo+ Pj4gICAgewo+Pj4gICAgICAgIGVuZ2luZS0+ZXhlY2xpc3RzLnF1ZXVlX3ByaW9yaXR5ID0gcHJp bzsKPj4+ICt9Cj4+Cj4+IFdoeSBpcyB0aGlzIGNhbGxlZCB3YWtldXA/IFBsYW5zIHRvIGFkZCBz b21ldGhpbmcgaW4gaXQgbGF0ZXI/Cj4gCj4gWWVzLiBJdCdzIGNhbGxlZCB3YWtldXAgYmVjYXVz ZSBpdCdzIHNldHRpbmcgdGhlIHZhbHVlIHRoYXQgdGhlIGRlcXVldWUKPiB3YWtlcyB1cCBhdC4g Rmlyc3QgbmFtZSB3YXMga2lja19xdWV1ZSwgYnV0IGl0IGRvZXNuJ3Qga2ljayBlaXRoZXIuCj4g Cj4gVGhlIGxhdGVyIHNpZGUtZWZmZWN0IGludm9sdmVzIGNvbnRyb2xsaW5nIHRpbWVycy4KPiAK PiBfX3Jlc3RhcnRfcXVldWUoKT8KCl9fdXBkYXRlX3F1ZXVlX3ByaW9yaXR5PyA6KQoKPiAKPj4+ ICtzdGF0aWMgdm9pZCBfX3NjaGVkdWxlX3F1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSkKPj4+ICt7Cj4+PiAgICAgICAgaTkxNV90YXNrbGV0X3NjaGVkdWxlKCZlbmdpbmUtPmV4 ZWNsaXN0cy50YXNrbGV0KTsKPj4+ICAgIH0KPj4+ICAgIAo+Pj4gK3N0YXRpYyBib29sIF9fZGly ZWN0X3N1Ym1pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqY29uc3QgZXhlY2xpc3Rz KQo+Pj4gK3sKPj4+ICsgICAgIHN0cnVjdCBpOTE1X3Rhc2tsZXQgKiBjb25zdCB0ID0gJmV4ZWNs aXN0cy0+dGFza2xldDsKPj4+ICsKPj4+ICsgICAgIGlmICghdGFza2xldF90cnlsb2NrKCZ0LT5i YXNlKSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+Pj4gKwo+Pj4gKyAgICAgdC0+ ZmxhZ3MgfD0gSTkxNV9UQVNLTEVUX0RJUkVDVF9TVUJNSVQ7Cj4+PiArICAgICBpOTE1X3Rhc2ts ZXRfcnVuKHQpOwo+Pj4gKyAgICAgdC0+ZmxhZ3MgJj0gfkk5MTVfVEFTS0xFVF9ESVJFQ1RfU1VC TUlUOwo+Pj4gKwo+Pj4gKyAgICAgdGFza2xldF91bmxvY2soJnQtPmJhc2UpOwo+Pgo+PiBGZWVs cyBsaWtlIHRoaXMgd2hvbGUgc2VxdWVuY2UgYmVsb25ncyB0byBpOTE1X3Rhc2tsZXQgc2luY2Ug aXQgdG91Y2hlcwo+PiB0aGUgaW50ZXJuYWxzLiBNYXliZSBpOTE1X3Rhc2tsZXRfdHJ5X3J1biwg b3IgaTkxNV90YXNrbGV0X3J1bl9vcl9zY2hlZHVsZT8KPiAKPiBLZWVwIHJlYWRpbmcgdGhlIHNl cmllcyBhbmQgeW91J2xsIHNlZSBqdXN0IHdoeSB0aGlzIGlzIHNvIHNwZWNpYWwgYW5kCj4gY29u ZmluZWQgdG8gZXhlY2xpc3RzLgoKLi4uIFRCQyBoZXJlLgoKSGF2aW5nIHBlZWtlZCBhaGVhZCwg aXQgZmVlbHMgYSBiaXQgbm90IGdlbmVyaWMgZW5vdWdoIGFzIGl0IGlzLCBhIGJpdCAKdG9vIGhh Y2t5LgoKV291bGQgaXQgd29yayB0byBwYXNzIGNvbnRleHQgdG9nZXRoZXIgd2l0aCB0aGUgaW52 b2NhdGlvbi4gTGlrZToKCmk5MTVfdGFza2xldF90cnkoLi4uLCBJOTE1X1RBU0tMRVRfU1VCTUlU X0lETEUpOwppOTE1X3Rhc2tsZXRfdHJ5KC4uLiwgSTkxNV9UQVNLTEVUX1NVQk1JVF9JUlEpOwoK aTkxNV90YXNrbGV0LmZsYWdzIGZpZWxkIG5hbWVzcGFjZSB3b3VsZCB0aGVuIGJlIG93bmVkIGJ5 IHRoZSBjYWxsZXIgCmNvbXBsZXRlbHkuIEFuZCB0aGUgdGFza2xldCBmdW5jIGl0c2VsZiB3b3Vs ZCBoYXZlIG1vcmUgY29udGV4dCBvbiB3aGF0IAp0byBkby4KCkZvbGxvd2luZyBmb3JtIHRoYXQs IGk5MTVfdGFza2xldF9ydW5fb3Jfc2NoZWR1bGUoLi4sIGZsYWdzKS4KCmJvb2wgaTkxNV90YXNr bGVfdHJ5KHRhc2tsZXQsIGZsYWdzKQp7CglpZiAoIXRyeWxvY2spCgkJcmV0dXJuIGZhbHNlOwoK CXQtPmZsYWdzIHw9IGZsYWdzOwoJaTkxNV90YXNrbGV0X3J1biguLi4pOwoJdC0+ZmxhZ3MgJj0g fmZsYWdzOwoKCXRhc2tsZXRfdW5sb2NrKC4uLik7CgoJcmV0dXJuIHRydWU7Cn0KCgp2b2lkIGk5 MTVfdGFza2xldF9ydW5fb3Jfc2NoZWR1bGUoLi4uLCBmbGFncykKewoJaWYgKCFpOTE1X3Rhc2ts ZXRfdHJ5KC4uLiwgZmxhZ3MpKQoJCWk5MTVfdGFza2xldF9zY2hlZHVsZSguLi4pOwp9Cgo/CgpM ZWF2ZXMgYSBxdWVzdGlvbiBvZiBhIHRhc2tsZXRfaXNfZW5hYmxlZCBjaGVjayBpbiB5b3VyIHRh c2tsZXRfdHJ5LCAKd2hpY2ggSSBkb24ndCBxdWl0ZSBnZXQgc2luY2UgdGhhdCBjaGVjayB3YXNu J3QgdGhlcmUgYmVmb3JlLiBTbyB3aHkgaXQgCmlzIG5lZWRlZD8KCj4gCj4+PiArICAgICByZXR1 cm4gdHJ1ZTsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIHZvaWQgX19zdWJtaXRfcXVldWUoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+Pj4gK3sKPj4+ICsgICAgIHN0cnVjdCBpbnRl bF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xpc3RzID0gJmVuZ2luZS0+ZXhlY2xpc3Rz Owo+Pj4gKwo+Pj4gKyAgICAgR0VNX0JVR19PTighZW5naW5lLT5pOTE1LT5ndC5hd2FrZSk7Cj4+ PiArCj4+PiArICAgICAvKiBJZiBpbnNpZGUgR1BVIHJlc2V0LCB0aGUgdGFza2xldCB3aWxsIGJl IHF1ZXVlZCBsYXRlci4gKi8KPj4+ICsgICAgIGlmICghaTkxNV90YXNrbGV0X2lzX2VuYWJsZWQo JmV4ZWNsaXN0cy0+dGFza2xldCkpCj4+PiArICAgICAgICAgICAgIHJldHVybjsKPj4+ICsKPj4+ ICsgICAgIC8qIERpcmVjdGx5IHN1Ym1pdCB0aGUgZmlyc3QgcmVxdWVzdCB0byByZWR1Y2UgdGhl IGluaXRpYWwgbGF0ZW5jeSAqLwo+Pj4gKyAgICAgaWYgKHBvcnRfaXNzZXQoZXhlY2xpc3RzLT5w b3J0KSB8fCAhX19kaXJlY3Rfc3VibWl0KGV4ZWNsaXN0cykpCj4+PiArICAgICAgICAgICAgIF9f c2NoZWR1bGVfcXVldWUoZW5naW5lKTsKPj4KPj4gSG1tIGEgYml0IGV2aWwgdG8gbWF5YmUgaW52 b2tlIGluIHRoZSBjb25kaXRpb24uIFdvdWxkIGl0IGJlIGFjY2VwdGFibGUgdG86Cj4+Cj4+IGlm ICghcG9ydF9pc3NldCguLi4pKQo+PiAgICAgICAgICBpOTE1X3Rhc2tsZXRfcnVuX29yX3NjaGVk dWxlKC4uLik7Cj4+IGVsc2UKPj4gICAgICAgICAgaTkxNV90YXNrbGV0X3NjaGVkdWxlKC4uLik7 Cj4+Cj4+IEl0J3Mgbm90IGlkZWFsIGJ1dCBtYXliZSBhIGJpdCBiZXR0ZXIuCj4gCj4gQmVhdXR5 IGlzIGluIHRoZSBleWUgb2YgdGhlIGJlaG9sZGVyLCBhbmQgdGhhdCBhaW4ndCBiZWF1dGlmdWwg OikKCkRpZCBub3Qgc2F5IGl0IHdhcywganVzdCBtb3JlIG9idmlvdXMgd2hhdCdzIGhhcHBlbmlu Zy4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==