* [KJ] [PATCH] lp486e.c: cleanup not needed casts
@ 2007-02-15 19:51 Douglas Landgraf
2007-02-15 21:10 ` Tobias Klauser
2007-02-16 2:45 ` Douglas
0 siblings, 2 replies; 3+ messages in thread
From: Douglas Landgraf @ 2007-02-15 19:51 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1.1: Type: text/plain, Size: 100 bytes --]
Removed all unnecessary casts.
Signed-off-by: Douglas Schilling Landgraf <dougsland@gmail.com>
[-- Attachment #1.2: Type: text/html, Size: 244 bytes --]
[-- Attachment #2: patch-linux-2.6.20-lp486e.diff --]
[-- Type: text/x-patch, Size: 1814 bytes --]
--- linux-2.6.20-vanilla/drivers/net/lp486e.c 2007-02-04 16:44:54.000000000 -0200
+++ linux-2.6.20/drivers/net/lp486e.c 2007-02-15 16:59:38.000000000 -0200
@@ -392,7 +392,7 @@
struct i596_private *lp;
int boguscnt = ct;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
while (lp->scb.command) {
if (--boguscnt == 0) {
printk("%s: %s timed out - stat %4.4x, cmd %4.4x\n",
@@ -413,7 +413,7 @@
int i;
// struct i596_rbd *rbd;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
lp->scb.pa_rfd = I596_NULL;
for (i = 0; i < num; i++) {
@@ -470,7 +470,7 @@
struct i596_private *lp;
struct i596_rfd *rfd;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
lp->rx_tail->pa_next = I596_NULL;
do {
@@ -626,7 +626,7 @@
if (i596_scp_setup(dev))
return 1;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
lp->scb.command = 0;
memcpy ((void *)lp->i596_config, init_setup, 14);
@@ -743,9 +743,9 @@
struct i596_private *lp;
struct i596_cmd *cmd;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
while (lp->cmd_head) {
- cmd = (struct i596_cmd *)lp->cmd_head;
+ cmd = lp->cmd_head;
lp->cmd_head = pa_to_va(lp->cmd_head->pa_next);
lp->cmd_backlog--;
@@ -976,7 +976,7 @@
return -EBUSY;
}
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
spin_lock_init(&lp->cmd_lock);
/*
@@ -1073,7 +1073,7 @@
struct tx_cmd *tx_cmd;
struct i596_tbd *tx_cmd_tbd;
- tx_cmd = (struct tx_cmd *) cmd;
+ tx_cmd = cmd;
tx_cmd_tbd = pa_to_va(tx_cmd->pa_tbd);
frames_out++;
@@ -1157,7 +1157,7 @@
unsigned short status, ack_cmd = 0;
int frames_in = 0;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
/*
* The 82596 examines the command, performs the required action,
[-- Attachment #3: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [KJ] [PATCH] lp486e.c: cleanup not needed casts
2007-02-15 19:51 [KJ] [PATCH] lp486e.c: cleanup not needed casts Douglas Landgraf
@ 2007-02-15 21:10 ` Tobias Klauser
2007-02-16 2:45 ` Douglas
1 sibling, 0 replies; 3+ messages in thread
From: Tobias Klauser @ 2007-02-15 21:10 UTC (permalink / raw)
To: kernel-janitors
On 2007-02-15 at 20:51:33 +0100, Douglas Landgraf <dougsland@gmail.com> wrote:
>
> Removed all unnecessary casts.
> Signed-off-by: Douglas Schilling Landgraf <[1]dougsland@gmail.com>
Please do not send HTML email. Use plain text instead.
Thanks, Tobias
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
* [KJ] [PATCH] lp486e.c: cleanup not needed casts
2007-02-15 19:51 [KJ] [PATCH] lp486e.c: cleanup not needed casts Douglas Landgraf
2007-02-15 21:10 ` Tobias Klauser
@ 2007-02-16 2:45 ` Douglas
1 sibling, 0 replies; 3+ messages in thread
From: Douglas @ 2007-02-16 2:45 UTC (permalink / raw)
To: kernel-janitors
Removed all unnecessary casts.
Signed-off-by: Douglas Schilling Landgraf <dougsland@gmail.com>
--- linux-2.6.20-vanilla/drivers/net/lp486e.c 2007-02-04 16:44:54.000000000 -0200
+++ linux-2.6.20/drivers/net/lp486e.c 2007-02-15 16:59:38.000000000 -0200
@@ -392,7 +392,7 @@
struct i596_private *lp;
int boguscnt = ct;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
while (lp->scb.command) {
if (--boguscnt = 0) {
printk("%s: %s timed out - stat %4.4x, cmd %4.4x\n",
@@ -413,7 +413,7 @@
int i;
// struct i596_rbd *rbd;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
lp->scb.pa_rfd = I596_NULL;
for (i = 0; i < num; i++) {
@@ -470,7 +470,7 @@
struct i596_private *lp;
struct i596_rfd *rfd;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
lp->rx_tail->pa_next = I596_NULL;
do {
@@ -626,7 +626,7 @@
if (i596_scp_setup(dev))
return 1;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
lp->scb.command = 0;
memcpy ((void *)lp->i596_config, init_setup, 14);
@@ -743,9 +743,9 @@
struct i596_private *lp;
struct i596_cmd *cmd;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
while (lp->cmd_head) {
- cmd = (struct i596_cmd *)lp->cmd_head;
+ cmd = lp->cmd_head;
lp->cmd_head = pa_to_va(lp->cmd_head->pa_next);
lp->cmd_backlog--;
@@ -976,7 +976,7 @@
return -EBUSY;
}
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
spin_lock_init(&lp->cmd_lock);
/*
@@ -1073,7 +1073,7 @@
struct tx_cmd *tx_cmd;
struct i596_tbd *tx_cmd_tbd;
- tx_cmd = (struct tx_cmd *) cmd;
+ tx_cmd = cmd;
tx_cmd_tbd = pa_to_va(tx_cmd->pa_tbd);
frames_out++;
@@ -1157,7 +1157,7 @@
unsigned short status, ack_cmd = 0;
int frames_in = 0;
- lp = (struct i596_private *) dev->priv;
+ lp = dev->priv;
/*
* The 82596 examines the command, performs the required action,
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-02-16 2:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15 19:51 [KJ] [PATCH] lp486e.c: cleanup not needed casts Douglas Landgraf
2007-02-15 21:10 ` Tobias Klauser
2007-02-16 2:45 ` Douglas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.