Re: [PATCH v6 0/2] Support for Kontron Electronics i.MX6UL/ULL and i.MX8MM SoMs

[Stefano Babic <sbabic@denx.de>]

Hi Frieder,

On 30.09.21 15:16, Frieder Schrempf wrote:
> Hi Stefano,
> 
> On 29.09.21 16:42, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> This a patchset to upstream the support for the SL i.MX6UL, SL i.MX6ULL and
>> SL i.MX8MM families of SoMs and matching evaluation boards by Kontron
>> Electronics.
>>
>> The first patch adds the i.MX6UL/ULL hardware and the second patch the i.MX8MM
>> hardware.
>>
>> Changes in v3:
> 
> side note:   ^ this should be v6 not v3.
> 
>>    * Drop doc preparation patch as Michael picked it up in his series
>>    * Fixes and support for standard distro support for SL/BL i.MX8MM by Heiko (thanks!)
> 
> some weeks ago you picked up a previous version of this set in your
> tree, but it didn't get merged. Meanwhile there have been additional
> iterations and this v6 is now the latest. Can you pick this up for merging?
> 

I get some warnings building the SL i.MX6UL (because something was moved 
into Kconfig). I fixed myself with the following small changes:

diff --git a/configs/kontron-sl-mx6ul_defconfig 
b/configs/kontron-sl-mx6ul_defconfig
index 23d1df7fa9..28b5d0d671 100644
--- a/configs/kontron-sl-mx6ul_defconfig
+++ b/configs/kontron-sl-mx6ul_defconfig
@@ -12,6 +12,7 @@ CONFIG_ENV_OFFSET=0xF0000
  CONFIG_ENV_SECT_SIZE=0x10000
  CONFIG_MX6UL=y
  CONFIG_TARGET_KONTRON_MX6UL=y
+CONFIG_SYS_MALLOC_LEN=0x4000000
  CONFIG_DM_GPIO=y
  CONFIG_DEFAULT_DEVICE_TREE="imx6ul-kontron-n631x-s"
  CONFIG_SPL_TEXT_BASE=0x00908000
@@ -26,7 +27,7 @@ CONFIG_FIT=y
  CONFIG_SPL_LOAD_FIT=y
  # CONFIG_USE_SPL_FIT_GENERATOR is not set
  CONFIG_OF_BOARD_SETUP=y
-CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
+CONFIG_IMX_CONFIG="arch/arm/mach-imx/spl_sd.cfg"
  CONFIG_SYS_CONSOLE_IS_IN_ENV=y
  CONFIG_BOARD_TYPES=y
  CONFIG_BOARD_EARLY_INIT_F=y
diff --git a/include/configs/kontron-sl-mx6ul.h 
b/include/configs/kontron-sl-mx6ul.h
index f2774d5e61..65aa250894 100644
--- a/include/configs/kontron-sl-mx6ul.h
+++ b/include/configs/kontron-sl-mx6ul.h
@@ -22,7 +22,6 @@
  #define CONFIG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
  #define CONFIG_SYS_INIT_RAM_SIZE	IRAM_SIZE

-#define CONFIG_SYS_MALLOC_LEN		SZ_64M
  #define CONFIG_SYS_HZ			1000

  #define CONFIG_SYS_INIT_SP_OFFSET \

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================